Review for Chrome Beta m62: "Use MacViews for Permissions bubbles on Mac" |
|||||
Issue descriptionChrome Version : 62.0.3173.0 Launch bug: Issue 740827 r489245 made Views for permission bubbles enabled-by-default in m62, which is required for launch review. We don't want to _accidentally_ launch the feature, so I'm filing this bug to alert release maintainers and send me appropriate nags to ensure that doesn't happen. To disable, we just need to land https://chromium-review.googlesource.com/597384 . But that should be done with some testing to ensure there are no nasty surprises.
,
Aug 25 2017
Looks like the testing on the Launch bug Issue 740827 is completed as per C#28. Cc'ing hdodda@ for confirmation.
,
Aug 29 2017
Testing of issue 740827 is done and test cases have been updated and reviewed by @tapted. Thanks!
,
Aug 30 2017
tapted@: Shall we tag this as Fixed as per C#3 and if this bug was filed for Test review only.
,
Aug 30 2017
This wasn't filed for test review (that's Issue 755829). This issue is to ensure this feature doesn't launch to stable channel unless we want it to. I see ReleaseBlock-Beta is confusing to use for that, I'll just have to stay on top of it in other ways. I've made a server-side killswitch CL in cl/167063690.
,
Aug 30 2017
,
Sep 14 2017
Launch approval granted, so closing this out. 50/50 beta finch experiment has landed in cl/167063690. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ligim...@chromium.org
, Aug 21 2017