New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 751373 link

Starred by 1 user
Status: Fixed
Owner:
█ rjwright@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 545324



Sign in to add a comment

Ribbonize CSSPropertyMetadata

Project Member Reported by rjwright@google.com, Aug 2 2017

Comment 1 by rjwright@chromium.org, Aug 2 2017

Blocking: 545324
Components: Blink>CSS
Labels: -OS-Linux Update-Monthly
Owner: rjwright@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by rjwright@chromium.org, Aug 2 2017

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/891cdcc6b3c69700611dc1da347e8082ff39c787

commit 891cdcc6b3c69700611dc1da347e8082ff39c787
Author: Renee Wright <rjwright@chromium.org>
Date: Fri Aug 04 06:45:51 2017

[Ribbon] Split existing CSSPropertyAPIs to accommodate CSSPropertyMetadata differences

First change for Ribbonizing CSSPropertyMetadata.

Splits up the existing CSSPropertyAPI groups based on different behavior for CSSPropertyMetadata methods IsInterpolableProperty, IsInheritedProperty, PropertySupportsPercentage, PropertyIsRepeated & RepititionSeparator. IsDescriptor, IsEnabledProperty and FilterEnabledCSSPropertiesIntoVector will be handled later.

CSSPropertyAPIs have been split as follows

- CSSPropertyAPIColor
    - CSSPropertyAPIColor
    - CSSPropertyAPIBackgroundColor
- CSSPropertyAPIColorNoQuirks
    - CSSPropertyAPIColorNoQuirksInherited
    - CSSPropertyAPIColorNoQuirksNonInherited
    - CSSPropertyAPIWekbitTextStrokeColor
    - CSSPropertyAPIWebkitBorderColor
- CSSPropertyAPIFragmentation
    - CSSPropertyAPIOrphansOrWidows
    - CSSPropertyAPIWebkitBoxOrdinalGroup
- CSSPropertyAPIImage
    - CSSPropertyAPIImageSource
    - CSSPropertyAPIListStyleImage
- CSSPropertyAPIMargin
    - CSSPropertyAPIMargin
    - CSSPropertyAPIOffset
- CSSPropertyAPIMarker
    - CSSPropertyAPIMarker
    - CSSPropertyAPIMask
- CSSPropertyAPIOpacity
    - CSSPropertyAPIOpacityInherited
    - CSSPropertyAPIOpacityNonInherited
- CSSPropertyAPIStrokeOrLength
    - CSSPropertyAPIStrokeDashoffsetOrStrokeWidth
    - CSSPropertyAPILength
- CSSPropertyAPITextDecorationLine
    - CSSPropertyAPITextDecorationLine
    - CSSPropertyAPIWebkitTextDecorationsInEffect
- CSSPropertyAPIWidthOrHeight
    - CSSPropertyAPIWidthOrHeight
    - CSSPropertyAPIMinWidthOrHeight
BUG= 751373 

Change-Id: I299b8b9051adae3dac74a2eb905916fbb906b7dc
Reviewed-on: https://chromium-review.googlesource.com/597369
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491954}
[modify] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/CSSProperties.json5
[add] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackgroundColor.cpp
[copy] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFillOrStrokeOpacity.cpp
[rename] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIImageSource.cpp
[rename] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPILength.cpp
[copy] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIListStyleImage.cpp
[add] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMask.cpp
[add] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMinWidthOrHeight.cpp
[add] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffset.cpp
[rename] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOrphansOrWidows.cpp
[copy] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeDashoffsetOrStrokeWidth.cpp
[copy] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderColor.cpp
[copy] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxOrdinalGroup.cpp
[copy] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitColorNoQuirks.cpp
[add] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextDecorationsInEffect.cpp
[copy] https://crrev.com/891cdcc6b3c69700611dc1da347e8082ff39c787/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitTextStrokeColor.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ee7ac63f553f3cc588568e99facd83ce110a3f8

commit 6ee7ac63f553f3cc588568e99facd83ce110a3f8
Author: Renee Wright <rjwright@chromium.org>
Date: Sat Aug 05 12:17:33 2017

[Ribbon] Add new property APIs to cover all properties so we can handle their CSSPropertyMetadata

Adds new CSSPropertyAPIs (generated headers only) to cover remaning CSS 
propeties. They are grouped according to whether they are interpolable, 
inherited, repeated, whether they support percents, and any intended 
parser grouping.

CSSPropertyVariable, CSSPropertyApplyAtRule, and descriptor-only
properties are not handled here. I need to decide what to do about those.

Bug:  751373 
Change-Id: I5f90f37f08adcb44890385f37f1f87839e4b7018
Reviewed-on: https://chromium-review.googlesource.com/597331
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492238}
[modify] https://crrev.com/6ee7ac63f553f3cc588568e99facd83ce110a3f8/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/6ee7ac63f553f3cc588568e99facd83ce110a3f8/third_party/WebKit/Source/core/css/CSSProperties.json5
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54ed2d3d71238fd9b0605f03c7ac6f5b8c6cb793

commit 54ed2d3d71238fd9b0605f03c7ac6f5b8c6cb793
Author: Renee Wright <rjwright@chromium.org>
Date: Mon Aug 07 06:37:45 2017

[Ribbon] Add property API for descriptors so we can handle their CSSPropertyMetadata

Bug:  751373 
Change-Id: I89b116dd45393a5a1fe9329ea90864d97e77a7c1
Reviewed-on: https://chromium-review.googlesource.com/603029
Commit-Queue: meade_UTC10 <meade@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492273}
[modify] https://crrev.com/54ed2d3d71238fd9b0605f03c7ac6f5b8c6cb793/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/54ed2d3d71238fd9b0605f03c7ac6f5b8c6cb793/third_party/WebKit/Source/core/css/CSSProperties.json5
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a71f964635eb5f0c51c8eb48761432ffeee15fd

commit 2a71f964635eb5f0c51c8eb48761432ffeee15fd
Author: Takashi Sakamoto <tasak@google.com>
Date: Mon Aug 07 06:54:10 2017

Revert "[Ribbon] Add property API for descriptors so we can handle their CSSPropertyMetadata"

This reverts commit 54ed2d3d71238fd9b0605f03c7ac6f5b8c6cb793.

Reason for revert: 
Seems to fail compile failure:
FAILED: obj/third_party/WebKit/Source/core/core_generated/CSSPropertyAPI.o
gen/blink/core/css/properties/CSSPropertyAPI.cpp:245:33: error: unused variable 'base_api' [-Werror,-Wunused-const-variable]
static constexpr CSSPropertyAPI base_api;
                                ^
1 error generated.

Original change's description:
> [Ribbon] Add property API for descriptors so we can handle their CSSPropertyMetadata
> 
> Bug:  751373 
> Change-Id: I89b116dd45393a5a1fe9329ea90864d97e77a7c1
> Reviewed-on: https://chromium-review.googlesource.com/603029
> Commit-Queue: meade_UTC10 <meade@chromium.org>
> Reviewed-by: meade_UTC10 <meade@chromium.org>
> Reviewed-by: Bugs Nash <bugsnash@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492273}

TBR=rjwright@chromium.org,meade@chromium.org,bugsnash@chromium.org

Change-Id: Ia3ce3a9be9a70ccb95829a70cbeff31714ac86b7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  751373 
Reviewed-on: https://chromium-review.googlesource.com/603037
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#492274}
[modify] https://crrev.com/2a71f964635eb5f0c51c8eb48761432ffeee15fd/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/2a71f964635eb5f0c51c8eb48761432ffeee15fd/third_party/WebKit/Source/core/css/CSSProperties.json5
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cace407cd7976e39ce91b0e0a25164a1b442a94

commit 9cace407cd7976e39ce91b0e0a25164a1b442a94
Author: Renee Wright <rjwright@chromium.org>
Date: Mon Aug 21 11:13:09 2017

[Ribbon] Re-add CSSPropertyAPIMinWidthOrHeight

Originally added here chromium-review.googlesource.com/c/597369
And then removed here chromium-review.googlesource.com/c/615663

Property APIs shouldn't be merged, as they have been split along behav-
ioral lines to accommodate upcoming Ribbon work. There's logic (such
as metadata getters) that differentiate the property APIs that isn't
neccessarily reflected in the api_methods field.

In this case, width and height support percentage, but min-width and
min-height do not.

Bug:  751373 
Change-Id: Ib58093e92bfa8656469ff0131b34994a26fa984f
Reviewed-on: https://chromium-review.googlesource.com/623033
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495909}
[modify] https://crrev.com/9cace407cd7976e39ce91b0e0a25164a1b442a94/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/9cace407cd7976e39ce91b0e0a25164a1b442a94/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/9cace407cd7976e39ce91b0e0a25164a1b442a94/third_party/WebKit/Source/core/css/CSSProperties.json5
[add] https://crrev.com/9cace407cd7976e39ce91b0e0a25164a1b442a94/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMinWidthOrHeight.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e1519ddf90c88e16446f839d769879d9b0be989

commit 1e1519ddf90c88e16446f839d769879d9b0be989
Author: Renee Wright <rjwright@chromium.org>
Date: Tue Aug 22 04:46:43 2017

[Ribbon] Remove CSSPropertyAPIDefaultMetadata

It is not needed with new API design

Bug:  751373 
Change-Id: I0421c125e708d14f4d46d6e26e3c18a2e9cb0c96
Reviewed-on: https://chromium-review.googlesource.com/623037
Commit-Queue: meade_UTC10 <meade@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496216}
[modify] https://crrev.com/1e1519ddf90c88e16446f839d769879d9b0be989/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/1e1519ddf90c88e16446f839d769879d9b0be989/third_party/WebKit/Source/core/css/CSSProperties.json5
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/286d42893fc06767b34c83066d581bd3da84e443

commit 286d42893fc06767b34c83066d581bd3da84e443
Author: Eddy Mead <meade@chromium.org>
Date: Wed Aug 23 06:27:38 2017

Add support for having a CSSPropertyAPI for CSSPropertyApplyAtRule and CSSPropertyVariable

Diff of generated CSSPropertyAPI.cpp:
https://www.diffchecker.com/jIgWEunn

Bug:  753010 , 751373 
Change-Id: I06ce4a0b038311b779e1f6e1e33c9de570f637eb
Reviewed-on: https://chromium-review.googlesource.com/620512
Commit-Queue: meade_UTC10 <meade@chromium.org>
Reviewed-by: Renée Wright <rjwright@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496601}
[modify] https://crrev.com/286d42893fc06767b34c83066d581bd3da84e443/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_api_base.py
[modify] https://crrev.com/286d42893fc06767b34c83066d581bd3da84e443/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.cpp.tmpl
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a428a0569624bd59110975231eb32141e75abd7

commit 8a428a0569624bd59110975231eb32141e75abd7
Author: Renee Wright <rjwright@chromium.org>
Date: Wed Aug 23 08:50:24 2017

[Ribbon] Add property API for descriptors so we can handle their metadata

This is a re-upload of chromium-review.googlesource.com/c/603029
Depends on https://chromium-review.googlesource.com/c/620512

Bug:  751373 
Change-Id: I212780b0814ee849d112e7ebc42c83f17d480075
Reviewed-on: https://chromium-review.googlesource.com/622289
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496635}
[modify] https://crrev.com/8a428a0569624bd59110975231eb32141e75abd7/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/8a428a0569624bd59110975231eb32141e75abd7/third_party/WebKit/Source/core/css/CSSProperties.json5
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a9a1b227ffe419b4887677633ec41009782257d

commit 3a9a1b227ffe419b4887677633ec41009782257d
Author: Renee Wright <rjwright@chromium.org>
Date: Wed Aug 23 23:31:35 2017

[Ribbon] Move CSSPropertyMetadata::IsInterpolableProperty to CSSPropertyAPI

This is the first method from CSSPropertyMetadata to be ribbonized.

Depends on chromium-review.googlesource.com/c/622289

Diff of CSSPropertyMetadata.cpp & CSSPropertyAPIBackgroundColor.h
https://gist.github.com/rjwright/13682a03e7bd8af9bfcad6d1888f9c99/revisions

Bug:  751373 
Change-Id: Id2ee483afbc39b3d3edb7b20af2b09a64f4fb795
Reviewed-on: https://chromium-review.googlesource.com/603194
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496863}
[modify] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/third_party/WebKit/Source/build/scripts/core/css/make_css_property_metadata.py
[modify] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_api_headers.py
[modify] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPISubclass.h.tmpl
[modify] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
[modify] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
[modify] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h
[modify] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp
[modify] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/third_party/WebKit/Source/core/style/ComputedStyle.cpp
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d851cc5ff74d0d621a9e04695879b4d29fbd188a

commit d851cc5ff74d0d621a9e04695879b4d29fbd188a
Author: Renee Wright <rjwright@chromium.org>
Date: Thu Aug 24 07:29:07 2017

[Ribbon] Move CSSPropertyMetadata::IsInheritedProperty to CSSPropertyAPI

This is the second method from CSSPropertyMetadata to be ribbonized.

Depends on chromium-review.googlesource.com/c/603194

Diff of CSSPropertyAPI.cpp, CSSPropertyAPIFontSize.h, CSSPropertyMetadata.cpp
https://gist.github.com/rjwright/c9d4ff584010fabdc0c718f26fab8ce1/revisions

Bug:  751373 
Change-Id: Ia6e832cf3d173b02b47e24c9203438e21a415d93
Reviewed-on: https://chromium-review.googlesource.com/622507
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496972}
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/build/scripts/core/css/make_css_property_metadata.py
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_api_base.py
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_api_headers.py
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.cpp.tmpl
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.h.tmpl
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPISubclass.h.tmpl
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/build/scripts/core/css/templates/CSSPropertyMetadata.cpp.tmpl
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/core/css/CSSProperty.h
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBaseCustom.cpp
[add] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIVariable.h
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/d851cc5ff74d0d621a9e04695879b4d29fbd188a/third_party/WebKit/Source/core/editing/EditingStyle.cpp
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aef53f0f353cdc67eeeac504ebb81d44fb3ce9ce

commit aef53f0f353cdc67eeeac504ebb81d44fb3ce9ce
Author: Renee Wright <rjwright@chromium.org>
Date: Fri Aug 25 05:49:10 2017

[Ribbon] Move PropertyIsRepeated to CSSPropertyAPI

Move CSSPropertyMetadata::PropertyIsRepeated and
CSSPropertyMetadata::RepetitionSeparator to CSSPropertyAPI.

Diff of CSSPropertyAPIAnimationDirection.h & CSSPropertyMetadata.cpp
https://gist.github.com/rjwright/fcf0257f510d88bda9d32b6c81199349/revisions

BUG= 751373 

Change-Id: I5b62e9c400538199f5d19bb5a621d922619da028
Reviewed-on: https://chromium-review.googlesource.com/622329
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497330}
[modify] https://crrev.com/aef53f0f353cdc67eeeac504ebb81d44fb3ce9ce/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_api_headers.py
[modify] https://crrev.com/aef53f0f353cdc67eeeac504ebb81d44fb3ce9ce/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.h.tmpl
[modify] https://crrev.com/aef53f0f353cdc67eeeac504ebb81d44fb3ce9ce/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPISubclass.h.tmpl
[modify] https://crrev.com/aef53f0f353cdc67eeeac504ebb81d44fb3ce9ce/third_party/WebKit/Source/build/scripts/core/css/templates/CSSPropertyMetadata.cpp.tmpl
[modify] https://crrev.com/aef53f0f353cdc67eeeac504ebb81d44fb3ce9ce/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dc867995e0ddcb58b8d31ec0c5ebdbd3ab8f880

commit 3dc867995e0ddcb58b8d31ec0c5ebdbd3ab8f880
Author: Renee Wright <rjwright@chromium.org>
Date: Fri Aug 25 07:44:14 2017

[Ribbon] Move CSSPropertyMetadata::IsDescriptor to CSSPropertyAPI

Diff of CSSPropertyAPIDescriptorOnly.h, CSSPropertyAPIWidthOrHeight.h, 
CSSPropertyMetadata.cpp
https://gist.github.com/rjwright/469376929d3d5b004d8037c07e5052bf/revisions

BUG= 751373 

Change-Id: I878cc15b7463d2251dcd7fb9c484bca4769056c0
Reviewed-on: https://chromium-review.googlesource.com/622466
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497348}
[modify] https://crrev.com/3dc867995e0ddcb58b8d31ec0c5ebdbd3ab8f880/third_party/WebKit/Source/build/scripts/core/css/make_css_property_metadata.py
[modify] https://crrev.com/3dc867995e0ddcb58b8d31ec0c5ebdbd3ab8f880/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_api_headers.py
[modify] https://crrev.com/3dc867995e0ddcb58b8d31ec0c5ebdbd3ab8f880/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.h.tmpl
[modify] https://crrev.com/3dc867995e0ddcb58b8d31ec0c5ebdbd3ab8f880/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPISubclass.h.tmpl
[modify] https://crrev.com/3dc867995e0ddcb58b8d31ec0c5ebdbd3ab8f880/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c0f6f0b54b0345fbd4d2493283b5fd8a039566b

commit 3c0f6f0b54b0345fbd4d2493283b5fd8a039566b
Author: Renee Wright <rjwright@chromium.org>
Date: Mon Aug 28 12:18:16 2017

[Ribbon] Move SupportsPercentage to CSSPropertyAPI

Diff of CSSPropertyMetadata.cpp & CSSPropertyAPIWidthOrHeight.h
https://gist.github.com/rjwright/725b562dafbfbc5ef51d3770a20686c7/revisions

Bug:  751373 

Change-Id: Id81c3a7fc21974499b8b17a28ed54aa6f7082960
Reviewed-on: https://chromium-review.googlesource.com/623036
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497739}
[modify] https://crrev.com/3c0f6f0b54b0345fbd4d2493283b5fd8a039566b/third_party/WebKit/Source/build/scripts/core/css/make_css_property_metadata.py
[modify] https://crrev.com/3c0f6f0b54b0345fbd4d2493283b5fd8a039566b/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_api_headers.py
[modify] https://crrev.com/3c0f6f0b54b0345fbd4d2493283b5fd8a039566b/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.h.tmpl
[modify] https://crrev.com/3c0f6f0b54b0345fbd4d2493283b5fd8a039566b/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPISubclass.h.tmpl
[modify] https://crrev.com/3c0f6f0b54b0345fbd4d2493283b5fd8a039566b/third_party/WebKit/Source/build/scripts/core/css/templates/CSSOMTypes.cpp.tmpl
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104

commit 07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104
Author: Renee Wright <rjwright@chromium.org>
Date: Thu Aug 31 14:03:41 2017

[Ribbon] Move CSSPropertyAPI::IsProperty to CSSPropertyAPI

Bug:  751373 
Change-Id: If6807a788b4af28c5df5f2c504b7d8993294e6e7
Reviewed-on: https://chromium-review.googlesource.com/623607
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498852}
[modify] https://crrev.com/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104/third_party/WebKit/Source/build/scripts/core/css/make_css_property_metadata.py
[modify] https://crrev.com/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_api_headers.py
[modify] https://crrev.com/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.h.tmpl
[modify] https://crrev.com/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPISubclass.h.tmpl
[modify] https://crrev.com/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104/third_party/WebKit/Source/build/scripts/core/css/templates/CSSPropertyMetadata.cpp.tmpl
[modify] https://crrev.com/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104/third_party/WebKit/Source/core/css/CSSProperty.cpp
[modify] https://crrev.com/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
[modify] https://crrev.com/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
[modify] https://crrev.com/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/07f2c3d9cf10b9a55c4656d9cc5fb908e2deb104/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbd1c23fe4d86f2a4788246436b526b65df84775

commit dbd1c23fe4d86f2a4788246436b526b65df84775
Author: Renee Wright <rjwright@chromium.org>
Date: Fri Sep 08 06:24:07 2017

[Ribbon] Move CSSPropertyMetadata::IsEnabledProperty to APIs

This change moves CSSPropertyMetadata::IsEnabledProperty to
APIs and renames it to IsEnabled.

Generated code diff
https://gist.github.com/rjwright/a4f425d85b02e68ae1a1937e319b6fb8/revisions

The change required me to split a few APIs and make some new ones.

Split:
- CSSPropertyAPIFilter split to
    - CSSPropertyAPIFilter, CSSPropertyAPIBackdropFilter
    - NB: This change required some cleanup of
      CSSPropertyAPIFilter::ParseSingleValue. That logic
      has been moved to CSSPropertyParserHelpers
- CSSPropertyAPIAlignOrJustifySelf split to
    - CSSPropertyAPIAlignSelf, CSSPropertyAPIJustifySelf
- CSSPropertyAPIFontDisplay split from
  CSSPropertyAPIDescriptorOnly
- CSSPropertyAPIHyphens and CSSPropertyAPITestJustify split from
  CSSPropertyAPIInherited

New:
- CSSPropertyAPIOverflowAnchor
- CSSPropertyAPIScrollBehavior
- CSSPropertyAPITransformBox
- CSSPropertyAPIScrollBoundaryBehavior
- CSSPropertyAPIScrollSnapStop
- CSSPropertyAPITextDecorationStyle
- CSSPropertyAPIApplyAtRule


I have also added resolveCSSPropertyID(id) to
CSSPropertyAPI::Get(id). I keep bumping into this and it's a
headache to add it to all the callers, however I'm not 100%
confident that it is correct, so PTAL at that.

I've deleted some unneeded method declarations from
CSSPropertyMetadata.h which should have been deleted in 
earlier CLs.

Bug:  751373 

Change-Id: I363e85205789203cc02b5d656de13d1804ccb722
Reviewed-on: https://chromium-review.googlesource.com/649932
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500525}
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/build/scripts/core/css/properties/make_css_property_api_base.py
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.cpp.tmpl
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPI.h.tmpl
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/build/scripts/core/css/properties/templates/CSSPropertyAPISubclass.h.tmpl
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/build/scripts/core/css/templates/CSSPropertyMetadata.cpp.tmpl
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/CSSProperty.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/CSSPropertyMetadata.h
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/StylePropertySet.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.h
[rename] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignSelf.cpp
[add] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIApplyAtRule.h
[add] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBackdropFilter.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFilter.cpp
[copy] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIJustifySelf.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWillChange.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/css/properties/CSSPropertyTransitionPropertyUtils.cpp
[modify] https://crrev.com/dbd1c23fe4d86f2a4788246436b526b65df84775/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a

commit 6d76d1aeb62ce848e5d74fc6a21011e4a04d304a
Author: Renee Wright <rjwright@chromium.org>
Date: Fri Sep 08 08:34:58 2017

[Ribbon] Move FilterEnabledPropertiesIntoVector to CSSProperty

Not sure about this choice of home for this method.

This CL also deletes CSSPropertyMetadata class.

Bug:  751373 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I812df195574ee38f2e798dd7fdb7986b15efad22
Reviewed-on: https://chromium-review.googlesource.com/652207
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500540}
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/build/check_gn_headers_whitelist.txt
[delete] https://crrev.com/27c507212fd72de9f944ff001665c242a7785cce/third_party/WebKit/Source/build/scripts/core/css/make_css_property_metadata.py
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/build/scripts/core/css/templates/CSSOMTypes.cpp.tmpl
[delete] https://crrev.com/27c507212fd72de9f944ff001665c242a7785cce/third_party/WebKit/Source/build/scripts/core/css/templates/CSSPropertyMetadata.cpp.tmpl
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/animation/SVGInterpolationTypesMap.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/css/CSSProperty.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/css/CSSProperty.h
[delete] https://crrev.com/27c507212fd72de9f944ff001665c242a7785cce/third_party/WebKit/Source/core/css/CSSPropertyMetadata.h
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/css/StylePropertySet.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/css/properties/CSSPropertyTransitionPropertyUtils.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/6d76d1aeb62ce848e5d74fc6a21011e4a04d304a/third_party/WebKit/Source/core/testing/Internals.cpp

Comment 19 by rjwright@chromium.org, Sep 8 2017

Status: Fixed (was: Assigned)
CSSPropertyMetadata has been deleted.
►

Sign in to add a comment