Fuzzy icons in Share and Open menus |
|||
Issue descriptionChrome Version: (62.0.3169.0) Canary Platform 9793.0.0 What steps will reproduce the problem? (1) Select file (2) Click Open or Share menu in files (3) Observe look of app icons What is the expected result? App icons look crisp and easy to read What happens instead? App icons look fuzzy and like the resolution is poor ccing sgabriel@ as an FYI
,
Sep 6 2017
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/679f2f65cb0af97023ec4030acafa8e0ffe47af9 commit 679f2f65cb0af97023ec4030acafa8e0ffe47af9 Author: Naoki Fukino <fukino@chromium.org> Date: Wed Sep 27 10:51:11 2017 Files app: Use 32x32 icons for tasks from Chrome extensions and Google Drive apps. To show file task icons, we have used 16x16 icons, but the resolution is not good enough to use it in HiDIP devices. Instead, we use 32x32 icons for tasks from Chrome extensions and Google Drive apps. Note that we need to handle tasks from ARC apps separately, which will be don in a separate CL. Bug: 751362 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I36b47c24ca3296e6016d2e0b51656f8fc84f6f40 Reviewed-on: https://chromium-review.googlesource.com/653017 Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#504622} [modify] https://crrev.com/679f2f65cb0af97023ec4030acafa8e0ffe47af9/chrome/browser/chromeos/file_manager/file_tasks.cc [modify] https://crrev.com/679f2f65cb0af97023ec4030acafa8e0ffe47af9/components/drive/drive_app_registry.h [modify] https://crrev.com/679f2f65cb0af97023ec4030acafa8e0ffe47af9/ui/file_manager/file_manager/foreground/css/menu.css
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e32d1704d7f7401e602283c3c5dc296a44339d07 commit e32d1704d7f7401e602283c3c5dc296a44339d07 Author: Naoki Fukino <fukino@chromium.org> Date: Fri Sep 29 08:36:54 2017 Consider device scale factor to generate PNG data for ARC intent handler's icon. We generate data URL for ARC intent handler's icon in 16x16 pixel PNG format. It is not good enough when the device scale factor is bigger than 1. We should apply the scale factor when generating PNG data. The source bitmap which is passed from Android system is big enough. (48x48 pixels for 1x scale factor, and 96x96 pixels for 2x scale factor.) Bug: 751362 Change-Id: I370bf32b2c0f4e9e19dc267b03965663546a03bf Reviewed-on: https://chromium-review.googlesource.com/688524 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#505332} [modify] https://crrev.com/e32d1704d7f7401e602283c3c5dc296a44339d07/components/arc/intent_helper/activity_icon_loader.cc
,
Sep 29 2017
The Kevin screenshot looks great! Agree there is no regression on the 1x device screenshot. Is there anything we can do to make that better?
,
Oct 2 2017
For 1x devices, we can't make it better than 1x_before screenshot. But I think it won't look so fuzzy on 1x devices :)
,
Oct 2 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by fukino@chromium.org
, Aug 2 2017