Share menu labels show redundant prefix sometimes |
||||||||||
Issue descriptionChrome Version: (62.0.3169.0) Canary Platform 9793.0.0 What steps will reproduce the problem? Hard to reproduce, see screenshots. Sometimes when I open the share menu it shows without the redundant prefixes, sometimes it still has them. What is the expected result? Share menu does not show "Share with" prefix.
,
Aug 2 2017
,
Aug 2 2017
,
Aug 2 2017
It seems we can reproduce this issue by selecting multiple files and open the share menu.
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2577a8a080fad1547b85ec68b495d29261ec7ae1 commit 2577a8a080fad1547b85ec68b495d29261ec7ae1 Author: Naoki Fukino <fukino@chromium.org> Date: Wed Aug 09 06:31:41 2017 Files app: Remove redundant prefixes from labels of SEND_MULTIPLE intent handlers. The "Share with " prefixes were removed from labels of SEND intent handlers ( Issue 746270 ). We should remove them from labels of SEND_MULTIPLE intent handlers as well. Bug: 751361 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ice45bda8bce409046038246fd85ae24d1ae9f09d Reviewed-on: https://chromium-review.googlesource.com/597578 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#492857} [modify] https://crrev.com/2577a8a080fad1547b85ec68b495d29261ec7ae1/ui/file_manager/file_manager/foreground/js/file_tasks.js
,
Aug 9 2017
,
Aug 9 2017
Pls apply appropriate OSs. Thank you.
,
Aug 9 2017
,
Aug 9 2017
Approving merge to M61 Chrome OS.
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4be2a60fab15b5078c45e12b505d09af0012cae commit c4be2a60fab15b5078c45e12b505d09af0012cae Author: Naoki Fukino <fukino@chromium.org> Date: Thu Aug 10 03:39:04 2017 Files app: Remove redundant prefixes from labels of SEND_MULTIPLE intent handlers. The "Share with " prefixes were removed from labels of SEND intent handlers ( Issue 746270 ). We should remove them from labels of SEND_MULTIPLE intent handlers as well. TBR=fukino@chromium.org (cherry picked from commit 2577a8a080fad1547b85ec68b495d29261ec7ae1) Bug: 751361 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ice45bda8bce409046038246fd85ae24d1ae9f09d Reviewed-on: https://chromium-review.googlesource.com/597578 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#492857} Reviewed-on: https://chromium-review.googlesource.com/609398 Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#428} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/c4be2a60fab15b5078c45e12b505d09af0012cae/ui/file_manager/file_manager/foreground/js/file_tasks.js
,
Aug 10 2017
,
Aug 14 2017
,
Jan 22 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by mcirimele@chromium.org
, Aug 2 2017