New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751355 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ARC Notification shows blank in message center after popup opens

Project Member Reported by yoshiki@chromium.org, Aug 2 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) See a popup of ARC notification
(2) While the popup is visible, open the message center

What is the expected result?
See the content in the notification in the message center

What happens instead?
See the blank in the notification in the message center

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Components: -UI>Notifications UI>Shell>Notifications
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0d6b809e63bdc2ff0e06a679cd2b37b02ab1d19

commit e0d6b809e63bdc2ff0e06a679cd2b37b02ab1d19
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Aug 03 02:12:38 2017

Detach surface only when the surface is attaching to the current view

Previously, a notification content view wrongly detached the surface which is attaching to another view. That caused  crbug.com/751355 . This CL prevents that.

Bug:  751355 
Change-Id: Ibaec4d7fd88f96e864634258d16e45fac9d2a945
Reviewed-on: https://chromium-review.googlesource.com/595312
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491613}
[modify] https://crrev.com/e0d6b809e63bdc2ff0e06a679cd2b37b02ab1d19/ui/arc/notification/arc_notification_content_view.cc
[modify] https://crrev.com/e0d6b809e63bdc2ff0e06a679cd2b37b02ab1d19/ui/arc/notification/arc_notification_content_view_unittest.cc

Status: Fixed (was: Started)
Labels: Merge-Request-61
Status: Started (was: Fixed)
I forgot merging.

I confirmed it's working on 62.0.3174.0 canary
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 10 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by ketakid@google.com, Aug 10 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 10 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1765a2a95967802c4ad45f3129deeaaec957f66d

commit 1765a2a95967802c4ad45f3129deeaaec957f66d
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Thu Aug 10 17:23:27 2017

Detach surface only when the surface is attaching to the current view

Previously, a notification content view wrongly detached the surface which is attaching to another view. That caused  crbug.com/751355 . This CL prevents that.

TBR=yoshiki@chromium.org

(cherry picked from commit e0d6b809e63bdc2ff0e06a679cd2b37b02ab1d19)

Bug:  751355 
Change-Id: Ibaec4d7fd88f96e864634258d16e45fac9d2a945
Reviewed-on: https://chromium-review.googlesource.com/595312
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491613}
Reviewed-on: https://chromium-review.googlesource.com/610641
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#435}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/1765a2a95967802c4ad45f3129deeaaec957f66d/ui/arc/notification/arc_notification_content_view.cc
[modify] https://crrev.com/1765a2a95967802c4ad45f3129deeaaec957f66d/ui/arc/notification/arc_notification_content_view_unittest.cc

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment