New issue
Advanced search Search tips

Issue 751343 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Avatar of small pods disappear when focused at login screen

Project Member Reported by wzang@chromium.org, Aug 2 2017

Issue description

Whenever small pods are focused, the avatar disappears, and it shows again when if's unfocused. This happens after animated avatars are available.

 

Comment 1 by wzang@chromium.org, Aug 2 2017

Sorry for the image quality. The avatar at the right top corner disappears.
IMG_20170801_175603.jpg
4.5 MB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce899142efad247aa2d7e38f9251220bb031797e

commit ce899142efad247aa2d7e38f9251220bb031797e
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Aug 02 17:24:19 2017

Add animated avatar container for small pods

The current implementation of animated avatar didn't consider small
pods, resulting in the listed bug.

Also sets a timeout for switch animation.

Bug:  751343 , 721647
Change-Id: I5b9cafc737c082865d33520cfafca2963554be4f
Reviewed-on: https://chromium-review.googlesource.com/597051
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491419}
[modify] https://crrev.com/ce899142efad247aa2d7e38f9251220bb031797e/ui/login/account_picker/md_user_pod_row.js
[modify] https://crrev.com/ce899142efad247aa2d7e38f9251220bb031797e/ui/login/account_picker/md_user_pod_template.html

Comment 3 by wzang@chromium.org, Aug 2 2017

Status: Fixed (was: Assigned)

Comment 4 by wzang@chromium.org, Aug 2 2017

Issue 751826 has been merged into this issue.

Comment 5 by wzang@chromium.org, Aug 8 2017

Labels: Merge-Request-61
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 8 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls apply appropriate OSs. Thank you.

Comment 8 by wzang@chromium.org, Aug 9 2017

Labels: OS-Chrome
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 12 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7859c0eec0258ae6ceaebf1bb71ce2768234d99

commit b7859c0eec0258ae6ceaebf1bb71ce2768234d99
Author: David Reveman <reveman@chromium.org>
Date: Sat Aug 12 13:42:27 2017

Add animated avatar container for small pods

The current implementation of animated avatar didn't consider small
pods, resulting in the listed bug.

Also sets a timeout for switch animation.

TBR=wzang@chromium.org

(cherry picked from commit ce899142efad247aa2d7e38f9251220bb031797e)

Bug:  751343 , 721647
Change-Id: I5b9cafc737c082865d33520cfafca2963554be4f
Reviewed-on: https://chromium-review.googlesource.com/597051
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491419}
Reviewed-on: https://chromium-review.googlesource.com/612197
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#516}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/b7859c0eec0258ae6ceaebf1bb71ce2768234d99/ui/login/account_picker/md_user_pod_row.js
[modify] https://crrev.com/b7859c0eec0258ae6ceaebf1bb71ce2768234d99/ui/login/account_picker/md_user_pod_template.html

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment