Crash in UserImageManagerImpl ( Check failed: !base::SysInfo::IsRunningOnChromeOS() ) |
||||||
Issue description[12146:12146:0801/171733.000742:FATAL:default_user_images.cc(241)] Check failed: !base::SysInfo::IsRunningOnChromeOS(). #0 0x5873b001b59d base::debug::StackTrace::StackTrace() #1 0x5873b001a00c base::debug::StackTrace::StackTrace() #2 0x5873b0068d43 logging::LogMessage::~LogMessage() #3 0x5873ad6a3d01 chromeos::default_user_image::(anonymous namespace)::GetDefaultImageString() #4 0x5873ad6a3bdb chromeos::default_user_image::GetDefaultImageUrl() #5 0x5873ad5e6cd6 chromeos::UserImageScreen::OnUserImageChanged() #6 0x5873b208b8d3 user_manager::UserManagerBase::NotifyUserImageChanged() #7 0x5873ad680f76 chromeos::UserImageManagerImpl::OnJobChangedUserImage() #8 0x5873ad67fd89 chromeos::UserImageManagerImpl::Job::UpdateUser() #9 0x5873ad680926 chromeos::UserImageManagerImpl::Job::UpdateUserAndSaveImage() #10 0x5873ad68083d chromeos::UserImageManagerImpl::Job::SetToImage() #11 0x5873ad683267 chromeos::UserImageManagerImpl::SaveUserImageFromProfileImage() #12 0x5873ad688e53 chromeos::UserImageSyncObserver::UpdateLocalImageFromSynced() #13 0x5873ad688871 chromeos::UserImageSyncObserver::OnInitialSync() #14 0x5873ad68874f chromeos::UserImageSyncObserver::OnPreferenceChanged() #15 0x5873a9c0a9d5 _ZN4base8internal13FunctorTraitsIMN2ui9DrmThreadEFvRKNS_8FilePathEEvE6InvokeIPS3_JS6_EEEvS8_OT_DpOT0_ #16 0x5873a9c0a8f6 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN2ui9DrmThreadEFvRKNS_8FilePathEEJPS5_S8_EEEvOT_DpOT0_ #17 0x5873ad68e0d4 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos21UserImageSyncObserverEFvRKSsEJNS0_17UnretainedWrapperIS4_EEEEEFvS6_EE7RunImplIRKS8_RKSt5tupleIJSA_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEES6_ #18 0x5873ad68dffc _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos21UserImageSyncObserverEFvRKSsEJNS0_17UnretainedWrapperIS4_EEEEEFvS6_EE3RunEPNS0_13BindStateBaseES6_ #19 0x5873a9a72b92 _ZNKR4base8CallbackIFvRKNS0_IFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EEEELS3_1ELS4_1EE3RunES7_ #20 0x5873b1faf605 PrefChangeRegistrar::OnPreferenceChanged() #21 0x5873b1fb4c11 PrefNotifierImpl::FireObservers() #22 0x5873b1fb47bf PrefNotifierImpl::OnPreferenceChanged() #23 0x5873b1fcdbbe PrefValueStore::NotifyPrefChanged() #24 0x5873b1fccf43 PrefValueStore::OnPrefValueChanged() #25 0x5873b1fccf14 PrefValueStore::PrefStoreKeeper::OnPrefValueChanged() #26 0x5873b1fa7257 JsonPrefStore::ReportValueChanged() #27 0x5873b1fa5b01 JsonPrefStore::SetValue() #28 0x5873b1fc4f10 PrefService::SetUserPrefValue() #29 0x5873b1fc4b99 PrefService::Set() #30 0x5873b5778796 sync_preferences::PrefModelAssociator::InitPrefAndAssociate() #31 0x5873b5779781 sync_preferences::PrefModelAssociator::MergeDataAndStartSyncing() #32 0x5873b37b0502 syncer::SharedChangeProcessor::StartAssociation() #33 0x5873b37ac980 _ZN4base8internal13FunctorTraitsIMN6syncer21SharedChangeProcessorEFvNS_8CallbackIFvNS2_18DataTypeController15ConfigureResultERKNS2_15SyncMergeResultES9_ELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEPNS2_10SyncClientEPNS2_29GenericChangeProcessorFactoryEPNS2_9UserShareESt10unique_ptrINS2_20DataTypeErrorHandlerESt14default_deleteISL_EEEvE6InvokeIRK13scoped_refptrIS3_EJRKSD_RKSF_RKSH_RKSJ_SO_EEEvSQ_OT_DpOT0_ #34 0x5873b37ac727 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN6syncer21SharedChangeProcessorEFvNS_8CallbackIFvNS4_18DataTypeController15ConfigureResultERKNS4_15SyncMergeResultESB_ELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEPNS4_10SyncClientEPNS4_29GenericChangeProcessorFactoryEPNS4_9UserShareESt10unique_ptrINS4_20DataTypeErrorHandlerESt14default_deleteISN_EEEJRK13scoped_refptrIS5_ERKSF_RKSH_RKSJ_RKSL_SQ_EEEvOT_DpOT0_ #35 0x5873b37ac636 _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer21SharedChangeProcessorEFvNS_8CallbackIFvNS3_18DataTypeController15ConfigureResultERKNS3_15SyncMergeResultESA_ELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEPNS3_10SyncClientEPNS3_29GenericChangeProcessorFactoryEPNS3_9UserShareESt10unique_ptrINS3_20DataTypeErrorHandlerESt14default_deleteISM_EEEJ13scoped_refptrIS4_ESE_SG_SI_SK_NS0_13PassedWrapperISP_EEEEEFvvEE7RunImplIRKSR_RKSt5tupleIJST_SE_SG_SI_SK_SV_EEJLm0ELm1ELm2ELm3ELm4ELm5EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #36 0x5873b37ac42c _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer21SharedChangeProcessorEFvNS_8CallbackIFvNS3_18DataTypeController15ConfigureResultERKNS3_15SyncMergeResultESA_ELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEPNS3_10SyncClientEPNS3_29GenericChangeProcessorFactoryEPNS3_9UserShareESt10unique_ptrINS3_20DataTypeErrorHandlerESt14default_deleteISM_EEEJ13scoped_refptrIS4_ESE_SG_SI_SK_NS0_13PassedWrapperISP_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #37 0x5873a9b246c9 _ZNO4base8CallbackIFvvELNS_8internal8CopyModeE0ELNS2_10RepeatModeE0EE3RunEv #38 0x5873b001edb2 base::debug::TaskAnnotator::RunTask() #39 0x5873b008c74d base::MessageLoop::RunTask() #40 0x5873b008c9e7 base::MessageLoop::DeferOrRunPendingTask() #41 0x5873b008cd1b base::MessageLoop::DoWork() #42 0x5873b009d04e base::MessagePumpLibevent::Run() #43 0x5873b008c0b8 base::MessageLoop::Run() #44 0x5873b0124d4d base::RunLoop::Run() #45 0x5873af32701b ChromeBrowserMainParts::MainMessageLoopRun() #46 0x5873ab366c18 content::BrowserMainLoop::RunMainMessageLoopParts() #47 0x5873ab3737f6 content::BrowserMainRunnerImpl::Run() #48 0x5873ab3601f2 content::BrowserMain() #49 0x5873af265df6 content::RunNamedProcessTypeMain() #50 0x5873af2682ec content::ContentMainRunnerImpl::Run() #51 0x5873af264bca content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #52 0x5873af31141c service_manager::Main() #53 0x5873af26582f content::ContentMain() #54 0x5873a9816cdc ChromeMain #55 0x5873a9816bc2 main #56 0x79ee6ea04736 __libc_start_main #57 0x5873a9816a69 _start
,
Aug 2 2017
Probably related to either my change or David's. Can you reproduce this? If so, can you log what |index| is? I think some re-factoring I did may be causing this to sometimes get called with -1 and we just want to remove the DCHECK.
,
Aug 2 2017
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f12bcecf7c7dd2d24025b453b15feef5a21415d commit 2f12bcecf7c7dd2d24025b453b15feef5a21415d Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Aug 02 20:00:36 2017 default_user_iamge: Elim invalid DCHECK In https://chromium-review.googlesource.com/576567 we unifed some of the default_user_image logic. In doing so it is now possible to call GetDefaultImageUrl with a negative index. Rather than require all callers to test their parameters or handle an empty image, this CL returns the default avatar image for invalid input parameters which should be handled correctly in the UI. Bug: 751335 , 750577 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3f52af21748d37b55fbed95f24ba2ec07e91e311 Reviewed-on: https://chromium-review.googlesource.com/598451 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491477} [modify] https://crrev.com/2f12bcecf7c7dd2d24025b453b15feef5a21415d/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc [modify] https://crrev.com/2f12bcecf7c7dd2d24025b453b15feef5a21415d/chrome/browser/chromeos/login/users/default_user_image/default_user_images.h [modify] https://crrev.com/2f12bcecf7c7dd2d24025b453b15feef5a21415d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js [modify] https://crrev.com/2f12bcecf7c7dd2d24025b453b15feef5a21415d/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_types.js
,
Aug 2 2017
,
Aug 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d6ff31f0142d7701631957aacdb62fb9f363f80 commit 9d6ff31f0142d7701631957aacdb62fb9f363f80 Author: David Reveman <reveman@chromium.org> Date: Sat Aug 12 13:38:53 2017 default_user_iamge: Elim invalid DCHECK In https://chromium-review.googlesource.com/576567 we unifed some of the default_user_image logic. In doing so it is now possible to call GetDefaultImageUrl with a negative index. Rather than require all callers to test their parameters or handle an empty image, this CL returns the default avatar image for invalid input parameters which should be handled correctly in the UI. TBR=stevenjb@chromium.org (cherry picked from commit 2f12bcecf7c7dd2d24025b453b15feef5a21415d) Bug: 751335 , 750577 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3f52af21748d37b55fbed95f24ba2ec07e91e311 Reviewed-on: https://chromium-review.googlesource.com/598451 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491477} Reviewed-on: https://chromium-review.googlesource.com/612053 Cr-Commit-Position: refs/branch-heads/3163@{#515} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/9d6ff31f0142d7701631957aacdb62fb9f363f80/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc [modify] https://crrev.com/9d6ff31f0142d7701631957aacdb62fb9f363f80/chrome/browser/chromeos/login/users/default_user_image/default_user_images.h [modify] https://crrev.com/9d6ff31f0142d7701631957aacdb62fb9f363f80/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.js [modify] https://crrev.com/9d6ff31f0142d7701631957aacdb62fb9f363f80/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_types.js
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by alemate@chromium.org
, Aug 2 2017