New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751326 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 751321
issue 751759



Sign in to add a comment

memlog: Use browser to broker/restrict access to Profiling Service

Project Member Reported by ajwong@chromium.org, Aug 2 2017

Issue description

Currently, any child process can request a Memlog interface and have the ServiceManager spin up the profiling process.

Either add a MemlogProvider interface that the Browser exposes which passes the ConnectRequest to the actual service. This would let the browser examine internal state to determine whether or not it should spin up the profiling process.

Alternately, expose a MemlogTarget interface in from each child process that the browser can call to insert a logging command after startup.

Goals:
  (a) Allow the start/stop button to start/stop the profiling process
  (b) Allow profiling of children very early on in their startup.
 
Blocking: 751759
Owner: erikc...@chromium.org
Status: Assigned (was: Unconfirmed)
Switching the API to use a broker was done here: https://chromium-review.googlesource.com/c/602526

The CL in question supports "starting" for (a), but the UI isn't actually hooked up.

This is unrelated to (b).

(a) and (b) seem like they're not part of the MVP.

Comment 4 by ajwong@chromium.org, Aug 14 2017

Status: Fixed (was: Assigned)
Okay. Closing this out and creating 2 separate bugs.

  755241 - start/stop
  755243 - early tracing of processes.

Sign in to add a comment