New issue
Advanced search Search tips

Issue 751312 link

Starred by 0 users
Status: Verified
Owner:
sammiequon@chromium.org
Closed: Aug 2017
Cc:
mkarkada@chromium.org
tbuck...@chromium.org
dhadd...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Issues with confirming PIN on lock screen.

Project Member Reported by sammiequon@chromium.org, Aug 2 2017 
(1) Go to lock screen, click SET UP PIN.
(2) Choose a PIN and go to confirm step.
(3) Enter a wrong PIN.

Actual result:
Button grabs focuses and users cannot quickly try again.
On changing the PIN the CONFIRM button is still disabled.

Expected result:
The wrong PIN should be highlighted (focused).
On changing the PIN the CONFIRM button should be enabled.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df86ed712d7bb57c25082313e368bb99f23fdf0f

commit df86ed712d7bb57c25082313e368bb99f23fdf0f
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Aug 02 21:40:12 2017

settings: Issues with confirming PIN on lock screen.

This CL does:
1) Keeps the confirm button disabled until something has been entered.
2) Enables the confirm button after a new digit has been pressed after a wrong PIN has been entered.
3) Focuses and highlights the wrong PIN after one has been entered.

Test: browser_tests "CrSettingsPeoplePageSetupPinDialogTest.*"
Bug:  751079 , 751312 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ife71bc02f6955a819cbb65f9d937eb6dd4a78863
Reviewed-on: https://chromium-review.googlesource.com/596922
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491512}
[modify] https://crrev.com/df86ed712d7bb57c25082313e368bb99f23fdf0f/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/df86ed712d7bb57c25082313e368bb99f23fdf0f/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Comment 2 by sammiequon@chromium.org, Aug 2 2017

Status: Fixed (was: Assigned)

Comment 3 by mkarkada@chromium.org, Aug 8 2017

Cc: mkarkada@chromium.org dhadd...@chromium.org
Verified on M62 (Chrome OS 9817.0.0, 62.0.3176.0 dev build).

Comment 4 by mkarkada@chromium.org, Aug 14 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment