New issue
Advanced search Search tips

Issue 751309 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Feature



Sign in to add a comment

Use PAM for all CRD sessions on Linux

Project Member Reported by rkjnsn@chromium.org, Aug 1 2017

Issue description

Currently PAM is used for sessions started at boot, but not otherwise. For consistency, PAM should be used for all sessions.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0bae7e53ba808999edffb7402558a5b7be721f9

commit f0bae7e53ba808999edffb7402558a5b7be721f9
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Wed Aug 02 01:41:11 2017

Reland "Implement wait-for-logs functionality in user_session binary"

This is a reland of 26c8b12c67ba06eae3ea48114f964fd5548738ff

BUG= 751309 

Original change's description:
> Implement wait-for-logs functionality in user_session binary
> 
> This ports the wait_for_logs method from the Python script, and forwards
> the pipe write fd to the Python script.
> 
> Change-Id: Ief54da136894cd13e0761b9755aa3c7d51fe17f8
> Reviewed-on: https://chromium-review.googlesource.com/594807
> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#491058}

Change-Id: I9daf4957636a99b5179975cf1db33ba101bc179d
Reviewed-on: https://chromium-review.googlesource.com/597087
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491179}
[modify] https://crrev.com/f0bae7e53ba808999edffb7402558a5b7be721f9/remoting/host/linux/linux_me2me_host.py
[modify] https://crrev.com/f0bae7e53ba808999edffb7402558a5b7be721f9/remoting/host/linux/remoting_user_session.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad7f5e41616ff6c51add9d1d00dd8c5af545d2a4

commit ad7f5e41616ff6c51add9d1d00dd8c5af545d2a4
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Fri Aug 04 22:52:47 2017

When relaunching CRD me2me script, restart PAM user-session, too

This uses a special return code to signal that the user-session binary
should restart instead of exiting.

Bug:  751309 
Change-Id: Ibd875b61244c69c93490c018995f7f110bd7d401
Reviewed-on: https://chromium-review.googlesource.com/598656
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492161}
[modify] https://crrev.com/ad7f5e41616ff6c51add9d1d00dd8c5af545d2a4/remoting/host/linux/linux_me2me_host.py
[modify] https://crrev.com/ad7f5e41616ff6c51add9d1d00dd8c5af545d2a4/remoting/host/linux/remoting_user_session.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da77b128009f989d4f07c0080f6b145a835af74a

commit da77b128009f989d4f07c0080f6b145a835af74a
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Tue Aug 08 19:41:35 2017

Install CRD user-session binary setuid

This allows the init script to use the binary even when invoked as a
normal user.

Bug:  751309 
Change-Id: I9565a59c38549722bb762da8159a27ca300fe426
Reviewed-on: https://chromium-review.googlesource.com/603009
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492730}
[modify] https://crrev.com/da77b128009f989d4f07c0080f6b145a835af74a/remoting/host/installer/linux/debian/chrome-remote-desktop.init
[modify] https://crrev.com/da77b128009f989d4f07c0080f6b145a835af74a/remoting/host/installer/linux/debian/control
[modify] https://crrev.com/da77b128009f989d4f07c0080f6b145a835af74a/remoting/host/installer/linux/debian/postinst

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf3e8db262e7d2c6673d74aa877206a23a96a620

commit bf3e8db262e7d2c6673d74aa877206a23a96a620
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Mon Aug 14 22:12:22 2017

Have user-session forward host-related environment variables

Bug:  751309 
Change-Id: I3d00a66204f41c8f48893e9c6719fa30f32fad93
Reviewed-on: https://chromium-review.googlesource.com/611864
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494205}
[modify] https://crrev.com/bf3e8db262e7d2c6673d74aa877206a23a96a620/remoting/host/linux/remoting_user_session.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3eb242ed13b19b2cd4090e6648d26476e224764b

commit 3eb242ed13b19b2cd4090e6648d26476e224764b
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Thu Aug 17 22:54:38 2017

Allow user-session to forward arbitrary me2me script args

Bug:  751309 
Change-Id: I28ef8737e1bdeb92ff1cebd1845bea9829458965
Reviewed-on: https://chromium-review.googlesource.com/611854
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495363}
[modify] https://crrev.com/3eb242ed13b19b2cd4090e6648d26476e224764b/remoting/host/installer/linux/debian/chrome-remote-desktop.init
[modify] https://crrev.com/3eb242ed13b19b2cd4090e6648d26476e224764b/remoting/host/linux/remoting_user_session.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d26c7919996c99f9d00c70c8779717be383d068

commit 9d26c7919996c99f9d00c70c8779717be383d068
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Thu Aug 17 23:07:05 2017

Exit user-session with error if not root

Bug:  751309 
Change-Id: I1852d59c0cd027f6b7f84f7ac76782df3b68d59d
Reviewed-on: https://chromium-review.googlesource.com/611867
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495370}
[modify] https://crrev.com/9d26c7919996c99f9d00c70c8779717be383d068/remoting/host/linux/remoting_user_session.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/464c416a559af5790b08addbec52f756f4523c27

commit 464c416a559af5790b08addbec52f756f4523c27
Author: Erik Jensen <rkjnsn@chromium.org>
Date: Sat Sep 02 02:08:58 2017

Make sessions always start using user-session

This updates linux_me2me_host.py to relaunch itself via user-session
when invoked directly instead of trying to simulate enviroment setup.

Bug:  751309 
Change-Id: Ifead7fcd96e4b1ee4727fcd23df52dc44794eeeb
Reviewed-on: https://chromium-review.googlesource.com/608723
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499374}
[modify] https://crrev.com/464c416a559af5790b08addbec52f756f4523c27/remoting/host/linux/BUILD.gn
[modify] https://crrev.com/464c416a559af5790b08addbec52f756f4523c27/remoting/host/linux/linux_me2me_host.py
[modify] https://crrev.com/464c416a559af5790b08addbec52f756f4523c27/remoting/host/linux/remoting_user_session.cc
[add] https://crrev.com/464c416a559af5790b08addbec52f756f4523c27/remoting/host/linux/remoting_user_session_wrapper.sh

Status: Fixed (was: Assigned)

Sign in to add a comment