New issue
Advanced search Search tips

Issue 751308 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 20
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

hexSsid empty from GetNetworks call in arc_net_host_impl.cc

Project Member Reported by abhishekbh@google.com, Aug 1 2017

Issue description

By manual logging / debugging it was found out that kWifiHexSSID property is empty in the ARC++ GetNetworks handler.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a0277cc3a616ba5a6adf661ea632031c61e7ad2

commit 2a0277cc3a616ba5a6adf661ea632031c61e7ad2
Author: Abhishek Bhardwaj <abhishekbh@google.com>
Date: Wed Aug 16 04:20:10 2017

Add HexSsid property to ONC dictionary returned from GetStateProperties

The NetworkState::GetStateProperties function omitted the HexSsid value
for a WiFi network while adding its shill properties to the resulting
ONC dictionary. This change adds the HexSsid property to the resulting
dictionary. This is needed by the GetNetworks mojo handler for ARC++.

BUG= 751308 
TEST=Tested with WifiScanner Android app on ARC++

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id66c29b5ffcf75507550476ba7546d2f7a7ff5bb
Reviewed-on: https://chromium-review.googlesource.com/596850
Commit-Queue: Abhishek Bhardwaj <abhishekbh@google.com>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494693}
[modify] https://crrev.com/2a0277cc3a616ba5a6adf661ea632031c61e7ad2/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
[modify] https://crrev.com/2a0277cc3a616ba5a6adf661ea632031c61e7ad2/chromeos/network/network_state.cc
[modify] https://crrev.com/2a0277cc3a616ba5a6adf661ea632031c61e7ad2/chromeos/network/network_state_unittest.cc
[modify] https://crrev.com/2a0277cc3a616ba5a6adf661ea632031c61e7ad2/extensions/common/api/networking_onc.idl
[modify] https://crrev.com/2a0277cc3a616ba5a6adf661ea632031c61e7ad2/extensions/common/api/networking_private.idl
[modify] https://crrev.com/2a0277cc3a616ba5a6adf661ea632031c61e7ad2/third_party/closure_compiler/externs/networking_private.js

Owner: abhishekbh@chromium.org
Status: Verified (was: Assigned)

Sign in to add a comment