X509Certificate::GetIntermediateCertificates() documentation refers to nonexistent AddIntermediateCertificate() function |
|||
Issue descriptionAt [1]: "Returns intermediate certificates added via AddIntermediateCertificate()" AddIntermediateCertificate() doesn't exist. It *appears* that the intermediates have to be passed into the constructor? [1] https://cs.chromium.org/chromium/src/net/cert/x509_certificate.h?type=cs&q=%22AddIntermediateCertificate%22&sq=package:chromium&l=226
,
Aug 1 2017
Yep, that's some quite outdated documentation. (Though the constructor is private, so from the user's perspective the intermediates would be passed to one of the Create functions.)
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35ddac448dac4eb643dbfc05d2a7c25c3c7e5848 commit 35ddac448dac4eb643dbfc05d2a7c25c3c7e5848 Author: Matt Mueller <mattm@chromium.org> Date: Wed Aug 02 03:45:57 2017 Some x509_certificate.h documentation fixes. Remove reference to non-existant AddIntermediateCertificate method. Clarify Equals documentation regarding intermediates. Fix typo. Bug: 751298 Change-Id: I630fd51176cc9de7e14a5917ab77f9a60a81f1e5 Reviewed-on: https://chromium-review.googlesource.com/596724 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#491255} [modify] https://crrev.com/35ddac448dac4eb643dbfc05d2a7c25c3c7e5848/net/cert/x509_certificate.h
,
Aug 2 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by lgar...@chromium.org
, Aug 1 2017