New issue
Advanced search Search tips

Issue 751295 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix Mesa ebuild

Project Member Reported by gurcheta...@chromium.org, Aug 1 2017

Issue description

Sometimes we build certain drivers we shouldn't build.  We'll need to tweak the use flags and ebuild to help in those cases.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cffe65524cd7d8b54b4c251e70c9a361cc6cb37d

commit cffe65524cd7d8b54b4c251e70c9a361cc6cb37d
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Wed Aug 02 05:59:48 2017

media-libs/mesa: don't build drivers that can't run ChromeOS

These classic drivers don't have the capability of running ChromeOS,
so disable them in the ebuild.

BUG= chromium:751295 
TEST=emerge-cave mesa doesn't build i915.so

Change-Id: Ib10b06ae5cc6b930200fcc0ce2447a8fb5566563
Reviewed-on: https://chromium-review.googlesource.com/596711
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/cffe65524cd7d8b54b4c251e70c9a361cc6cb37d/media-libs/mesa/mesa-9999.ebuild
[rename] https://crrev.com/cffe65524cd7d8b54b4c251e70c9a361cc6cb37d/media-libs/mesa/mesa-17.1.1-r3.ebuild
[modify] https://crrev.com/cffe65524cd7d8b54b4c251e70c9a361cc6cb37d/media-libs/mesa/mesa-17.1.1.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7055919e78fb5a4411c17979e8ba1ad6199d4329

commit 7055919e78fb5a4411c17979e8ba1ad6199d4329
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Wed Aug 02 22:02:36 2017

media-libs/mesa: Get rid of the classic DRI swrast driver

Since we've been unconditionally enabling gallium in this ebuild,
we've actually never used this.

BUG= chromium:751295 
TEST=Pre-CQ tests

Change-Id: Ifcbd6e54fc39b4d34af183858b6934f66bac63fe
Reviewed-on: https://chromium-review.googlesource.com/596713
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Dominik Behr <dbehr@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[rename] https://crrev.com/7055919e78fb5a4411c17979e8ba1ad6199d4329/media-libs/mesa/mesa-17.1.1-r4.ebuild
[modify] https://crrev.com/7055919e78fb5a4411c17979e8ba1ad6199d4329/media-libs/mesa/mesa-9999.ebuild
[modify] https://crrev.com/7055919e78fb5a4411c17979e8ba1ad6199d4329/media-libs/mesa/mesa-17.1.1.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/f7951ab40ff983d696d27aee45d22f0b99cd25e5

commit f7951ab40ff983d696d27aee45d22f0b99cd25e5
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Fri Aug 04 19:29:19 2017

overlays: enable llvmpipe driver on certain boards

Let's enable the llvmpipe driver on boards that are known to be
used in VMs (amd64-generic) and boards that are named after the
llvmpipe driver (arm64-generic-llvmpipe).

BUG= chromium:751295 
TEST=none

Change-Id: I919788dad7f10b101c5e0400ae65aca778b2b356
Reviewed-on: https://chromium-review.googlesource.com/600898
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Dominik Behr <dbehr@chromium.org>

[modify] https://crrev.com/f7951ab40ff983d696d27aee45d22f0b99cd25e5/overlay-arm64-llvmpipe/profiles/base/make.defaults
[modify] https://crrev.com/f7951ab40ff983d696d27aee45d22f0b99cd25e5/overlay-amd64-generic/profiles/base/make.defaults

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/17a30ec27b8e5d2c3d2c6d0ec9b62848a1a8ca35

commit 17a30ec27b8e5d2c3d2c6d0ec9b62848a1a8ca35
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Fri Aug 04 19:29:19 2017

media-libs/mesa: make 9999 ebuild match stable version

LLVM should be built if the llvm use flag is set.

BUG= chromium:751295 
TEST=none

Change-Id: I13875813c53692d2a74467d0ebea8feff49540b4
Reviewed-on: https://chromium-review.googlesource.com/601544
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/17a30ec27b8e5d2c3d2c6d0ec9b62848a1a8ca35/media-libs/mesa/mesa-9999.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/330ade1156bb458ea3f2b96677aa0659940823ac

commit 330ade1156bb458ea3f2b96677aa0659940823ac
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Thu Sep 14 04:47:07 2017

media-libs/mesa: enable swrast drivers when USE flag is set

Since we have the new video_cards_llvmpipe USE flag, we should only
build the gallium swrast drivers when that is set.

BUG= chromium:751295 
TEST=emerge-cave doesn't build swrast_dri.so or kms_swrast_dri.so
     emerge-betty doesn't build i965.so
CQ-DEPEND=CL:600898
CQ-DEPEND=CL:*424568

Change-Id: Iefadfb0fa8455a70601f0cac04c96cd28751a93d
Reviewed-on: https://chromium-review.googlesource.com/599119
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>

[modify] https://crrev.com/330ade1156bb458ea3f2b96677aa0659940823ac/media-libs/mesa/mesa-9999.ebuild
[rename] https://crrev.com/330ade1156bb458ea3f2b96677aa0659940823ac/media-libs/mesa/mesa-17.1.1-r6.ebuild
[modify] https://crrev.com/330ade1156bb458ea3f2b96677aa0659940823ac/media-libs/mesa/mesa-17.1.1.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ad5169af20a4447f93ee4fdb7fa1a67a2ba5a733

commit ad5169af20a4447f93ee4fdb7fa1a67a2ba5a733
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Thu Sep 14 23:15:15 2017

media-libs/mesa: Switch --enable-llvm from llvmpipe to llvm

As of crrev.com/330ade1156bb458ea3f2b96677aa0659940823ac,
--enable-gallium-llvm is controlled by the presence of llvmpipe in
VIDEO_CARDS instead of the llvm USE flag, but --enable-gallium-llvm is
also needed by the radeon drivers.

Leave swrast controlled by llvmpipe, but change --enable-llvm back to
the llvm USE flag.

BUG= chromium:751295 
TEST=emerge-kahlee mesa

Change-Id: I43a2881d3f80ca3197aae5289c7445a37f39642b
Reviewed-on: https://chromium-review.googlesource.com/667918
Commit-Queue: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Trybot-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>

[rename] https://crrev.com/ad5169af20a4447f93ee4fdb7fa1a67a2ba5a733/media-libs/mesa/mesa-17.1.1-r7.ebuild
[modify] https://crrev.com/ad5169af20a4447f93ee4fdb7fa1a67a2ba5a733/media-libs/mesa/mesa-9999.ebuild
[modify] https://crrev.com/ad5169af20a4447f93ee4fdb7fa1a67a2ba5a733/media-libs/mesa/mesa-17.1.1.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/d2452479b2ef0f784cf401011d1b7895515bc159

commit d2452479b2ef0f784cf401011d1b7895515bc159
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Tue Oct 03 06:28:26 2017

overlays: set llvm use flag

Building LLVM takes a long time, and we only use it for a limited
number of Mesa drivers. We can avoid building LLVM for Intel if
we set this use flag and make Mesa only pull in the llvm ebuild
based on it.

BUG= chromium:751295 
TEST=emerge-betty llvm mesa

Change-Id: Ibf13d93341efbe62e2375a40c0d44be2f787231e
Reviewed-on: https://chromium-review.googlesource.com/693422
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d2452479b2ef0f784cf401011d1b7895515bc159/overlay-arm64-llvmpipe/profiles/base/make.defaults
[modify] https://crrev.com/d2452479b2ef0f784cf401011d1b7895515bc159/overlay-amd64-generic/profiles/base/make.defaults
[modify] https://crrev.com/d2452479b2ef0f784cf401011d1b7895515bc159/chipset-stnyridge/profiles/base/make.defaults

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a837b79ceb04f392716b578bd6ec7854d193724e

commit a837b79ceb04f392716b578bd6ec7854d193724e
Author: Gurchetan Singh <gurchetansingh@chromium.org>
Date: Sat Oct 14 02:43:00 2017

media-libs/mesa: conditionally build LLVM

Building LLVM takes 8-10 minutes, but we only need it for certain
Gallium based drivers. Now that we set the USE flags for
LLVM (see CL:693422), let's only build it when needed.

BUG= chromium:751295 
TEST=emerge-cyan mesa doesn't pull in LLVM
     emerge-betty mesa does

Change-Id: Ie4355d7862bdc3bece9ddd619a5c2d109a74af7b
Reviewed-on: https://chromium-review.googlesource.com/716868
Commit-Ready: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Gurchetan Singh <gurchetansingh@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/a837b79ceb04f392716b578bd6ec7854d193724e/media-libs/mesa/mesa-9999.ebuild
[modify] https://crrev.com/a837b79ceb04f392716b578bd6ec7854d193724e/profiles/targets/chromeos/package.use
[rename] https://crrev.com/a837b79ceb04f392716b578bd6ec7854d193724e/media-libs/mesa/mesa-17.1.1-r12.ebuild
[modify] https://crrev.com/a837b79ceb04f392716b578bd6ec7854d193724e/media-libs/mesa/mesa-17.1.1.ebuild

Status: Verified (was: Assigned)

Sign in to add a comment