New issue
Advanced search Search tips

Issue 751287 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[remoting host] Remove Mac pref-pane.

Project Member Reported by lambroslambrou@chromium.org, Aug 1 2017

Issue description

When setting up a new host on macOS, the system pref-pane is launched.
The user has to re-confirm their PIN (typing it a third time) and unlock the padlock icon at the bottom. This UX is cumbersome and non-intuitive.
We should remove the pref-pane, and provide an experience similar to that on Windows instead.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da7b42d14dfc2fdd88636f4ad2dd61bde31ed4d3

commit da7b42d14dfc2fdd88636f4ad2dd61bde31ed4d3
Author: Lambros Lambrou <lambroslambrou@chromium.org>
Date: Mon Aug 07 23:52:20 2017

[remoting mac] Bypass prefpane when enabling host.

The Mac system pref-pane is normally used to setup a new host, or to
change the PIN or disable the host. All 3 operations require
elevation to root.
This CL modifies the native-messaging host to elevate and perform the
operations directly, instead of launching the pref-pane.
The pref-pane will be removed from the installer and the build system
in followup CLs.

Bug:  751287 
Change-Id: I31ff42f298f5343d7d60b189b50bc918a7867859
Reviewed-on: https://chromium-review.googlesource.com/597069
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492455}
[modify] https://crrev.com/da7b42d14dfc2fdd88636f4ad2dd61bde31ed4d3/remoting/host/setup/daemon_controller_delegate_mac.h
[modify] https://crrev.com/da7b42d14dfc2fdd88636f4ad2dd61bde31ed4d3/remoting/host/setup/daemon_controller_delegate_mac.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6712d2a3bed0f7dfd47fe8d0ec3ecc03e12fa567

commit 6712d2a3bed0f7dfd47fe8d0ec3ecc03e12fa567
Author: Lambros Lambrou <lambroslambrou@chromium.org>
Date: Wed Aug 09 19:20:46 2017

[remoting] Remove Mac pref-pane from installer.

This removes the pref-pane from the Mac installer package.
The uninstaller no longer removes the pref-pane.
The installer pre-flight step is also updated to remove any pref-pane
from a previous version.

Bug:  751287 
Change-Id: I29e3a3fd742762b838db3de2f1ab88535ae7cf2e
Reviewed-on: https://chromium-review.googlesource.com/603067
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493093}
[modify] https://crrev.com/6712d2a3bed0f7dfd47fe8d0ec3ecc03e12fa567/remoting/host/installer/mac/BUILD.gn
[modify] https://crrev.com/6712d2a3bed0f7dfd47fe8d0ec3ecc03e12fa567/remoting/host/installer/mac/ChromotingHostService.pkgproj
[modify] https://crrev.com/6712d2a3bed0f7dfd47fe8d0ec3ecc03e12fa567/remoting/host/installer/mac/PrivilegedHelperTools/org.chromium.chromoting.me2me.sh
[modify] https://crrev.com/6712d2a3bed0f7dfd47fe8d0ec3ecc03e12fa567/remoting/host/installer/mac/Scripts/remoting_preflight.sh
[modify] https://crrev.com/6712d2a3bed0f7dfd47fe8d0ec3ecc03e12fa567/remoting/host/installer/mac/do_signing.props
[modify] https://crrev.com/6712d2a3bed0f7dfd47fe8d0ec3ecc03e12fa567/remoting/host/installer/mac/do_signing.sh
[modify] https://crrev.com/6712d2a3bed0f7dfd47fe8d0ec3ecc03e12fa567/remoting/host/installer/mac/uninstaller/remoting_uninstaller.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c3104cad4a4a854f9d72839d242b0fd2098272e

commit 6c3104cad4a4a854f9d72839d242b0fd2098272e
Author: Lambros Lambrou <lambroslambrou@chromium.org>
Date: Mon Aug 14 18:57:58 2017

[chromoting mac] Show custom title+icon in elevation prompt.

Now that the elevation is performed by the native messaging host
(instead of the pref-pane), we need to set the title and icon so the
user knows what is asking for privileges. Otherwise the dialog
would show a generic icon and title: "native_messaging_host wants to
make changes".

Bug:  751287 
Change-Id: I5a0fe05fd56ca9d510e933c7c4211c410d82e640
Reviewed-on: https://chromium-review.googlesource.com/611566
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494117}
[modify] https://crrev.com/6c3104cad4a4a854f9d72839d242b0fd2098272e/remoting/host/mac/BUILD.gn
[modify] https://crrev.com/6c3104cad4a4a854f9d72839d242b0fd2098272e/remoting/host/setup/daemon_controller_delegate_mac.mm
[add] https://crrev.com/6c3104cad4a4a854f9d72839d242b0fd2098272e/remoting/resources/product_logo_32.png
[modify] https://crrev.com/6c3104cad4a4a854f9d72839d242b0fd2098272e/remoting/resources/remoting_strings.grd

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53f3dd05e9a5df95ab99398de7b5813f561552e4

commit 53f3dd05e9a5df95ab99398de7b5813f561552e4
Author: Lambros Lambrou <lambroslambrou@chromium.org>
Date: Mon Aug 14 20:19:48 2017

[remoting mac] Completely remove pref-pane.

This purges the remoting pref-pane from the codebase. The only
remaining reference is in the preflight install script which
removes the pref-pane from the system.

Bug:  751287 
Change-Id: I65e97e9c81263a8cee5d0a71c4dcf8fe351f86af
Reviewed-on: https://chromium-review.googlesource.com/612620
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494163}
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/branding_Chrome
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/branding_Chromium
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/host/BUILD.gn
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/host/host_config.cc
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/host_config_constants.cc
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/host/mac/BUILD.gn
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/host/mac/constants_mac.cc
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/host/mac/constants_mac.h
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane-Info.plist
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane-InfoPlist.strings.jinja2
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane.h
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane.mm
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane.xib
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane_confirm_pin.h
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane_confirm_pin.mm
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane_confirm_pin.xib
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane_disable.h
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane_disable.mm
[delete] https://crrev.com/c66796aceaf9fb04d15aca43ff0c30de63dd4d5c/remoting/host/mac/me2me_preference_pane_disable.xib
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/host/setup/me2me_native_messaging_host_main.cc
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/host/version.h.in
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/remoting_version.gni
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/resources/BUILD.gn
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/resources/remoting_strings.grd
[modify] https://crrev.com/53f3dd05e9a5df95ab99398de7b5813f561552e4/remoting/tools/get_mac_crd_version.sh

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 63.0.3210.0. Enable and disable, with an upgraded and with a newly installed host.

Sign in to add a comment