Back button should work for rtl languages. |
|||||||
Issue descriptionIn RTL, the back button is draw as expected but clicks on the back button open the launcher and launcher circle goes back.
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc commit 3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc Author: Sammie Quon <sammiequon@google.com> Date: Mon Aug 14 19:46:14 2017 shelf: Make back button work in rtl languages. Back button now does the right thing in RTL languages. It still does not work with voice interaction animation overlay but that is left untouched due to voice interaction animation overlay not working in RTL by itself. Bug: 751280 Test: ash_unittests "BackButtonAppListButtonTest*" Change-Id: I8cd595bbf076beb2383fa1324a9f4a217ca44536 Reviewed-on: https://chromium-review.googlesource.com/597107 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#494139} [modify] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/ash/resources/vector_icons/shelf_back.1x.icon [modify] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/ash/resources/vector_icons/shelf_back.icon [modify] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/ash/shelf/app_list_button.cc [modify] https://crrev.com/3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc/ash/shelf/app_list_button_unittest.cc
,
Aug 15 2017
,
Aug 17 2017
,
Aug 17 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 17 2017
Approving merge to M61 Chrome OS.
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bc37e9f88e353e7e9e3538e50bea42c221b8ad4 commit 0bc37e9f88e353e7e9e3538e50bea42c221b8ad4 Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Thu Aug 17 20:29:50 2017 shelf: Make back button work in rtl languages. Back button now does the right thing in RTL languages. It still does not work with voice interaction animation overlay but that is left untouched due to voice interaction animation overlay not working in RTL by itself. TBR=sammiequon@google.com (cherry picked from commit 3104d52a9c3e5eae67a1f2a294ad33e2e6c600bc) Bug: 751280 Test: ash_unittests "BackButtonAppListButtonTest*" Change-Id: I8cd595bbf076beb2383fa1324a9f4a217ca44536 Reviewed-on: https://chromium-review.googlesource.com/597107 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#494139} Reviewed-on: https://chromium-review.googlesource.com/619451 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#640} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/0bc37e9f88e353e7e9e3538e50bea42c221b8ad4/ash/resources/vector_icons/shelf_back.1x.icon [modify] https://crrev.com/0bc37e9f88e353e7e9e3538e50bea42c221b8ad4/ash/resources/vector_icons/shelf_back.icon [modify] https://crrev.com/0bc37e9f88e353e7e9e3538e50bea42c221b8ad4/ash/shelf/app_list_button.cc [modify] https://crrev.com/0bc37e9f88e353e7e9e3538e50bea42c221b8ad4/ash/shelf/app_list_button_unittest.cc
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tdander...@chromium.org
, Aug 2 2017Labels: -Proj-TabletChrome