New issue
Advanced search Search tips

Issue 751279 link

Starred by 1 user
Status: Assigned
Owner:
tapted@chromium.org
Cc:
ellyjo...@chromium.org
bettes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

decide on and implement default button (action) for ToolbarActionsBarBubbleViews

Project Member Reported by est...@chromium.org, Aug 1 2017 
this bubble is used if an extension changes your NTP or other settings. It allows the user to confirm or deny that they wanted to make the change.

There's currently no default button for these dialogs. We should probably have a default. Assigning to Trent for triage as part of Harmony.

see https://cs.chromium.org/chromium/src/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc?rcl=f643128b41b9ea11a583fa255b7df3c73cab2c37&l=161

Comment 1 by tapted@chromium.org, Aug 2 2017

Cc: ellyjo...@chromium.org bettes@chromium.org
Labels: OS-Mac
We need some designer input here. Currently the mocks are not implementable.

Example mocks:
 - proxy  Issue 654126  (default-button: restore)
 - ntp  Issue 654121  (default-button: restore)
 - new permissions 654124 (default-button: re-enable)

In those.. the blue/default button is always on the left. If we assume these mocks are Mac, left-side is used for "cancel". But "cancel" should never be default on Mac (PlatformStyle::kDialogDefaultButtonCanBeCancel = false -- see  Issue 605652 ). So these won't get blue-styling on Mac if we say the cancel button is default at the link in this issue's description:

    const bool is_default = delegate->GetDefaultDialogButton() == type &&
                            (type != ui::DIALOG_BUTTON_CANCEL ||
                             PlatformStyle::kDialogDefaultButtonCanBeCancel);

The dialogs also have a close [x]

default buttons react to Enter
cancel buttons react to Escape

Escape can also be suppressed if we want that. (and specifying no default/blue button as we do currently will suppress Enter).
►

Sign in to add a comment