New issue
Advanced search Search tips

Issue 751273 link

Starred by 1 user
Status: Verified
Owner:
yuweih@chromium.org
Closed: Aug 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] HostView keyboard layout broken when rotating on iPad

Project Member Reported by yuweih@chromium.org, Aug 1 2017 
What steps will reproduce the problem?
(1) Connect to a host on iPad
(2) Show the soft keyboard
(3) Rotate the screen

What is the expected result?

The view is properly laid out.

What happens instead?

Part of the host view gets covered by the keyboard.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ad8bf2ffab118707fc7ca4f6bf25dd676c70c7f

commit 0ad8bf2ffab118707fc7ca4f6bf25dd676c70c7f
Author: Yuwei Huang <yuweih@chromium.org>
Date: Wed Aug 02 21:59:34 2017

[CRD iOS] Rework the HostView keyboard layout

When rotating the screen on iPad with the keyboard showing, for some
reason the host view will become improperly laid out. Part of the view
gets overlaid by the keyboard.

My suspicion is the view frame becomes inconsistent when the rotation
happens.

This CL fixes the problem by reworking the keyboard layout using
constraints. It also makes GLRenderer cache the view size before the
canvas is created.

Bug:  751273 
Change-Id: I5146ff6bf602eef1857259e5e50ca6be1d952a68
Reviewed-on: https://chromium-review.googlesource.com/596913
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Scott Nichols <nicholss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491519}
[modify] https://crrev.com/0ad8bf2ffab118707fc7ca4f6bf25dd676c70c7f/remoting/client/display/gl_renderer.cc
[modify] https://crrev.com/0ad8bf2ffab118707fc7ca4f6bf25dd676c70c7f/remoting/client/display/gl_renderer.h
[modify] https://crrev.com/0ad8bf2ffab118707fc7ca4f6bf25dd676c70c7f/remoting/ios/app/host_view_controller.mm

Comment 2 by yuweih@chromium.org, Aug 3 2017

Status: Fixed (was: Assigned)

Comment 3 by ajnolley@chromium.org, Sep 23 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment