New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 751269 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Aug 2017
Cc:
█ imch...@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task

Blocked on:
issue 737320


Sign in to add a comment

[Media Router] Allow the component extension to suspend while showing route controllers

Project Member Reported by taku...@chromium.org, Aug 1 2017 
The WebUI route controllers currently require the component extension is awake in order to maintain the Mojo connection between the browser-side and extension-side controllers. By implementing a reconnect mechanism between the controllers using EventPageRequestManager, we can let the extension suspend.

Design doc:
https://docs.google.com/document/d/1PEcNLc9TTaRbeC1jZwVX7E3Rm3bJrqV8049cKXQ7Yho/edit
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289

commit adda1f9b50e60b82bd26c04bcf883bf7aa3d1289
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed Aug 16 05:19:41 2017

[Media Router] Reconnect MediaRouteControllers after extension suspension

- Make MediaRouteController use EventPageRequestManager to queue calls to the extension MediaController when the extension is suspended
- Don't destroy MRController when it's disconnected from the extension controller
- Make MediaRouterDesktop reconnect MRControllers to extension controllers when the extension wakes up

Extension-side change: http://cl/163893310

Bug:  751269 
Change-Id: I6acf38afe54df0389b024c9caee10cc3b34a8e16
Reviewed-on: https://chromium-review.googlesource.com/602709
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494699}
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/media_router_base.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/media_router_base.h
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mock_media_router.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_route_controller.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_route_controller.h
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_route_controller_unittest.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_router_desktop.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_router_mojo_metrics.h
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_router_mojo_test.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/adda1f9b50e60b82bd26c04bcf883bf7aa3d1289/tools/metrics/histograms/enums.xml

Comment 2 by taku...@chromium.org, Aug 25 2017

Status: Fixed (was: Started)
►

Sign in to add a comment