New issue
Advanced search Search tips

Issue 751241 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement throwing for undefined arguments passed to pipeThrough()

Project Member Reported by domenic@chromium.org, Aug 1 2017

Issue description

Tracking bug for the spec change at https://github.com/whatwg/streams/pull/759
 

Comment 1 by ricea@chromium.org, Aug 2 2017

Cc: -ricea@chromium.org
Owner: ricea@chromium.org
Status: Assigned (was: Available)
Assigning to myself so I don't lose track of it. Feel free to take it if you get to it first.

Comment 2 by ricea@chromium.org, Aug 8 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8a808d3178bd1b03fa002db5f6c0fa86881daa7

commit f8a808d3178bd1b03fa002db5f6c0fa86881daa7
Author: Adam Rice <ricea@chromium.org>
Date: Tue Aug 15 22:00:50 2017

Streams: Throw for undefined values in pipeThrough

Throw if the |writable| or |readable| arguments passed to pipeThrough
are undefined.

This corresponds to the Streams Standard change
https://github.com/whatwg/streams/commit/406ed766a8969cd8e2fb3a7e709d59a2f601b5e0

BUG= 751241 

Change-Id: I373d831eebaa006e0b50851729f064a0e39f6284
Reviewed-on: https://chromium-review.googlesource.com/603668
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494566}
[delete] https://crrev.com/abefb7f983ef02a2489d3b54f6dfa4d68f6d0310/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through-expected.txt
[delete] https://crrev.com/abefb7f983ef02a2489d3b54f6dfa4d68f6d0310/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through.dedicatedworker-expected.txt
[delete] https://crrev.com/abefb7f983ef02a2489d3b54f6dfa4d68f6d0310/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through.serviceworker.https-expected.txt
[delete] https://crrev.com/abefb7f983ef02a2489d3b54f6dfa4d68f6d0310/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through.sharedworker-expected.txt
[modify] https://crrev.com/f8a808d3178bd1b03fa002db5f6c0fa86881daa7/third_party/WebKit/Source/core/streams/ReadableStream.js

Comment 4 by ricea@chromium.org, Aug 15 2017

Status: Fixed (was: Started)

Sign in to add a comment