TrayUpdateTest.VisibilityAfterUpdateOverCellularAvailable is flaky when run locally |
|||
Issue description
Run this:
testing/xvfb.py out/Default/ash_unittests
Usually it fails the first time then passes on retry.
[ RUN ] TrayUpdateTest.VisibilityAfterUpdateOverCellularAvailable
../../ash/system/update/tray_update_unittest.cc:64: Failure
Value of: tray_update->tray_view()->visible()
Actual: true
Expected: false
../../ash/system/update/tray_update_unittest.cc:76: Failure
Expected: "Click to view update details"
To be equal to: base::UTF16ToUTF8(label)
Which is: "Restart to update Adobe Flash Player"
[ FAILED ] TrayUpdateTest.VisibilityAfterUpdateOverCellularAvailable (57 ms)
I wonder if there is some static variable or command line flag that is not being reset between test runs.
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff9b4cf80ffc5530c350c3b9b77fd10dd3f60000 commit ff9b4cf80ffc5530c350c3b9b77fd10dd3f60000 Author: Weidong Guo <weidongg@chromium.org> Date: Thu Aug 03 02:31:41 2017 Fix TrayUpdateTest flaky Changes: 1. Add TrayUpdate::ResetForTesting to reset everything in TrayUpdate before testing to prevent effect from previous testing. BUG= 751236 TEST=TrayUpdateTest.* Change-Id: I85e2641d50448d656b64592dd025efd481428594 Reviewed-on: https://chromium-review.googlesource.com/596523 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#491621} [modify] https://crrev.com/ff9b4cf80ffc5530c350c3b9b77fd10dd3f60000/ash/system/update/tray_update.cc [modify] https://crrev.com/ff9b4cf80ffc5530c350c3b9b77fd10dd3f60000/ash/system/update/tray_update.h [modify] https://crrev.com/ff9b4cf80ffc5530c350c3b9b77fd10dd3f60000/ash/system/update/tray_update_unittest.cc
,
Aug 3 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by weidongg@chromium.org
, Aug 1 2017