New issue
Advanced search Search tips

Issue 751215 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

zucchini fails to build on clang tot bots

Project Member Reported by thakis@chromium.org, Aug 1 2017

Issue description

FAILED: obj/chrome/installer/zucchini/zucchini/zucchini_commands.obj 
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes  @obj/chrome/installer/zucchini/zucchini/zucchini_commands.obj.rsp /c ../../chrome/installer/zucchini/zucchini_commands.cc /Foobj/chrome/installer/zucchini/zucchini/zucchini_commands.obj /Fd"obj/chrome/installer/zucchini/zucchini_cc.pdb"
C:\b\c\builder\ClangToTWin\src\chrome\installer\zucchini\zucchini_commands.cc(51,5):  error: comparison of constant 9223372036854775807 with expression of type 'size_t' (aka 'unsigned int') is always true [-Werror,-Wtautological-constant-out-of-range-compare]
    CHECK_LE(length, static_cast<uint64_t>(INT64_MAX));
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\b\c\builder\ClangToTWin\src\base\logging.h(769,43):  note: expanded from macro 'CHECK_LE'
#define CHECK_LE(val1, val2) CHECK_OP(LE, <=, val1, val2)
                             ~~~~~~~~~~~~~^~~~~~~~~~~~~~~
C:\b\c\builder\ClangToTWin\src\base\logging.h(613,53):  note: expanded from macro 'CHECK_OP'
#define CHECK_OP(name, op, val1, val2) CHECK((val1) op (val2))
                                       ~~~~~~~~~~~~~^~~~~~~~~~
C:\b\c\builder\ClangToTWin\src\base\logging.h(603,14):  note: expanded from macro 'CHECK'
  UNLIKELY(!(condition)) ? IMMEDIATE_CRASH() : EAT_STREAM_PARAMETERS
  ~~~~~~~~~~~^~~~~~~~~~~
C:\b\c\builder\ClangToTWin\src\base\compiler_specific.h(220,22):  note: expanded from macro 'UNLIKELY'
#define UNLIKELY(x) (x)
                     ^
1 error generated.
[779/61886] CXX obj/chro
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5181009502bc37d6e731ac348a7ea304289587a7

commit 5181009502bc37d6e731ac348a7ea304289587a7
Author: Etienne Pierre-Doray <etiennep@chromium.org>
Date: Tue Aug 01 21:49:39 2017

Remove CHECK in zucchini_commands that always evaluates to true.

Bug:  751215 
Change-Id: I5c7e2978528b690fa41f2ca8483b3a98ff264609
Reviewed-on: https://chromium-review.googlesource.com/596907
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491122}
[modify] https://crrev.com/5181009502bc37d6e731ac348a7ea304289587a7/chrome/installer/zucchini/zucchini_commands.cc

Status: Fixed (was: Assigned)

Sign in to add a comment