shill: cellular service activation state isn't always updated after hot swapping the SIM |
|||
Issue descriptionAfter hot swapping the SIM, shill re-creates the cellular service, but sometimes incorrectly put it in an unactivated state. shill currently evaluates the service activation states based on a few information retrieved from the modem (e.g. registration state, subscription state, MDN, ICCID etc). However, upon receiving updates on ICCID and MDN, shill currently doesn't re-evaluates the service activation state.
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/f5bdf639d3584bfcf350b9373742e553da6dc7bf commit f5bdf639d3584bfcf350b9373742e553da6dc7bf Author: Ben Chan <benchan@chromium.org> Date: Tue Aug 01 23:22:06 2017 shill: cellular: re-evaluate service activation state upon ICCID/MDN updates CellularCapabilityUniversal::UpdateServiceActivationState() evaluates the activation state of a CellularService based on a few information, including ICCID and MDN, retrieved from the modem. shill thus needs to invoke CellularCapabilityUniversal::UpdateServiceActivationState() upon updates on ICCID and MDN. BUG= chromium:751208 TEST=Run unit tests and manually test SIM hot swap on a modem. Change-Id: Ic4cd4318e2407559e14dd4328e803e32deafd965 Reviewed-on: https://chromium-review.googlesource.com/596827 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/f5bdf639d3584bfcf350b9373742e553da6dc7bf/cellular/cellular_capability_universal_unittest.cc [modify] https://crrev.com/f5bdf639d3584bfcf350b9373742e553da6dc7bf/cellular/cellular_capability_universal.cc
,
Aug 1 2017
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by benchan@chromium.org
, Aug 1 2017