Issue metadata
Sign in to add a comment
|
PlayCanvas' After the Flood demo renders black on macOS |
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3167.0 (Official Build) canary (64-bit) OS: macOS What steps will reproduce the problem? (1) Go to PlayCanvas' After the Flood demo: https://playcanv.as/e/p/44MRmJRU/ What is the expected result? Expect the demo to load and run. What happens instead? The demo loads, but renders black, with tons of error messages: [.Offscreen-For-WebGL-0x7fb3fb881c00]GL ERROR :GL_INVALID_OPERATION : glBlitFramebufferCHROMIUM: src and dst formats differ for color This is a regression caused by the fix for Issue 699566 .
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a758ce4a57c024753bb396f7b04ea66b92c2302e commit a758ce4a57c024753bb396f7b04ea66b92c2302e Author: Kenneth Russell <kbr@chromium.org> Date: Wed Aug 02 07:43:34 2017 Fix BlitFramebuffer RGB emulation on macOS. The fix for Issue 699566 regressed blits between user framebuffers on macOS when alpha:false and antialias:false. Only apply the workaround when blitting to the default WebGL back buffer. Tested by new conformance test conformance2/rendering/blitframebuffer-r11f-g11f-b10f.html from https://github.com/KhronosGroup/WebGL/pull/2469 . BUG= 751206 TBR=zmo@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6025bcd562675318d6cd9d3fcc50aa90fa83642b Reviewed-on: https://chromium-review.googlesource.com/596679 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491300} [modify] https://crrev.com/a758ce4a57c024753bb396f7b04ea66b92c2302e/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp [modify] https://crrev.com/a758ce4a57c024753bb396f7b04ea66b92c2302e/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp [modify] https://crrev.com/a758ce4a57c024753bb396f7b04ea66b92c2302e/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
,
Aug 2 2017
While this wasn't a security issue, it broke an important customer's flagship WebGL demonstration (and game engine). It's a small, simple and self-contained fix so I'm requesting merge permission back to Chrome 61.
,
Aug 3 2017
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3 2017
Tested the issue on Mac OS 10.12.6 using Chrome Canary version M62 - 62.0.3175.0 as per the issue mentioned in original comment. Observed that issue is working as intended (Able to load the actual game after the demo). Hence adding TE-Verified label. Attached the screencast for reference. Observations: There is some lagging while playing in High and Ultra mode’s. But, similar behavior is noticed on FireFox. Thank you!
,
Aug 3 2017
Pls merge you change to M61 branch 3163 by 5:00 PM PT, Friday (08/04) so we can take it in for next week M61 Beta release. Thank you.
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ab437fe5797de3b76891d508ac7f82b5ed89029 commit 3ab437fe5797de3b76891d508ac7f82b5ed89029 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Aug 04 18:57:29 2017 Fix BlitFramebuffer RGB emulation on macOS. The fix for Issue 699566 regressed blits between user framebuffers on macOS when alpha:false and antialias:false. Only apply the workaround when blitting to the default WebGL back buffer. Tested by new conformance test conformance2/rendering/blitframebuffer-r11f-g11f-b10f.html from https://github.com/KhronosGroup/WebGL/pull/2469 . BUG= 751206 TBR=kbr@chromium.org, zmo@chromium.org NOTRY=true (cherry picked from commit a758ce4a57c024753bb396f7b04ea66b92c2302e) Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6025bcd562675318d6cd9d3fcc50aa90fa83642b Reviewed-on: https://chromium-review.googlesource.com/596679 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491300} Reviewed-on: https://chromium-review.googlesource.com/602689 Cr-Commit-Position: refs/branch-heads/3163@{#321} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/3ab437fe5797de3b76891d508ac7f82b5ed89029/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp [modify] https://crrev.com/3ab437fe5797de3b76891d508ac7f82b5ed89029/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp [modify] https://crrev.com/3ab437fe5797de3b76891d508ac7f82b5ed89029/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
,
Aug 7 2017
Issue 752143 has been merged into this issue.
,
Aug 9 2017
Rechecked the issue on Mac OS 10.12.6 using Chrome Beta version M62 - 61.0.3163.39 as per the issue mentioned in original comment. Observed that issue is working as intended (Able to load the actual game after the demo). Hence adding TE-Verified label. Thanks.!
,
Aug 7
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbr@chromium.org
, Aug 1 2017