With the recent change to HostScanner that prevents notifications from being shown when a DefaultNetwork exists, 'available hotspot(s) nearby' notifications are not always shown when host(s) exist (https://cs.chromium.org/chromium/src/chromeos/components/tether/host_scanner.cc?l=85). However, the UMA reporting around this does not also consider if a DefaultNetwork exists: https://cs.chromium.org/chromium/src/chromeos/components/tether/host_scanner.cc?l=169
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a451f7d744a92106af0c3201e2ec73f85430a5cc commit a451f7d744a92106af0c3201e2ec73f85430a5cc Author: Ryan Hansberry <hansberry@chromium.org> Date: Thu Aug 10 01:19:53 2017 Tether: expand host scan result metrics to include when hosts are found but no notification is shown. Bug: 751176 , 672263 Change-Id: I70411159bc8fa950f3d5988b2a3158ae807c582d Reviewed-on: https://chromium-review.googlesource.com/606734 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#493209} [modify] https://crrev.com/a451f7d744a92106af0c3201e2ec73f85430a5cc/chromeos/components/tether/host_scanner.cc [modify] https://crrev.com/a451f7d744a92106af0c3201e2ec73f85430a5cc/chromeos/components/tether/host_scanner.h [modify] https://crrev.com/a451f7d744a92106af0c3201e2ec73f85430a5cc/chromeos/components/tether/host_scanner_unittest.cc [modify] https://crrev.com/a451f7d744a92106af0c3201e2ec73f85430a5cc/tools/metrics/histograms/enums.xml [modify] https://crrev.com/a451f7d744a92106af0c3201e2ec73f85430a5cc/tools/metrics/histograms/histograms.xml
Approving merge to M61 Chrome OS.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f764e9fc7ed7dec1a6572c26653583613c5068cb commit f764e9fc7ed7dec1a6572c26653583613c5068cb Author: Kyle Horimoto <khorimoto@google.com> Date: Thu Aug 10 18:07:03 2017 Tether: expand host scan result metrics to include when hosts are found but no notification is shown. TBR=hansberry@chromium.org (cherry picked from commit a451f7d744a92106af0c3201e2ec73f85430a5cc) Bug: 751176 , 672263 Change-Id: I70411159bc8fa950f3d5988b2a3158ae807c582d Reviewed-on: https://chromium-review.googlesource.com/606734 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493209} Reviewed-on: https://chromium-review.googlesource.com/610882 Cr-Commit-Position: refs/branch-heads/3163@{#438} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/f764e9fc7ed7dec1a6572c26653583613c5068cb/chromeos/components/tether/host_scanner.cc [modify] https://crrev.com/f764e9fc7ed7dec1a6572c26653583613c5068cb/chromeos/components/tether/host_scanner.h [modify] https://crrev.com/f764e9fc7ed7dec1a6572c26653583613c5068cb/chromeos/components/tether/host_scanner_unittest.cc [modify] https://crrev.com/f764e9fc7ed7dec1a6572c26653583613c5068cb/tools/metrics/histograms/enums.xml [modify] https://crrev.com/f764e9fc7ed7dec1a6572c26653583613c5068cb/tools/metrics/histograms/histograms.xml
Comment 1 by hansberry@chromium.org
, Aug 1 2017