New issue
Advanced search Search tips

Issue 751167 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Add Expect-CT support to chrome://net-internals

Project Member Reported by est...@chromium.org, Aug 1 2017

Issue description

Users should be able to query and modify the dynamic Expect-CT set via chrome://net-internals, same as they can for HSTS/HPKP. We might want to rename this tab to Domain Security Policy or similar since it's already broader in scope than the name implies.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a91b1be7044e66c2ec0794b251d3af526d6723b2

commit a91b1be7044e66c2ec0794b251d3af526d6723b2
Author: Emily Stark <estark@google.com>
Date: Mon Aug 14 19:06:12 2017

Rename net-internals HSTS tab to Domain Security Policy

This is in preparation to add Expect-CT support to this tab. Regardless of
Expect-CT, it seems reasonable to rename it to Domain Security Policy anyway
because it already encompasses more than just HSTS (namely, HPKP). The hash
fragment remains #hsts to preserve existing links/documentation that direct
users to chrome://net-internals#hsts.

Bug:  751167 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id8e5b3c2dc36c8641292ddfd49ae2a75e1e94389
Reviewed-on: https://chromium-review.googlesource.com/596527
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494120}
[rename] https://crrev.com/a91b1be7044e66c2ec0794b251d3af526d6723b2/chrome/browser/resources/net_internals/domain_security_policy_view.html
[rename] https://crrev.com/a91b1be7044e66c2ec0794b251d3af526d6723b2/chrome/browser/resources/net_internals/domain_security_policy_view.js
[modify] https://crrev.com/a91b1be7044e66c2ec0794b251d3af526d6723b2/chrome/browser/resources/net_internals/index.html
[modify] https://crrev.com/a91b1be7044e66c2ec0794b251d3af526d6723b2/chrome/browser/resources/net_internals/index.js
[modify] https://crrev.com/a91b1be7044e66c2ec0794b251d3af526d6723b2/chrome/browser/resources/net_internals/main.js
[modify] https://crrev.com/a91b1be7044e66c2ec0794b251d3af526d6723b2/chrome/test/data/webui/BUILD.gn
[rename] https://crrev.com/a91b1be7044e66c2ec0794b251d3af526d6723b2/chrome/test/data/webui/net_internals/domain_security_policy_view.js
[modify] https://crrev.com/a91b1be7044e66c2ec0794b251d3af526d6723b2/chrome/test/data/webui/net_internals/net_internals_test.js

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/702a54b13c210e480cb1729adee4f8dfcd136bd0

commit 702a54b13c210e480cb1729adee4f8dfcd136bd0
Author: Emily Stark <estark@google.com>
Date: Thu Aug 17 01:25:34 2017

Implement Expect-CT support for net-internals

This adds Expect-CT support to the Domain Security Policy tab of
chrome://net-internals. First, I extracted the delete form into a generic
"Delete domain security policy state" form, since it's not specific to
HSTS/HPKP. Then I added support for querying and adding Expect-CT
dynamic state. We may want to add support for querying static (preloaded)
Expect-CT state in a follow-up CL.

Bug:  751167 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I73cbf30430c8558c62bb2c9733fead13f809924d
Reviewed-on: https://chromium-review.googlesource.com/596688
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495035}
[modify] https://crrev.com/702a54b13c210e480cb1729adee4f8dfcd136bd0/chrome/browser/resources/net_internals/browser_bridge.js
[modify] https://crrev.com/702a54b13c210e480cb1729adee4f8dfcd136bd0/chrome/browser/resources/net_internals/domain_security_policy_view.html
[modify] https://crrev.com/702a54b13c210e480cb1729adee4f8dfcd136bd0/chrome/browser/resources/net_internals/domain_security_policy_view.js
[modify] https://crrev.com/702a54b13c210e480cb1729adee4f8dfcd136bd0/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/702a54b13c210e480cb1729adee4f8dfcd136bd0/chrome/test/data/webui/net_internals/domain_security_policy_view.js

Status: Fixed (was: Assigned)

Sign in to add a comment