Chrome selects PDF text as mouse moves even though mouse button is not being held down |
||||
Issue descriptionChrome Version: 60.0.3112.50 OS: macOS 10.12 What steps will reproduce the problem? (1) Go to http://che.org.il/wp-content/uploads/2016/12/pdf-sample.pdf (2) Control-click on the page and choose "Print..." from the contextual menu (3) Click Cancel in the Print dialog (4) Move the mouse What is the expected result? The PDF should remain with no text selection. What happens instead? Chrome selects the PDF's text as if the mouse button is being held down. It appears that Chrome's PDF engine is treating the Control-click as a mouse down lacking a corresponding mouse up. -> thestig@ for print triage.
,
Aug 3 2017
shrike: BTW, do you know if this regressed?
,
Aug 3 2017
I wouldn't be surprised if it's Mac-only. And I don't think it's regressed, at least not recently (bug exists in 46.0.2490.0, for example).
,
Aug 3 2017
We are probably checking the wrong keyboard modifier somewhere inside pdf/
,
Aug 7 2017
Not related to printing. Choosing cast from the context menu results in the same behavior on Mac.
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bfe2a697c314b24b1bcdc8047267175f063b68b commit 5bfe2a697c314b24b1bcdc8047267175f063b68b Author: Lei Zhang <thestig@chromium.org> Date: Mon Aug 21 14:53:20 2017 PDF: Check for alternate right click method on Mac. On Mac, If a user ctrl + left clicks in the PDF Viewer, it opens the context menu like a right click. The PDF Viewer will only receive the mouse down event from the left click, but not the mouse up, which makes the PDF Viewer believe the left mouse button is held down. Handle this case by turning the ctrl + left click mouse down event into a right click event. BUG= 751166 Change-Id: I6669fbbd9f1a2e4155dc2e8735391d3f726e19d3 Reviewed-on: https://chromium-review.googlesource.com/607166 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#495935} [modify] https://crrev.com/5bfe2a697c314b24b1bcdc8047267175f063b68b/pdf/pdfium/pdfium_engine.cc
,
Aug 21 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by thestig@chromium.org
, Aug 3 2017