New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751152 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 634542



Sign in to add a comment

Color management for ShapeDetector

Project Member Reported by zakerinasab@chromium.org, Aug 1 2017

Issue description

third_party/Webkit/Source/modules/shapedetection/ShapeDetector.cpp seems still missing color management. Review the code and add color management to the methods as needed.
 
It seems that we still miss color space support in the mojo description of the skia bitmap object (https://cs.chromium.org/chromium/src/skia/public/interfaces/bitmap.mojom). Checking with Skia people if we need to file a bug or if there is a workaround.
Blocking: 634542
Cc: fs...@chromium.org
Status: WontFix (was: Assigned)
On second thought, I don't think it is a good idea for us to add color management to other teams code. For example, ShapeDetector uses different API from webcam, etc. to pre-process the input. It also have a separate code path for Mac which is not using Blink.
Overall, I think we only need to make sure enough awareness is raised about the new color management features of canvas and related components and leave the adaptation to the code owners.

I set this bug as WontFix. junov@: please re-open the bug if you were disagreed.

Sign in to add a comment