Color management for ShapeDetector |
|||
Issue descriptionthird_party/Webkit/Source/modules/shapedetection/ShapeDetector.cpp seems still missing color management. Review the code and add color management to the methods as needed.
,
Aug 29 2017
Related code path: * ShapeDetector module: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp?q=ShapeDetector&sq=package:chromium&l=1 * Mac interface: https://cs.chromium.org/chromium/src/services/shape_detection/detection_utils_mac.mm?sq=package:chromium * Android interface: https://cs.chromium.org/chromium/src/services/shape_detection/android/java/src/org/chromium/shape_detection/?sq=package:chromium
,
Nov 27 2017
,
Mar 16 2018
On second thought, I don't think it is a good idea for us to add color management to other teams code. For example, ShapeDetector uses different API from webcam, etc. to pre-process the input. It also have a separate code path for Mac which is not using Blink. Overall, I think we only need to make sure enough awareness is raised about the new color management features of canvas and related components and leave the adaptation to the code owners. I set this bug as WontFix. junov@: please re-open the bug if you were disagreed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by zakerinasab@chromium.org
, Aug 25 2017