New issue
Advanced search Search tips

Issue 751145 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in SkPerlinNoiseShaderImpl::PerlinNoiseShaderContext::calculateTurbulenceValueForPo

Project Member Reported by ClusterFuzz, Aug 1 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5265362521423872

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  SkPerlinNoiseShaderImpl::PerlinNoiseShaderContext::calculateTurbulenceValueForPo
  SkPerlinNoiseShaderImpl::PerlinNoiseShaderContext::shade
  SkPerlinNoiseShaderImpl::PerlinNoiseShaderContext::shadeSpan
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=400830:400850

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5265362521423872


Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Components: Internals>Skia
Labels: M-62 Test-Predator-Wrong-CLs
Project Member

Comment 2 by ClusterFuzz, Jan 19 2018

Cc: brianosman@google.com liyuqian@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Reorder colorspaces in GM to match previous behavior by brianosman@google.com - https://chromium.googlesource.com/skia/+/473466c017bd74da21c2165990f8b33a98c6b409

Benchmark rotated rect with AA/noAA by liyuqian@google.com - https://chromium.googlesource.com/skia/+/a27f669f460e9186dbb3ebe3e9323acef95d41b8

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.

Comment 3 by liyuqian@google.com, Jan 19 2018

I don't think that these two CLs would cause the problem. They're just adding / modifying test cases for Skia without changing any of its behavior.
Project Member

Comment 4 by ClusterFuzz, Mar 15 2018

ClusterFuzz has detected this issue as fixed in range 543289:543291.

Detailed report: https://clusterfuzz.com/testcase?key=5265362521423872

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  SkPerlinNoiseShaderImpl::PerlinNoiseShaderContext::calculateTurbulenceValueForPo
  SkPerlinNoiseShaderImpl::PerlinNoiseShaderContext::shade
  SkPerlinNoiseShaderImpl::PerlinNoiseShaderContext::shadeSpan
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=400830:400850
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=543289:543291

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5265362521423872

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Mar 15 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 5265362521423872 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment