Reproduce: 1.) Install bobpay.xyz SW 2.) Install bobpay.xyz android app Problem: Both apps show up as way to pay. What should happen: Only the Android app should show up in the list.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c85db415bbd664fc9a17a4249468428c8ec91a4f commit c85db415bbd664fc9a17a4249468428c8ec91a4f Author: gogerald <gogerald@google.com> Date: Mon Aug 07 23:46:42 2017 [Payments] Dedupe web payment apps. As defined in the web app manifest https://w3c.github.io/manifest/ If a web payment app manifest specifies related_applications and sets '"prefer_related_applications": true' Then we do not display it when the related applications are exist. Test: web payment app: https://gogerald.github.io/pr/bobpaybusiness/ Native Android payment app: https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNSllxOWtTU0U0TDQ/view?usp=sharing Bug: 751128 Change-Id: Id88a35c2cdbd9a66c20411e4fb1ea98c3e083b18 Reviewed-on: https://chromium-review.googlesource.com/601001 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#492453} [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/content/browser/payments/payment_app.proto [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/content/browser/payments/payment_app_database.cc [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/content/browser/payments/payment_app_database.h [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/content/browser/payments/payment_app_info_fetcher.cc [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/content/browser/payments/payment_app_info_fetcher.h [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/content/public/browser/stored_payment_app.cc [modify] https://crrev.com/c85db415bbd664fc9a17a4249468428c8ec91a4f/content/public/browser/stored_payment_app.h
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/d80c84aaea1a3afbd6c11c40f6a3084c68b026ec commit d80c84aaea1a3afbd6c11c40f6a3084c68b026ec Author: gogerald <gogerald@google.com> Date: Tue Aug 08 15:02:29 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/3de34cec809583b38373f6bf4e017d4e2a7c6846 commit 3de34cec809583b38373f6bf4e017d4e2a7c6846 Author: gogerald <gogerald@google.com> Date: Mon Aug 14 16:00:20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a commit 9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a Author: gogerald <gogerald@google.com> Date: Thu Aug 24 22:36:54 2017 [Payments] Further dedupe ServiceWorkerPaymentApp according to native Android payment app Dedupe service worker payment app if there is a native android payment app whose default payment method is the same as its scope. Bug: 751128 Change-Id: I50616ca0f58c79d0c6a8a05eaefa3bd444c7bc2b Reviewed-on: https://chromium-review.googlesource.com/617263 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#497223} [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestServiceWorkerPaymentAppTest.java [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/chrome/browser/android/payments/service_worker_payment_app_bridge.cc [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/content/browser/payments/payment_app.proto [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/content/browser/payments/payment_app_database.cc [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/content/browser/payments/payment_app_provider_impl_unittest.cc [modify] https://crrev.com/9a8cdc457a6cb15ddd7bc141b9a2a502c4ea0d3a/content/public/browser/stored_payment_app.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0b64982cedc3571cb97b1c61da7f41e3bf9890c commit d0b64982cedc3571cb97b1c61da7f41e3bf9890c Author: gogerald <gogerald@google.com> Date: Fri Aug 25 17:35:34 2017 [Payments] Remove redundant overrides Chrome supports java interface default implementation, so we can remove these redundant overrides. Bug: 751128 Change-Id: Ib839471f3e1aa6f303f8685663ba4a1039f79048 Reviewed-on: https://chromium-review.googlesource.com/635946 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#497455} [modify] https://crrev.com/d0b64982cedc3571cb97b1c61da7f41e3bf9890c/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java [modify] https://crrev.com/d0b64982cedc3571cb97b1c61da7f41e3bf9890c/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java [modify] https://crrev.com/d0b64982cedc3571cb97b1c61da7f41e3bf9890c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentApp.java [modify] https://crrev.com/d0b64982cedc3571cb97b1c61da7f41e3bf9890c/chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentApp.java [modify] https://crrev.com/d0b64982cedc3571cb97b1c61da7f41e3bf9890c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java
Comment 1 by bugdroid1@chromium.org
, Aug 7 2017