New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 751121 link

Starred by 1 user
Status: Fixed
Owner:
olivierrobin@chromium.org
Closed: Sep 2017
Cc:
mard...@chromium.org
█ lod@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Report metrics in Search and Content extension

Project Member Reported by olivierrobin@chromium.org, Aug 1 2017 
Report 4 metrics

IOS.SearchExtension.Action: The action pressed by the user in the Search Extension.
IOS.SearchExtension.DisplayCount: The number of times the Search Extension was displayed.
IOS.ContentExtension.Index: The index of the URL pressed by the user in the Content Extension.
IOS.ContentExtension.DisplayCount: The number of times the Content Extension was displayed.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc007cb05604c997886400de2c3ca34f3106f781

commit dc007cb05604c997886400de2c3ca34f3106f781
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Aug 09 17:55:43 2017

Report Content and Search widget display

Number of display is stored in the application group UserDefaults.
On next Chrome foregrounding, histogram is sent.
Histogram sent:
- IOS.ContentExtension.DisplayCount
- IOS.SearchExtension.DisplayCount

Bug:  751121 
Change-Id: I45e9f0ac1f928441c5febfe3e56694a374823870
Reviewed-on: https://chromium-review.googlesource.com/600051
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493047}
[modify] https://crrev.com/dc007cb05604c997886400de2c3ca34f3106f781/ios/chrome/common/app_group/app_group_metrics.h
[modify] https://crrev.com/dc007cb05604c997886400de2c3ca34f3106f781/ios/chrome/common/app_group/app_group_metrics.mm
[modify] https://crrev.com/dc007cb05604c997886400de2c3ca34f3106f781/ios/chrome/common/app_group/app_group_metrics_mainapp.mm
[modify] https://crrev.com/dc007cb05604c997886400de2c3ca34f3106f781/ios/chrome/content_widget_extension/content_widget_view_controller.mm
[modify] https://crrev.com/dc007cb05604c997886400de2c3ca34f3106f781/ios/chrome/search_widget_extension/search_widget_view_controller.mm
[modify] https://crrev.com/dc007cb05604c997886400de2c3ca34f3106f781/tools/metrics/histograms/histograms.xml

Comment 2 by olivierrobin@chromium.org, Aug 16 2017

Labels: OS-iOS
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a870b91dcb64db1672621e317de785e249441c07

commit a870b91dcb64db1672621e317de785e249441c07
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Mon Aug 21 14:46:10 2017

Report user actions in metrics in the new Notification center extensions

Reports
IOS.SearchExtension.Action: The action pressed by the user in the Search Extension.
IOS.ContentExtension.Index: The index of the URL pressed by the user in the Content Extension.

Also fix the source field in the command NSDictionnary.

Bug:  751121 
Change-Id: I936eda50e57ce0722c386205c7106a5ce1823970
Reviewed-on: https://chromium-review.googlesource.com/595978
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Rohit Rao (OOO until 8-30) <rohitrao@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Reviewed-by: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495934}
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/ios/chrome/app/chrome_app_startup_parameters.h
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/ios/chrome/app/chrome_app_startup_parameters.mm
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/ios/chrome/app/chrome_app_startup_parameters_unittest.mm
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/ios/chrome/browser/share_extension/share_extension_item_receiver.mm
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/ios/chrome/common/app_group/app_group_constants.h
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/ios/chrome/common/app_group/app_group_constants.mm
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/ios/chrome/content_widget_extension/content_widget_view_controller.mm
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/ios/chrome/search_widget_extension/search_widget_view_controller.mm
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/ios/chrome/share_extension/share_view_controller.mm
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/ios/chrome/today_extension/today_view_controller.mm
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/a870b91dcb64db1672621e317de785e249441c07/tools/metrics/histograms/histograms.xml

Comment 4 by olivierrobin@chromium.org, Sep 20 2017

Status: Fixed (was: Started)
►

Sign in to add a comment