New issue
Advanced search Search tips

Issue 751119 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

Have StoragePartition create a NetworkContext when the network service is disabled

Project Member Reported by mmenke@chromium.org, Aug 1 2017

Issue description

Have StoragePartition create a NetworkContext when the network service is disabled.

This will allow code to use NetworkContexts both when the network service is
disabled, and when it's enabled, so the same code works with and without the
network service.
 
Status: Fixed (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b83ae72e4bb49182e81914e5bbf933a95213f5d4

commit b83ae72e4bb49182e81914e5bbf933a95213f5d4
Author: Matt Menke <mmenke@chromium.org>
Date: Sat Aug 05 01:04:49 2017

Make StoragePartition always create a NetworkContext.

This will allow code to use NetworkContexts both when the network
service is disabled, and when it's enabled, so the same code works with
and without the network service.

This CL also makes it so the StoragePartition always owns the
NetworkContext, even if the context is created by the embedder.

Bug:  751119 
Change-Id: If63e9f3ba75671c3fb24ce8d956e8ea2d98177dc
Reviewed-on: https://chromium-review.googlesource.com/596229
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492204}
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/chrome/browser/net/profile_network_context_service.cc
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/chrome/browser/net/profile_network_context_service.h
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/chrome/browser/net/profile_network_context_service_browsertest.cc
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/chrome/browser/profiles/profile.h
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/chrome/test/base/testing_profile.h
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/browser/BUILD.gn
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/browser/DEPS
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/browser/storage_partition_impl.h
[add] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/browser/storage_partition_impl_browsertest.cc
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/network/BUILD.gn
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/network/network_context.cc
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/network/network_context.h
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/public/browser/content_browser_client.h
[modify] https://crrev.com/b83ae72e4bb49182e81914e5bbf933a95213f5d4/content/test/BUILD.gn

Comment 3 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment