Issue metadata
Sign in to add a comment
|
Regression : 'CONFIRM' button is seen enabled without entering any digits in chrome://md-settings/lockScreen page |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3163.20/9765.13.0 dev cahnnel Daisy,Kip,Jerry,Quawks and Minnie OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://md-settings -> Now under 'People' section click on 'Screen lock' option (2)Now enter User Password in 'Confirm your password' dialog box -> At 'screen lock options' section select 'PIN or Password' option -> click on 'SET UP PIN' (3)In "Enter your PIN' overlay enter password -> Now in 'Confirm your PIN' overlay observe 'CONFIRM' button is seen enabled without entering any password(Please refer Video and screenshot) Expected: 'CONFIRM' button should not be enabled without entering any digits Actual: Instead 'CONFIRM' button is seen enabled without entering any digits. This is Regression Issue as same is working fine in 61.0.3136.5/9672.0.0 dev-channel Kip @stevenjb : Please confirm the Issue Note: 1.Issue is seen on latest M-62 also 2.issue is also seen on 61.0.3153.0/9733.0.0
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df86ed712d7bb57c25082313e368bb99f23fdf0f commit df86ed712d7bb57c25082313e368bb99f23fdf0f Author: Sammie Quon <sammiequon@google.com> Date: Wed Aug 02 21:40:12 2017 settings: Issues with confirming PIN on lock screen. This CL does: 1) Keeps the confirm button disabled until something has been entered. 2) Enables the confirm button after a new digit has been pressed after a wrong PIN has been entered. 3) Focuses and highlights the wrong PIN after one has been entered. Test: browser_tests "CrSettingsPeoplePageSetupPinDialogTest.*" Bug: 751079 , 751312 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ife71bc02f6955a819cbb65f9d937eb6dd4a78863 Reviewed-on: https://chromium-review.googlesource.com/596922 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#491512} [modify] https://crrev.com/df86ed712d7bb57c25082313e368bb99f23fdf0f/chrome/browser/resources/settings/people_page/setup_pin_dialog.js [modify] https://crrev.com/df86ed712d7bb57c25082313e368bb99f23fdf0f/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
,
Aug 3 2017
,
Aug 9 2017
Verified on Chrome OS 9821.0.0, 62.0.3176.0 dev build. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Aug 1 2017Owner: sammiequon@chromium.org