New issue
Advanced search Search tips

Issue 751067 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Stop calling "startVoiceSearch" to stop voice search.

Project Member Reported by jif@chromium.org, Aug 1 2017

Issue description

The following code:

  // If the background (non-current) BVC is playing TTS audio, call
  // -startVoiceSearch on it to stop the TTS.
  BrowserViewController* backgroundBVC =
      self.mainBVC == self.currentBVC ? self.otrBVC : self.mainBVC;
  if (backgroundBVC.playingTTS)
    [backgroundBVC startVoiceSearchWithOriginView:originView];
  else
    [self.currentBVC startVoiceSearchWithOriginView:originView];

should be changed to:

  BrowserViewController* backgroundBVC =
      self.mainBVC == self.currentBVC ? self.otrBVC : self.mainBVC;
  if (backgroundBVC.playingTTS)
    [backgroundBVC stopVoiceSearch];
  [self.currentBVC startVoiceSearchWithOriginView:originView];
 
This bug had an unsupported status. Updating to Untriaged so someone will reevaluate.
Status: Untriaged
Owner: kkhorimoto@chromium.org
Status: Assigned (was: Untriaged)
this code still exist.
Please assess if this should be fixed.

Sign in to add a comment