New issue
Advanced search Search tips

Issue 751066 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[iOS] Fixing memory leaks related to protocol_copyMethodDescriptionList

Project Member Reported by jlebel@chromium.org, Aug 1 2017

Issue description

The struct returned by protocol_copyMethodDescriptionList() should be freed after used.

https://developer.apple.com/documentation/objectivec/1418822-protocol_copymethoddescriptionli?language=objc

Bug introduced with crrev.com/2785153002
 
Description: Show this description
Description: Show this description
Cc: marq@chromium.org
Components: UI>Browser
Labels: -Pri-3 Stability-Memory Pri-2
Labels: Merge-Request-61
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9242a41e370a43e13ef720d80fc668cb3e6be85b

commit 9242a41e370a43e13ef720d80fc668cb3e6be85b
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Tue Aug 01 12:26:52 2017

Memory leaks with protocol_copyMethodDescriptionList()

The struct returned by protocol_copyMethodDescriptionList() should be
freed after being used.

Bug introduced with crrev.com/2785153002

Bug:  751066 
Change-Id: I869ddfb4e6e3d9a489fa756ed48074a3f63175d8
Reviewed-on: https://chromium-review.googlesource.com/595739
Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490950}
[modify] https://crrev.com/9242a41e370a43e13ef720d80fc668cb3e6be85b/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm

Status: Fixed (was: Started)
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 2 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 2 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4926a42b22f784c536495417fa7f50f16a355b1

commit c4926a42b22f784c536495417fa7f50f16a355b1
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Wed Aug 02 13:34:35 2017

Memory leaks with protocol_copyMethodDescriptionList()

The struct returned by protocol_copyMethodDescriptionList() should be
freed after being used.

Bug introduced with crrev.com/2785153002

TBR=jlebel@chromium.org

(cherry picked from commit 9242a41e370a43e13ef720d80fc668cb3e6be85b)

Bug:  751066 
Change-Id: I869ddfb4e6e3d9a489fa756ed48074a3f63175d8
Reviewed-on: https://chromium-review.googlesource.com/595739
Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490950}
Reviewed-on: https://chromium-review.googlesource.com/597856
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#237}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/c4926a42b22f784c536495417fa7f50f16a355b1/ios/shared/chrome/browser/ui/commands/command_dispatcher.mm

Sign in to add a comment