Native notification contains wrongly-escaped http URL
Reported by
bajk...@googlemail.com,
Aug 1 2017
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 Safari/537.36 Steps to reproduce the problem: 1. Ensure chrome://flags/#enable-native-notifications is enabled 2. Trigger a chrome notification on a website (e.g. https://jsfiddle.net/SiamKreative/8W8XK/) What is the expected behavior? There will be a notification "Hi there" with a clickable "fiddle.jshell.net" link. Clicking the link will open that website. The link is not generated by the website but automatically added by Chrome before the actual notification text. What went wrong? The href of that link, is wrongly escaped and reads: https%3A//fiddle.jshell.net/ dbus-monitor reported the following call being issued: method call time=1501584237.711573 sender=:1.405 -> destination=org.freedesktop.Notifications serial=40 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=Notify string "" uint32 0 string "" string "Hi there!" string "<a href="https%3A//fiddle.jshell.net/">fiddle.jshell.net</a> " array [ string "default" string "" string "settings" string "Einstellungen" ] array [ dict entry( string "urgency" variant uint32 1 ) dict entry( string "desktop-entry" variant string "google-chrome" ) ] int32 -1 Did this work before? N/A Chrome version: 60.0.3112.78 Channel: stable OS Version: Flash Version:
,
Aug 3 2017
Unable to reproduce the issue on Mac 10.12.6 and Ubuntu 14.04 using chrome stable #60.0.3112.90 and chrome reported version #60.0.3112.78. Attached a screen cast for reference. Following are the steps followed to reproduce the issue. ------------ 1. Enabled chrome://flags/#enable-native-notifications. 2. Triggered a chrome notification using URL: https://jsfiddle.net/SiamKreative/8W8XK/) 3. Observed a notification "Hi there" with a clickable "fiddle.jshell.net" link. But the link was not clickable. bajk511@ - Could you please check the screen cast and please let us know if anything missed from our side and also please check the issue on latest stable #60.0.3112.90 by creating a new profile without any apps and extensions and please let us know if the issue still persist or not. Thanks...!!
,
Aug 16 2017
Confirm this issue. krajshree@chromium.org, your notification system daemon doesn't support links, here is my screencast, my DE is Xfce
,
Oct 11 2017
Unable to reproduce this issue on Ubuntu 14.04 with chrome #61.0.3163.100, Since issue is specific to XFCE desktop environment, adding TE-NeedsTriageHelp label for further triage from UI dev team.
,
Oct 11 2017
We use net::EscapePath for escaping the origin, which I don't think is valid. We should probably use net::EscapeForHTML instead?
,
Oct 12 2017
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91e9f7f4b6aa4e866c44b96d43aec0a4e9bdbf2c commit 91e9f7f4b6aa4e866c44b96d43aec0a4e9bdbf2c Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Oct 13 00:35:37 2017 Linux native notifications: Fix escaped characters in URL BUG= 751059 R=peter@chromium.org Change-Id: I3172d8d77c88b8640b9f7bb8c244d9fba881e6c4 Reviewed-on: https://chromium-review.googlesource.com/717461 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#508566} [modify] https://crrev.com/91e9f7f4b6aa4e866c44b96d43aec0a4e9bdbf2c/chrome/browser/notifications/notification_platform_bridge_linux.cc [modify] https://crrev.com/91e9f7f4b6aa4e866c44b96d43aec0a4e9bdbf2c/chrome/browser/notifications/notification_platform_bridge_linux_unittest.cc
,
Oct 13 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ranjitkan@chromium.org
, Aug 2 2017