WebMediaPlayerMS should not be built when WebRTC is disabled |
||
Issue descriptionWebMediaPlayerMS is used to render MediaStream objects in HTML media elements. When WebRTC is disabled, MediaStreams are not supported, but WebMediaPlayerMS is built. A recent patch (https://codereview.chromium.org/2969093002/) that makes WebMediaPlayerMS use some MediaStream methods was reverted because non-WebRTC builds currently include WebMediaPlayerMS but not MediaStream.
,
Aug 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/209f5623248e73f9bd029a6510076e88b504a8a9 commit 209f5623248e73f9bd029a6510076e88b504a8a9 Author: Guido Urdaneta <guidou@chromium.org> Date: Wed Aug 02 09:22:45 2017 Remove WebMediaPlayerMS from builds with WebRTC disabled. When WebRTC is disabled, MediaStream and its supporting classes are not compiled. In these builds, WebMediaPlayerMS is never usec. Moreover, some spec-compliance improvements to WebMediaPlayerMS require access to MediaStream methods. This causes non-WebRTC builds to break. BUG= 751054 Change-Id: Ia10362e082d88ba6a56a206eaf8126a4ca39ef81 Reviewed-on: https://chromium-review.googlesource.com/595727 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#491321} [modify] https://crrev.com/209f5623248e73f9bd029a6510076e88b504a8a9/content/renderer/BUILD.gn [modify] https://crrev.com/209f5623248e73f9bd029a6510076e88b504a8a9/content/test/BUILD.gn
,
Aug 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by guidou@chromium.org
, Aug 1 2017