New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751045 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unused GC idle time histograms

Project Member Reported by u...@chromium.org, Aug 1 2017

Issue description

Remove unused GC idle time histograms
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/01113cb18b58d0f1340e4acce0c59c9cbc289e16

commit 01113cb18b58d0f1340e4acce0c59c9cbc289e16
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Thu Aug 03 19:14:41 2017

[heap] Remove unused GC idle time histograms.

This patch removes tracking of
- V8.GCIdleTimeAllottedInMS
- V8.GCIdleTimeLimit.Overshot
- V8.GCIdleTimeLimit.Undershot

BUG= chromium:751045 

Change-Id: Iccaa0fff609d3caa4cf38ebcc8aca7cdca33c442
Reviewed-on: https://chromium-review.googlesource.com/595588
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47144}
[modify] https://crrev.com/01113cb18b58d0f1340e4acce0c59c9cbc289e16/src/counters.h
[modify] https://crrev.com/01113cb18b58d0f1340e4acce0c59c9cbc289e16/src/heap/heap.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfeb34d89aee3431835ffb388b73d7bb6fd649fa

commit bfeb34d89aee3431835ffb388b73d7bb6fd649fa
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Thu Aug 03 20:29:26 2017

Deprecate old GC idle time histograms.

The patch marks the following histograms as obsolete:
- V8.GCIdleTimeAllottedInMS
- V8.GCIdleTimeLimit.Overshot
- V8.GCIdleTimeLimit.Undershot

BUG= chromium:751045 

Change-Id: I78205e419373f38cc76d45599163cb0d87eabf68
Reviewed-on: https://chromium-review.googlesource.com/594729
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491829}
[modify] https://crrev.com/bfeb34d89aee3431835ffb388b73d7bb6fd649fa/tools/metrics/histograms/histograms.xml

Comment 3 by u...@chromium.org, Aug 4 2017

Status: Fixed (was: Assigned)

Sign in to add a comment