New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 751041 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Find In Page background rect not completely covering the text inside it.

Project Member Reported by ramy...@samsung.com, Aug 1 2017

Issue description

Chrome Version: 59.0.3071.125
OS: Android 6.0.1

What steps will reproduce the problem?
(1) Go to funded.co.kr/faq
(2) Select any text and find in page for same.
(3) Background rect does not fully encompass text, it overlaps with text.

What is the expected result?
Find in page background highlight rect is supposed to fully encompass text similar to selection rect.

What happens instead?
Background highlight rect overlaps with text boundaries.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
chrome59_FindInPage.png
264 KB View Download
Cc: dknandiraju@chromium.org
Labels: triage-te
1) Good Build: 53.0.2769.2
   Bad Build: 53.0.2770.0
2) Regression Range: https://chromium.googlesource.com/chromium/src/+log/53.0.2769.2..53.0.2770.0?pretty=fuller&n=10000
3) This issue exists on all devices
4) Unable to find exact culprit, as it is showing "not enough builds to bisect" when tried to bisect
5)  Please find logs and video @ http://go/chrome-androidlogs1/6/751041
Components: UI>Browser>FindInPage
Labels: -Pri-1 -triage-te M-62 Pri-2
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)
Looks like this is suspected CL: https://chromium.googlesource.com/chromium/src/+/c88a0a9547700d09f1a51dbbe825d967f266573a, 

If not Can you please help us in assigning this issue, Thanks!
Components: Blink>Editing>Selection
Owner: ----
Status: Untriaged (was: Assigned)
This would have nothing to do with my change. I'm adding Blink>Editing>Selection because they might be able to help with the text bounds of the find in page it seems incorrect.

Comment 6 by yosin@chromium.org, Sep 19 2017

Components: -UI>Browser>FindInPage -Blink>Editing>Selection Blink>Fonts
Owner: drott@chromium.org
Status: Assigned (was: Untriaged)
drott@, could you take look?

It seems this is font metrics issue in Android. One or two pixels of vertical bar 
at top overshoot marker and selection background painting.

I attached screenshot of windows. There are no overshoot for character "이".
cr751041.png
94.2 KB View Download

Comment 7 by drott@chromium.org, Sep 26 2017

Cc: kojii@chromium.org wkorman@chromium.org

Comment 8 by drott@chromium.org, Sep 26 2017

Not reproducible on Nexus 7 with Chrome Beta 62.0.3202.29. See attached picture.

ramya.v@, on which phone is this? Could you connect the phone in developer mode via USB, on desktop Chrome, go to chrome://inspect and run DevTools on the site, then inspect the element containing the FAQ answer, and look at the bottom of the Computed Style pane to see which font is used? (Compare my screenshot).

On the Nexus 7, NanumSquare is used and the selection looks okay. Perhaps this is issue with the font?

nanum_square_selection.png
598 KB View Download

Comment 9 by drott@chromium.org, Sep 26 2017

Sorry, NanumSquare is a web font, so it should be the same font, independent of device model. I'll try with Chrome stable and Canary.

Comment 10 by drott@chromium.org, Sep 26 2017

Sorry (2): The device I was using was not a Nexus 7, but a Nexus 6 phone. 

Not reproducible on Chrome 61.0.3163.98 stable on Android on Nexus 6.

Comment 11 by drott@chromium.org, Sep 26 2017

Labels: -Pri-2 Pri-3
If I remove the NanumSquare font-family CSS, the text gets rendered in Noto Sans CJK SC Regular and Roboto, and the selection still paints okay in 61.0.3163.98 stable.

Hi issue is on Galaxy Note 8 device, and issue is not with selection rect, it is painted correctly. Issue is with when we copy selected text and find in page the same text, find in page result rect is overlapping with text.

Sign in to add a comment