New issue
Advanced search Search tips

Issue 751031 link

Starred by 6 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 911614



Sign in to add a comment

OmniboxViewTest.* are flaky. Convert them to unit tests.

Project Member Reported by yutak@chromium.org, Aug 1 2017

Issue description

Examples:

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/514707
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/514700
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/502416

The assertion seems sticky across the tests, so there may be some global
value affecting the subsequent tests.

Sample crash log:

[ RUN      ] OmniboxViewTest.EscapeToDefaultMatch
[0731/215934.945:ERROR:always_on_top_window_killer_win.cc(67)] There is an always on top window on the desktop before running the test. This may have been caused by a previous test and may cause this test to fail, class-name=VMwareDragDetWndClass process_id=2008 thread_id=2012
[3944:7108:0731/215935.000:ERROR:direct_composition_surface_win.cc(1073)] Failing to detect HDR, couldn't retrieve D3D11 device from ANGLE.
[3944:7108:0731/215935.015:INFO:media_foundation_video_encode_accelerator_win.cc(335)] Windows versions earlier than 8 are not supported.
[3252:5608:0731/215935.996:FATAL:observer_list.h(276)] Check failed: false. Observers can only be added once!
Backtrace:
	base::debug::StackTrace::StackTrace [0x02BE5AD0+32]
	base::debug::StackTrace::StackTrace [0x02BC345D+13]
	logging::LogMessage::~LogMessage [0x02B48E1F+79]
	base::ObserverListBase<zoom::ZoomObserver>::AddObserver [0x03AEEF36+170]
	history::HistoryService::AddObserver [0x038360E3+101]
	OmniboxViewTest_AcceptKeywordBySpace_Test::RunTestOnMainThread [0x00FDA3FE+17694]
	OmniboxViewTest::SetupHistory [0x00FE5248+142]
	OmniboxViewTest::SetupComponents [0x00FE4E6B+285]
	OmniboxViewTest::SetUpOnMainThread [0x00FE4AEB+91]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x025085CE+238]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x02D89A78+3416]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x02D88CE1+289]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x015BFF2C+188]
	content::StartupTaskRunner::RunAllTasksNow [0x018A9F00+34]
	content::BrowserMainLoop::CreateStartupTasks [0x015BEBAA+738]
	content::BrowserMainRunnerImpl::Initialize [0x015C2104+724]
	content::BrowserMain [0x015BD02C+172]
	content::RunNamedProcessTypeMain [0x0248F7B6+146]
	content::ContentMainRunnerImpl::Run [0x0248FD4D+285]
	service_manager::Main [0x0372F1F7+675]
	content::ContentMain [0x0248F6CD+49]
	content::BrowserTestBase::SetUp [0x0250840E+1182]
	InProcessBrowserTest::SetUp [0x024A040E+334]
	testing::Test::Run [0x01090C5B+113]
	testing::TestInfo::Run [0x0109139F+213]
	testing::TestCase::Run [0x0109172E+246]
	testing::internal::UnitTestImpl::RunAllTests [0x010953BA+602]
	testing::UnitTest::Run [0x01095086+178]
	base::TestSuite::Run [0x02B3E0E5+113]
	InteractiveUITestSuiteRunner::RunTestSuite [0x01002099+57]
	content::LaunchTests [0x0250614D+361]
	LaunchChromeTests [0x0249CDCE+77]
	main [0x0100202A+81]
	__scrt_common_main_seh [0x05F8584B+249] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x7637337A+18]
	RtlInitializeExceptionChain [0x77A292B2+99]
	RtlInitializeExceptionChain [0x77A29285+54]

 

Comment 1 by yutak@chromium.org, Aug 1 2017

Stack trace on Linux may be easier to interpret:

[ RUN      ] OmniboxViewTest.Escape
Xlib:  extension "RANDR" missing on display ":99".
[17610:17610:0801/001135.619909:WARNING:password_store_factory.cc(255)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[17610:17610:0801/001135.760754:FATAL:observer_list.h(276)] Check failed: false. Observers can only be added once!
#0 0x000002ce3cc7 base::debug::StackTrace::StackTrace()
#1 0x000002cfd491 logging::LogMessage::~LogMessage()
#2 0x000000748b05 base::ObserverListBase<>::AddObserver()
#3 0x000003d617fc history::HistoryService::AddObserver()
#4 0x000000526a87 OmniboxViewTest::AddHistoryEntry()
#5 0x000000537806 OmniboxViewTest::SetupHistory()
#6 0x000000537267 OmniboxViewTest::SetupComponents()
#7 0x000000535a7d OmniboxViewTest::SetUpOnMainThread()
#8 0x0000024cf0ac content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#9 0x00000239d20d ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#10 0x00000239bf5a ChromeBrowserMainParts::PreMainMessageLoopRun()
#11 0x000000d7e9ed content::BrowserMainLoop::PreMainMessageLoopRun()
#12 0x00000117a537 content::StartupTaskRunner::RunAllTasksNow()
#13 0x000000d7cc2e content::BrowserMainLoop::CreateStartupTasks()
#14 0x000000d8196e content::BrowserMainRunnerImpl::Initialize()
#15 0x000000d79fe2 content::BrowserMain()
#16 0x00000208a55c content::RunNamedProcessTypeMain()
#17 0x00000208aec8 content::ContentMainRunnerImpl::Run()
#18 0x000003b3b8b6 service_manager::Main()
#19 0x000002089972 content::ContentMain()
#20 0x0000024ced57 content::BrowserTestBase::SetUp()
#21 0x0000020a1752 InProcessBrowserTest::SetUp()
#22 0x0000006885ee testing::Test::Run()
#23 0x000000689110 testing::TestInfo::Run()
#24 0x0000006895f7 testing::TestCase::Run()
#25 0x00000068fa67 testing::internal::UnitTestImpl::RunAllTests()
#26 0x00000068f6f3 testing::UnitTest::Run()
#27 0x000002cd0454 base::TestSuite::Run()
#28 0x00000055b47c InteractiveUITestSuiteRunner::RunTestSuite()
#29 0x0000024d540d content::LaunchTests()
#30 0x00000055b3f8 main
#31 0x7fd9da460f45 __libc_start_main
#32 0x00000044bff0 <unknown>

[192/530] OmniboxViewTest.Escape (527 ms)

Comment 2 by yutak@chromium.org, Aug 1 2017

Cc: tzik@chromium.org
Owner: yutak@chromium.org
Status: Started (was: Available)
I think this is because the following content::RunAllPendingInMessageLoop()
no longer consumes the tasks in task scheduler:

https://cs.chromium.org/chromium/src/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc?q=OmniboxViewTest&sq=package:chromium&dr=CSs&l=337

This should be replaced with TaskScheduler::FlushForTesting(). Let me write
a CL for this.

Comment 3 by yutak@chromium.org, Aug 1 2017

I wrote a patch, but it may be incorrect (since I saw the same assertion error
with patch set 1). Hmm...?

https://chromium-review.googlesource.com/c/595667/

Comment 4 by yutak@chromium.org, Aug 1 2017

Owner: ----
Seems like the CL above doesn't work. I don't have time today, so I'm releasing
ownership for now.

Perhaps we should disable all OmniboxViewTest.* tests to deflake...?

Comment 5 by yutak@chromium.org, Aug 1 2017

Status: Available (was: Started)
To me it looks like some race condition.

Agreed, we should disable. It flakes on multiple platforms so I'll disable it completely.
Sorry, did not get to it so far (and I am leaving now). It looks like all OmniboxViewTest.* tests that are currently run on linux are flaky on tryserver.chromium.linux:linux_chromium_rel_ng.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&builder=tryserver.chromium.linux%3Alinux_chromium_rel_ng

Other builders are not affected (at least not as often).
 Issue 751140  has been merged into this issue.

Comment 9 by carl...@google.com, Aug 1 2017

Cc: hirosh...@chromium.org adithyas@chromium.org
CC-ing all current sheriffs as this is affecting CQ bots.
Patch to disable OmniboxViewTest.*: https://chromium-review.googlesource.com/c/596927
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dfd08c8d04a3d400cf1db7dd607d48f22cf30ee

commit 1dfd08c8d04a3d400cf1db7dd607d48f22cf30ee
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Tue Aug 01 22:32:58 2017

Disable OmniboxViewTests.*

The OmniboxViewTests are currently flaky, see the associated issue for
more details.

TBR=jdonelly@chromium.org

Bug: 751031
Change-Id: I051f5ad400b4ab729c45e7b2c77365d1dba45356
Reviewed-on: https://chromium-review.googlesource.com/596927
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491133}
[modify] https://crrev.com/1dfd08c8d04a3d400cf1db7dd607d48f22cf30ee/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Comment 12 by horo@chromium.org, Aug 2 2017

 Issue 751294  has been merged into this issue.

Comment 13 by horo@chromium.org, Aug 2 2017

 Issue 751293  has been merged into this issue.

Comment 14 by horo@chromium.org, Aug 2 2017

 Issue 751292  has been merged into this issue.

Comment 15 by horo@chromium.org, Aug 2 2017

 Issue 751291  has been merged into this issue.

Comment 16 by horo@chromium.org, Aug 2 2017

 Issue 751290  has been merged into this issue.

Comment 17 by horo@chromium.org, Aug 2 2017

 Issue 751289  has been merged into this issue.

Comment 18 by horo@chromium.org, Aug 2 2017

 Issue 751281  has been merged into this issue.
Components: Tests>Disabled
For the record, looking at those merged-in bugs, it appears that something must've happened on 2017-07-28 or (more likely) 2017-08-01 that suddenly make all these tests become much more flaky than they used to be.  Whoever is investigating this should probably look through the changes submitted around that time for a possible cause.
Status: Untriaged (was: Available)
I'm gonna mark this untriaged so omnibox triage picks it up and assigns someone.  This is the sort of regression that will likely be harder to track down later, and when we already have a goal of making the omnibox better-tested, it would be sad to lose all these tests.

Note that there's a lot of TaskScheduler conversion work landing.  Maybe moving some subsystem (history?) from a thread to the TaskScheduler caused this.

Also see https://chromium-review.googlesource.com/c/595667 where yutak took a stab at a solution and I had some comments.

Comment 21 by horo@chromium.org, Aug 2 2017

Labels: -Sheriff-Chromium
Labels: -Pri-1 Pri-2
Owner: yutak@chromium.org
Status: Started (was: Untriaged)
The revised patch set may fix this issue; I'm dry-running it now.

https://chromium-review.googlesource.com/c/595667

Reducing the priority since the tests are now disabled.
 Issue 751543  has been merged into this issue.

Comment 24 by yutak@chromium.org, Nov 14 2017

Owner: ----
Status: Available (was: Started)
Actually I wasn't able to fix this. Releasing the ownership...
Project Member

Comment 25 by chromium...@appspot.gserviceaccount.com, Dec 4 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "OmniboxViewTest.NonSubstitutingKeywordTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipPbW5pYm94Vmlld1Rlc3QuTm9uU3Vic3RpdHV0aW5nS2V5d29yZFRlc3QM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 26 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1ccd58125c75660a7790724ea5faed78a055d0c

commit e1ccd58125c75660a7790724ea5faed78a055d0c
Author: Greg Thompson <grt@chromium.org>
Date: Mon Dec 04 19:49:53 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 133341 ,751031, 751543 , 764415 , 789913 
This CL was uploaded by git cl split.

R=sky@chromium.org

Change-Id: I753c741a9194f489f072cd86d72407a1294150c3
Reviewed-on: https://chromium-review.googlesource.com/784937
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521416}
[modify] https://crrev.com/e1ccd58125c75660a7790724ea5faed78a055d0c/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Project Member

Comment 27 by chromium...@appspot.gserviceaccount.com, Dec 5 2017

Detected 3 new flakes for test/step "OmniboxViewTest.AcceptKeywordBySpace". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRPbW5pYm94Vmlld1Rlc3QuQWNjZXB0S2V5d29yZEJ5U3BhY2UM. This message was posted automatically by the chromium-try-flakes app.

Comment 28 by grt@chromium.org, Dec 5 2017

 Issue 791935  has been merged into this issue.

Comment 29 by grt@chromium.org, Dec 5 2017

I will re-disable these on Windows since they're still failing with the same stack as in the original report:

[5880:4296:1204/125235.019:FATAL:observer_list.h(222)] Check failed: false. Observers can only be added once!
Backtrace:
	base::debug::StackTrace::StackTrace [0x023AA7F0+32]
	base::debug::StackTrace::StackTrace [0x02381E7D+13]
	logging::LogMessage::~LogMessage [0x023087DE+78]
	base::ObserverList<zoom::ZoomObserver,0>::AddObserver [0x03722E12+172]
	history::HistoryService::AddObserver [0x03029A03+101]
	OmniboxViewTest_AcceptKeywordBySpace_Test::RunTestOnMainThread [0x0035F1C2+17570]
	OmniboxViewTest::SetupHistory [0x00369DFA+124]
	OmniboxViewTest::SetupComponents [0x00369A4B+285]
	OmniboxViewTest::SetUpOnMainThread [0x003696CB+91]

Comment 30 by grt@chromium.org, Dec 5 2017

 Issue 791856  has been merged into this issue.
Project Member

Comment 31 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16ac914c0806c5885ef112f621b5ae62d13fdbf3

commit 16ac914c0806c5885ef112f621b5ae62d13fdbf3
Author: Greg Thompson <grt@chromium.org>
Date: Tue Dec 05 10:24:50 2017

Revert "Enable interactive_ui_tests on Windows that now run mostly reliably."

This reverts commit e1ccd58125c75660a7790724ea5faed78a055d0c.

Reason for revert: Widespread "Check failed: false. Observers can only be added once!" failures.

Original change's description:
> Enable interactive_ui_tests on Windows that now run mostly reliably.
> 
> r516772 was the last of many commits that resolved a number of problems
> that made this test suite flaky on Windows. This CL enables tests that
> had been disabled over time due to flakes, yet now seem to run okay.
> 
> BUG= 133341 ,751031, 751543 , 764415 , 789913 
> This CL was uploaded by git cl split.
> 
> R=​sky@chromium.org
> 
> Change-Id: I753c741a9194f489f072cd86d72407a1294150c3
> Reviewed-on: https://chromium-review.googlesource.com/784937
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521416}

TBR=sky@chromium.org,grt@chromium.org

Change-Id: I33b192c628fdfebe9cfd93b71abd3b394faad9e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  133341 , 751031,  751543 ,  764415 ,  789913 
Reviewed-on: https://chromium-review.googlesource.com/808204
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521652}
[modify] https://crrev.com/16ac914c0806c5885ef112f621b5ae62d13fdbf3/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Comment 32 by grt@chromium.org, Dec 5 2017

Labels: -Sheriff-Chromium
 Issue 792165  has been merged into this issue.
 Issue 792122  has been merged into this issue.
Project Member

Comment 35 by chromium...@appspot.gserviceaccount.com, Dec 7 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "OmniboxViewTest.NonSubstitutingKeywordTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipPbW5pYm94Vmlld1Rlc3QuTm9uU3Vic3RpdHV0aW5nS2V5d29yZFRlc3QM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -OS-All -Sheriff-Chromium OS-Windows
Owner: jdonnelly@chromium.org
Status: Assigned (was: Available)
I'll disable this test.  Removing from the sheriff queue.

Justin, can we find an owner here?  I think the fix might not actually be too hard; see my comments in https://chromium-review.googlesource.com/c/chromium/src/+/595667/8/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc#334 .
Project Member

Comment 37 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6268e018c22b60b2634767fac7e3f813786c174

commit d6268e018c22b60b2634767fac7e3f813786c174
Author: Peter Kasting <pkasting@chromium.org>
Date: Thu Dec 07 23:30:12 2017

Disable flaky test.

Bug: 751031
Change-Id: If5abb5ab23317faf48eda77bf6d0ae7e770304c0
TBR: jdonnelly
Reviewed-on: https://chromium-review.googlesource.com/815279
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522608}
[modify] https://crrev.com/d6268e018c22b60b2634767fac7e3f813786c174/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Cc: jdonnelly@chromium.org
Owner: tommycli@chromium.org
tommycli: would you mind taking a look at this when you get a chance? pkasting says it will be easy :) see comment 36.
s/will/might/
Will do thanks!
Hi,

Is there some trick to running these tests properly on Linux? After re-enabling them by reverting the CL in c#11, I'm getting all these failures that seem unrelated to the flaked out runs (not crashes from duplicate observers):

tommycli@tommycli:~/src/chromium/src$ ninja-goma-release interactive_ui_tests && out/rel/interactive_ui_tests --gtest_filter=OmniboxViewTest* --enable-pixel-output-in-tests
ninja: Entering directory `out/rel'
ninja: no work to do.
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = OmniboxViewTest.ClearUserTextAfterBackgroundCommit
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.ClearUserTextAfterBackgroundCommit
[11822:11822:1213/144855.552759:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[11911:11911:1213/144857.370511:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
[11911:11911:1213/144859.468531:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[11911:11911:1213/144859.468628:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[11911:11911:1213/144859.468669:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[11911:11911:1213/144859.468704:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[11911:11911:1213/144859.468750:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[11911:11911:1213/144859.468774:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[11822:11822:1213/144859.496969:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[11822:11822:1213/144859.546914:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[       OK ] OmniboxViewTest.ClearUserTextAfterBackgroundCommit (5144 ms)
[----------] 1 test from OmniboxViewTest (5144 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (5144 ms total)
[  PASSED  ] 1 test.
[1/20] OmniboxViewTest.ClearUserTextAfterBackgroundCommit (5766 ms)
Note: Google Test filter = OmniboxViewTest.AltEnter
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.AltEnter
[11984:11984:1213/144901.287725:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[11984:11984:1213/144902.771565:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[11984:12015:1213/144902.795212:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[11984:11984:1213/144902.806189:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[       OK ] OmniboxViewTest.AltEnter (2650 ms)
[----------] 1 test from OmniboxViewTest (2650 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2650 ms total)
[  PASSED  ] 1 test.
[2/20] OmniboxViewTest.AltEnter (3144 ms)
Note: Google Test filter = OmniboxViewTest.EscapeToDefaultMatch
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.EscapeToDefaultMatch
[12085:12085:1213/144904.360741:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:798: Failure
Expected: (old_selected_line) != (popup_model->selected_line()), actual: 0 vs 0
[12085:12085:1213/144905.629734:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12085:12131:1213/144905.659849:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[12085:12085:1213/144905.672777:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.EscapeToDefaultMatch, where TypeParam =  and GetParam() =  (2388 ms)
[----------] 1 test from OmniboxViewTest (2388 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2388 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.EscapeToDefaultMatch, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[1213/144905.752210:ERROR:kill_posix.cc(84)] Unable to terminate process group 12085: No such process (3)
[3/20] OmniboxViewTest.EscapeToDefaultMatch (2881 ms)
Note: Google Test filter = OmniboxViewTest.BasicTextOperations
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.BasicTextOperations
[12178:12178:1213/144907.193454:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[12242:12242:1213/144908.762454:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:838: Failure
Value of: omnibox_view->IsSelectAll()
  Actual: true
Expected: false
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:843: Failure
Expected equality of these values:
  old_text.size()
    Which is: 11
  end
    Which is: 0
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:851: Failure
Expected equality of these values:
  old_text
    Which is: about:blank
  omnibox_view->GetText()
    Which is: about:blanka
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:861: Failure
Expected equality of these values:
  old_text.size()
    Which is: 11
  end
    Which is: 12
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:881: Failure
Expected equality of these values:
  3U
    Which is: 3
  start
    Which is: 0
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:882: Failure
Expected equality of these values:
  3U
    Which is: 3
  end
    Which is: 0
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:898: Failure
Expected equality of these values:
  11U
    Which is: 11
  start
    Which is: 0
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:899: Failure
Expected equality of these values:
  11U
    Which is: 11
  end
    Which is: 0
[12178:12178:1213/144909.546595:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12178:12178:1213/144909.584921:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.BasicTextOperations, where TypeParam =  and GetParam() =  (3387 ms)
[----------] 1 test from OmniboxViewTest (3387 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (3388 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.BasicTextOperations, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[1213/144909.682268:ERROR:kill_posix.cc(84)] Unable to terminate process group 12178: No such process (3)
[4/20] OmniboxViewTest.BasicTextOperations (3929 ms)
Note: Google Test filter = OmniboxViewTest.FocusSearchLongUrl
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.FocusSearchLongUrl
[12287:12287:1213/144911.196965:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[12351:12351:1213/144912.699065:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
[12287:12287:1213/144913.373945:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12287:12287:1213/144913.409516:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[       OK ] OmniboxViewTest.FocusSearchLongUrl (3262 ms)
[----------] 1 test from OmniboxViewTest (3262 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (3262 ms total)
[  PASSED  ] 1 test.
[5/20] OmniboxViewTest.FocusSearchLongUrl (3930 ms)
Note: Google Test filter = OmniboxViewTest.PreserveDisplayTextOnFocusSearch
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.PreserveDisplayTextOnFocusSearch
[12391:12391:1213/144915.187675:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:948: Failure
Expected equality of these values:
  base::string16()
    Which is: 
  omnibox_view->GetText()
    Which is: site.com/path/1
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:951: Failure
Expected equality of these values:
  0U
    Which is: 0
  end
    Which is: 15
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:266: Failure
Value of: controller->done()
  Actual: false
Expected: true
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:956: Failure
Expected: WaitForAutocompleteControllerDone() doesn't generate new fatal failures in the current thread.
  Actual: it does.
[12391:12391:1213/144916.414783:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12391:12423:1213/144916.442035:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[12391:12391:1213/144916.456082:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.PreserveDisplayTextOnFocusSearch, where TypeParam =  and GetParam() =  (2371 ms)
[----------] 1 test from OmniboxViewTest (2371 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2371 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.PreserveDisplayTextOnFocusSearch, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[1213/144916.495359:ERROR:kill_posix.cc(84)] Unable to terminate process group 12391: No such process (3)
[6/20] OmniboxViewTest.PreserveDisplayTextOnFocusSearch (2882 ms)
Note: Google Test filter = OmniboxViewTest.AcceptKeywordByTypingQuestionMark
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.AcceptKeywordByTypingQuestionMark
[12469:12469:1213/144918.036253:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:981: Failure
Value of: omnibox_view->model()->is_keyword_selected()
  Actual: false
Expected: true
[12469:12469:1213/144919.286978:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12469:12501:1213/144919.317335:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[12469:12469:1213/144919.347519:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.AcceptKeywordByTypingQuestionMark, where TypeParam =  and GetParam() =  (2423 ms)
[----------] 1 test from OmniboxViewTest (2423 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2423 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.AcceptKeywordByTypingQuestionMark, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[1213/144919.376889:ERROR:kill_posix.cc(84)] Unable to terminate process group 12469: No such process (3)
[7/20] OmniboxViewTest.AcceptKeywordByTypingQuestionMark (2881 ms)
Note: Google Test filter = OmniboxViewTest.NonSubstitutingKeywordTest
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.NonSubstitutingKeywordTest
[12545:12545:1213/144920.941277:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1252: Failure
Expected equality of these values:
  AutocompleteMatchType::HISTORY_KEYWORD
    Which is: 4
  popup_model->result().default_match()->type
    Which is: 6
[12545:12545:1213/144922.462695:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12545:12575:1213/144922.485391:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[12545:12545:1213/144922.503237:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.NonSubstitutingKeywordTest, where TypeParam =  and GetParam() =  (2681 ms)
[----------] 1 test from OmniboxViewTest (2681 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2681 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.NonSubstitutingKeywordTest, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[8/20] OmniboxViewTest.NonSubstitutingKeywordTest (3142 ms)
Note: Google Test filter = OmniboxViewTest.DeleteItem
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.DeleteItem
[12627:12627:1213/144923.983770:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[12691:12691:1213/144925.693670:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
[12627:12650:1213/144926.147153:WARNING:simple_synchronous_entry.cc(1170)] Could not open platform files for entry.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1287: Failure
Expected equality of these values:
  ASCIIToUTF16("site.com/p")
    Which is: site.com/p
  user_text
    Which is: site.com/path/1
[12627:12627:1213/144926.246425:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12627:12627:1213/144926.284583:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.DeleteItem, where TypeParam =  and GetParam() =  (3365 ms)
[----------] 1 test from OmniboxViewTest (3365 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (3366 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.DeleteItem, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[1213/144926.449764:ERROR:kill_posix.cc(84)] Unable to terminate process group 12627: No such process (3)
[9/20] OmniboxViewTest.DeleteItem (3929 ms)
Note: Google Test filter = OmniboxViewTest.UndoRedo
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.UndoRedo
[12732:12732:1213/144927.992456:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[12795:12795:1213/144929.543069:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1595: Failure
Value of: omnibox_view->GetText().empty()
  Actual: false
Expected: true
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1619: Failure
Expected equality of these values:
  old_text.size()
    Which is: 11
  start
    Which is: 0
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1620: Failure
Expected equality of these values:
  old_text.size()
    Which is: 11
  end
    Which is: 0
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1626: Failure
Expected equality of these values:
  old_text.substr(0, old_text.size() - 3)
    Which is: about:bl
  omnibox_view->GetText()
    Which is: about:blan
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1630: Failure
Expected equality of these values:
  old_text
    Which is: about:blank
  omnibox_view->GetText()
    Which is: about:blan
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1640: Failure
Value of: omnibox_view->GetText().empty()
  Actual: false
Expected: true
[12732:12732:1213/144930.193010:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12732:12732:1213/144930.232466:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.UndoRedo, where TypeParam =  and GetParam() =  (3331 ms)
[----------] 1 test from OmniboxViewTest (3331 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (3331 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.UndoRedo, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[1213/144930.379958:ERROR:kill_posix.cc(84)] Unable to terminate process group 12732: No such process (3)
[10/20] OmniboxViewTest.UndoRedo (3930 ms)
Note: Google Test filter = OmniboxViewTest.BackspaceDeleteHalfWidthKatakana
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.BackspaceDeleteHalfWidthKatakana
[12836:12836:1213/144931.938664:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[12901:12901:1213/144933.517282:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1673: Failure
Expected equality of these values:
  base::UTF8ToUTF16("\357\276\200")
    Which is: ï¾€
  omnibox_view->GetText()
    Which is: ダ
[12836:12836:1213/144933.976137:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12836:12836:1213/144934.010826:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.BackspaceDeleteHalfWidthKatakana, where TypeParam =  and GetParam() =  (3189 ms)
[----------] 1 test from OmniboxViewTest (3189 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (3189 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.BackspaceDeleteHalfWidthKatakana, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[1213/144934.048943:ERROR:kill_posix.cc(84)] Unable to terminate process group 12836: No such process (3)
[11/20] OmniboxViewTest.BackspaceDeleteHalfWidthKatakana (3668 ms)
Note: Google Test filter = OmniboxViewTest.DoesNotUpdateAutocompleteOnBlur
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.DoesNotUpdateAutocompleteOnBlur
[12924:12924:1213/144935.573543:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1698: Failure
Expected equality of these values:
  old_autocomplete_text
    Which is: de
  omnibox_view->model()->autocomplete_controller()->input_.text()
    Which is: def
[12924:12924:1213/144937.050973:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12924:12954:1213/144937.075241:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[12924:12924:1213/144937.084427:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.DoesNotUpdateAutocompleteOnBlur, where TypeParam =  and GetParam() =  (2611 ms)
[----------] 1 test from OmniboxViewTest (2611 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2611 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.DoesNotUpdateAutocompleteOnBlur, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[1213/144937.192124:ERROR:kill_posix.cc(84)] Unable to terminate process group 12924: No such process (3)
[12/20] OmniboxViewTest.DoesNotUpdateAutocompleteOnBlur (3143 ms)
Note: Google Test filter = OmniboxViewTest.Paste
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.Paste
[12999:12999:1213/144938.728479:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[12999:12999:1213/144940.103505:ERROR:selection_owner.cc(178)] SelectionClear
[12999:12999:1213/144940.106400:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[12999:13029:1213/144940.124981:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[12999:12999:1213/144940.143510:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[       OK ] OmniboxViewTest.Paste (2504 ms)
[----------] 1 test from OmniboxViewTest (2504 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2504 ms total)
[  PASSED  ] 1 test.
[13/20] OmniboxViewTest.Paste (3143 ms)
Note: Google Test filter = OmniboxViewTest.CopyURLToClipboard
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.CopyURLToClipboard
[13074:13074:1213/144941.926145:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[13074:13074:1213/144943.193609:ERROR:selection_owner.cc(178)] SelectionClear
[13074:13074:1213/144943.196372:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[13074:13104:1213/144943.224978:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[13074:13074:1213/144943.241464:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[       OK ] OmniboxViewTest.CopyURLToClipboard (2470 ms)
[----------] 1 test from OmniboxViewTest (2470 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2470 ms total)
[  PASSED  ] 1 test.
[14/20] OmniboxViewTest.CopyURLToClipboard (3144 ms)
Note: Google Test filter = OmniboxViewTest.CutURLToClipboard
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.CutURLToClipboard
[13150:13150:1213/144944.917785:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[13150:13150:1213/144946.377739:ERROR:selection_owner.cc(178)] SelectionClear
[13150:13150:1213/144946.381002:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[13150:13180:1213/144946.411392:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[13150:13150:1213/144946.437192:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[       OK ] OmniboxViewTest.CutURLToClipboard (2552 ms)
[----------] 1 test from OmniboxViewTest (2552 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2552 ms total)
[  PASSED  ] 1 test.
[15/20] OmniboxViewTest.CutURLToClipboard (3144 ms)
Note: Google Test filter = OmniboxViewTest.CopyTextToClipboard
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.CopyTextToClipboard
[13225:13225:1213/144948.215576:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[13225:13225:1213/144949.570210:ERROR:selection_owner.cc(178)] SelectionClear
[13225:13225:1213/144949.573421:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[13225:13255:1213/144949.591786:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[13225:13225:1213/144949.605389:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[       OK ] OmniboxViewTest.CopyTextToClipboard (2540 ms)
[----------] 1 test from OmniboxViewTest (2540 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2541 ms total)
[  PASSED  ] 1 test.
[16/20] OmniboxViewTest.CopyTextToClipboard (3143 ms)
Note: Google Test filter = OmniboxViewTest.CutTextToClipboard
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.CutTextToClipboard
[13301:13301:1213/144951.355547:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[13301:13301:1213/144953.014274:ERROR:selection_owner.cc(178)] SelectionClear
[13301:13301:1213/144953.016920:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[13301:13331:1213/144953.038295:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[13301:13301:1213/144953.050424:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[       OK ] OmniboxViewTest.CutTextToClipboard (2821 ms)
[----------] 1 test from OmniboxViewTest (2821 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2821 ms total)
[  PASSED  ] 1 test.
[17/20] OmniboxViewTest.CutTextToClipboard (3406 ms)
Note: Google Test filter = OmniboxViewTest.EditSearchEngines
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.EditSearchEngines
[13384:13384:1213/144954.737035:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[13384:13384:1213/144956.022693:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[13384:13414:1213/144956.074137:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[13384:13403:1213/144956.103513:WARNING:sqlite_persistent_cookie_store.cc(1371)] Failed to post task from FinishedLoadingCookies@../../net/extras/sqlite/sqlite_persistent_cookie_store.cc:1379 to client_task_runner_.
[13384:13384:1213/144956.135404:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[       OK ] OmniboxViewTest.EditSearchEngines (2537 ms)
[----------] 1 test from OmniboxViewTest (2537 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2537 ms total)
[  PASSED  ] 1 test.
[18/20] OmniboxViewTest.EditSearchEngines (3142 ms)
Note: Google Test filter = OmniboxViewTest.CtrlArrowAfterArrowSuggestions
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.CtrlArrowAfterArrowSuggestions
[13471:13471:1213/144957.883452:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1908: Failure
Value of: popup_model->IsOpen()
  Actual: false
Expected: true
[13471:13471:1213/144959.147690:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[13471:13501:1213/144959.173483:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[13471:13471:1213/144959.185018:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.CtrlArrowAfterArrowSuggestions, where TypeParam =  and GetParam() =  (2455 ms)
[----------] 1 test from OmniboxViewTest (2455 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2455 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.CtrlArrowAfterArrowSuggestions, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[1213/144959.461294:ERROR:kill_posix.cc(84)] Unable to terminate process group 13471: No such process (3)
[19/20] OmniboxViewTest.CtrlArrowAfterArrowSuggestions (3144 ms)
Note: Google Test filter = OmniboxViewTest.SelectAllStaysAfterUpdate
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from OmniboxViewTest, where TypeParam = 
[ RUN      ] OmniboxViewTest.SelectAllStaysAfterUpdate
[13545:13545:1213/145000.921992:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1982: Failure
Expected equality of these values:
  2u
    Which is: 2
  GetSelectionSize(omnibox_view)
    Which is: 1
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1983: Failure
Value of: omnibox_view->IsSelectAll()
  Actual: false
Expected: true
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1995: Failure
Expected equality of these values:
  1u
    Which is: 1
  GetSelectionSize(omnibox_view)
    Which is: 2
../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:2013: Failure
Expected equality of these values:
  1u
    Which is: 1
  GetSelectionSize(omnibox_view)
    Which is: 2
[13545:13545:1213/145002.223351:INFO:chrome_cryptauth_service.cc(233)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[13545:13576:1213/145002.240795:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[13545:13545:1213/145002.267736:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] OmniboxViewTest.SelectAllStaysAfterUpdate, where TypeParam =  and GetParam() =  (2354 ms)
[----------] 1 test from OmniboxViewTest (2355 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2355 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] OmniboxViewTest.SelectAllStaysAfterUpdate, where TypeParam =  and GetParam() = 

 1 FAILED TEST
[1213/145002.343408:ERROR:kill_posix.cc(84)] Unable to terminate process group 13545: No such process (3)
[20/20] OmniboxViewTest.SelectAllStaysAfterUpdate (2882 ms)
11 tests failed:
    OmniboxViewTest.AcceptKeywordByTypingQuestionMark (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:971)
    OmniboxViewTest.BackspaceDeleteHalfWidthKatakana (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1651)
    OmniboxViewTest.BasicTextOperations (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:811)
    OmniboxViewTest.CtrlArrowAfterArrowSuggestions (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1896)
    OmniboxViewTest.DeleteItem (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1257)
    OmniboxViewTest.DoesNotUpdateAutocompleteOnBlur (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1677)
    OmniboxViewTest.EscapeToDefaultMatch (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:775)
    OmniboxViewTest.NonSubstitutingKeywordTest (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1206)
    OmniboxViewTest.PreserveDisplayTextOnFocusSearch (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:919)
    OmniboxViewTest.SelectAllStaysAfterUpdate (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1946)
    OmniboxViewTest.UndoRedo (../../chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1582)

I don't know.  Do they fail on Windows?  If so then this is perhaps some kind of recent regression.  In either case you'd have to track down what these failures actually mean, i.e. what the tests are testing.
Alrighty thanks. I'm building and trying to repro on Windows now.
yutak: Hey, I saw you were making progress on on your CL [1] towards fixing this issue, but c#24, you said it didn't work.

Do you mind telling me what you tried that didn't work? I'm taking an approach similar to what you're doing in [1], and also removing the observer_ member...

I'm just trying to see what pitfalls you experienced that I may be missing. 

Thanks!

[1] https://chromium-review.googlesource.com/c/chromium/src/+/595667/8/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
Project Member

Comment 45 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13928ea2ecb93a84a45bc22a10fa472981140618

commit 13928ea2ecb93a84a45bc22a10fa472981140618
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Dec 15 22:14:22 2017

Omnibox: Re-enable OmniboxViewTest.* and fix a duplicate observer crash

Previously, there was a duplicate observer that was (apparently?) okay
because spinning the current message loop was enough to load th
history backend.

The TaskScheduler migration requires us to make a different call to
ensure that the history backend is loaded.

This CL also removes the member observer, because running the
TaskScheduler until idle should be sufficient to assert that the
history backend has been loaded.

Bug: 751031
Change-Id: Iecacecddc3a50be3d54be64fe520fad757aa0275
Reviewed-on: https://chromium-review.googlesource.com/825642
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524484}
[modify] https://crrev.com/13928ea2ecb93a84a45bc22a10fa472981140618/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Monitoring https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=OmniboxViewTest.*, looking green to me. I'll proceed with some further cleanups.
Project Member

Comment 47 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a13107726141208657840a1df9ee2666dd3280e2

commit a13107726141208657840a1df9ee2666dd3280e2
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed Dec 20 21:59:09 2017

Omnibox: OmniboxViewTest.* TLC - Remove HistoryServiceObserver.

After migrating to TaskScheduler, we can simplify the mechanism that
synchronizes the HistoryService with the test.

Bug: 751031
Change-Id: Ib91039959b6c83afe0f0ad87942f50c3f73d41a7
Reviewed-on: https://chromium-review.googlesource.com/837700
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525481}
[modify] https://crrev.com/a13107726141208657840a1df9ee2666dd3280e2/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Comment 48 by kbr@chromium.org, Jan 5 2018

Labels: -Pri-2 Pri-1
These tests are still flaky. See the following recent failures on win7_chromium_rel_ng:

OmniboxViewTest.SelectAllStaysAfterUpdate
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/74248
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/74390

OmniboxApiTest.DeleteOmniboxSuggestionResult
OmniboxViewTest.DeleteItem
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/74325

and probably others.

This is causing valid CQ jobs to fail. Please investigate immediately and consider re-disabling these tests until they're de-flaked.

Comment 49 by kbr@chromium.org, Jan 5 2018

For the record: this failure:

https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/74325

in which these interactive_ui_tests failed:

OmniboxApiTest.DeleteOmniboxSuggestionResult
OmniboxViewTest.DeleteItem
FindInPageTest.SelectionRestoreOnTabSwitch

was for this completely unrelated CL:

https://chromium-review.googlesource.com/851084

I'm trying to figure out why https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests%20(with%20patch)&tests=OmniboxViewTest* , which lists the Windows tryservers, does not report the failures above...
Cc: -hirosh...@chromium.org
Components: Tests>Disabled
Labels: Test-Disabled
Labels: Hotlist-DisableReview
Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "OmniboxViewTest.PreserveDisplayTextOnFocusSearch". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOwsSBUZsYWtlIjBPbW5pYm94Vmlld1Rlc3QuUHJlc2VydmVEaXNwbGF5VGV4dE9uRm9jdXNTZWFyY2gM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
New flakes seem to be a separate issue:

WARNING: ThreadSanitizer: data race (pid=16882)
  Write of size 4 at 0x0000112c10f0 by thread T25 (mutexes: write M707763382921517664):
    #0 pcache1FreePage third_party/sqlite/amalgamation/sqlite3.c:48194:25 (interactive_ui_tests+0x9c88727)
    #1 pcache1TruncateUnsafe third_party/sqlite/amalgamation/sqlite3.c:48388 (interactive_ui_tests+0x9c88727)
    #2 pcache1Truncate third_party/sqlite/amalgamation/sqlite3.c:48864 (interactive_ui_tests+0x9c88727)
    #3 sqlite3PcacheTruncate third_party/sqlite/amalgamation/sqlite3.c:47517:5 (interactive_ui_tests+0x9b288ca)
    #4 sqlite3PcacheClear third_party/sqlite/amalgamation/sqlite3.c:47534 (interactive_ui_tests+0x9b288ca)
    #5 pager_reset third_party/sqlite/amalgamation/sqlite3.c:51403 (interactive_ui_tests+0x9b288ca)
    #6 sqlite3PagerClose third_party/sqlite/amalgamation/sqlite3.c:53806:3 (interactive_ui_tests+0x9b1ab2c)
    #7 sqlite3BtreeClose third_party/sqlite/amalgamation/sqlite3.c:64795:5 (interactive_ui_tests+0x9b3b206)
    #8 sqlite3VdbeFreeCursor third_party/sqlite/amalgamation/sqlite3.c:77157:25 (interactive_ui_tests+0x9b3b126)
    #9 closeCursorsInFrame third_party/sqlite/amalgamation/sqlite3.c:77188:9 (interactive_ui_tests+0x9b37fc0)
    #10 closeAllCursors third_party/sqlite/amalgamation/sqlite3.c:77238 (interactive_ui_tests+0x9b37fc0)
    #11 sqlite3VdbeHalt third_party/sqlite/amalgamation/sqlite3.c:77725 (interactive_ui_tests+0x9b37fc0)
    #12 sqlite3VdbeExec third_party/sqlite/amalgamation/sqlite3.c:83072:8 (interactive_ui_tests+0x9b599e3)
    #13 sqlite3Step third_party/sqlite/amalgamation/sqlite3.c:80449:10 (interactive_ui_tests+0x9afc5ba)
    #14 chrome_sqlite3_step third_party/sqlite/amalgamation/sqlite3.c:80512 (interactive_ui_tests+0x9afc5ba)
    #15 sql::Statement::StepInternal(bool) sql/statement.cc:70:13 (interactive_ui_tests+0x9ae5f3a)
    #16 sql::Statement::Step() sql/statement.cc:96:10 (interactive_ui_tests+0x9ae64fe)
    #17 history::URLDatabase::AutocompleteForPrefix(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned long, bool, std::__1::vector<history::URLRow, std::__1::allocator<history::URLRow> >*) components/history/core/browser/url_database.cc:309:20 (interactive_ui_tests+0xa722b3c)
    #18 HistoryURLProvider::DoAutocomplete(history::HistoryBackend*, history::URLDatabase*, HistoryURLProviderParams*) components/omnibox/browser/history_url_provider.cc:768:11 (interactive_ui_tests+0xb89f91a)
    #19 HistoryURLProvider::ExecuteWithDB(HistoryURLProviderParams*, history::HistoryBackend*, history::URLDatabase*) components/omnibox/browser/history_url_provider.cc:685:5 (interactive_ui_tests+0xb8a03fe)

Some sort of race condition in sqllite?
Cc: tommycli@chromium.org
Labels: -Pri-1 Pri-2
Owner: pwnall@chromium.org
About a week before the first of the recent flakes, we changed the sqlite's data storage strategy (used in interactive ui tests) as part of
https://chromium-review.googlesource.com/c/chromium/src/+/1183786

Re-assigning to the author of this change, who would also know about other sqlite changes that may have happened recently
I have a CL here to break up that test into multiple unit tests:
https://chromium-review.googlesource.com/c/chromium/src/+/1232525
Project Member

Comment 60 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ea584509cbcfd83864080dd453d5542f445837d

commit 9ea584509cbcfd83864080dd453d5542f445837d
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Sep 21 17:37:55 2018

Omnibox: Break up OmniboxViewTest.PreserveDisplayTextOnFocusSearch

This test breaks up OmniboxViewTest.PreserveDisplayTextOnFocusSearch,
which was a browser test, into three smaller unit tests.

OmniboxViewTest.PreserveDisplayTextOnFocusSearch is flaky, and the
whole set of OmniboxViewTest.* browser tests have been flaky for at
least a year.

Bug: 751031
Change-Id: I6e7a8fc88f55fee706cdfc1ee0617ce4a27f5103
Reviewed-on: https://chromium-review.googlesource.com/1232525
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593246}
[modify] https://crrev.com/9ea584509cbcfd83864080dd453d5542f445837d/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/9ea584509cbcfd83864080dd453d5542f445837d/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
[modify] https://crrev.com/9ea584509cbcfd83864080dd453d5542f445837d/components/omnibox/browser/omnibox_controller.cc
[modify] https://crrev.com/9ea584509cbcfd83864080dd453d5542f445837d/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/9ea584509cbcfd83864080dd453d5542f445837d/components/omnibox/browser/omnibox_edit_model.h
[modify] https://crrev.com/9ea584509cbcfd83864080dd453d5542f445837d/components/omnibox/browser/omnibox_edit_model_unittest.cc
[modify] https://crrev.com/9ea584509cbcfd83864080dd453d5542f445837d/components/omnibox/browser/omnibox_view_unittest.cc
[modify] https://crrev.com/9ea584509cbcfd83864080dd453d5542f445837d/components/omnibox/browser/test_omnibox_view.cc
[modify] https://crrev.com/9ea584509cbcfd83864080dd453d5542f445837d/components/omnibox/browser/test_omnibox_view.h

Labels: -Sheriff-Chromium
Project Member

Comment 62 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/660ca3f59534cde9e55e0e694dae6f028e262277

commit 660ca3f59534cde9e55e0e694dae6f028e262277
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Nov 13 19:56:31 2018

Re-enable disabled tests in chrome/browser/ui/omnibox/.

These passed 50 times in a row on Windows.

This converts from watching NOTIFICATION_NAV_ENTRY_COMMIT to using a navigation
observer in hopes of fixing observed flakiness in EnterToSearch.

Bug:  69433 ,  133341 ,  133344 ,  133347 ,  133355 ,  133360 ,  146953 ,  408634 ,  431575 , 751031,  751543 ,  823532 ,  841195 
Change-Id: Ia8ce63c8a9aca1ea415fb99756b08409cbc8369c
Reviewed-on: https://chromium-review.googlesource.com/c/1332257
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607713}
[modify] https://crrev.com/660ca3f59534cde9e55e0e694dae6f028e262277/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Owner: tommycli@chromium.org
Summary: OmniboxViewTest.* are flaky. Convert them to unit tests. (was: OmniboxViewTest.* are flaky: "Check failed: false. Observers can only be added once!")
I think as a long term goal we should decompose all these flaky browser tests into unit tests.

Here's a sample CL that decomposes OmniboxViewTest.PreserveDisplayTextOnFocusSearch into three smaller unit tests:

https://chromium-review.googlesource.com/c/chromium/src/+/1232525
Blockedon: 911614
I'm seeing more flakiness with:

OmniboxViewTest.SelectAllStaysAfterUpdate
OmniboxViewTest.DeleteItem
OmniboxViewTest.BrowserAccelerators

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%207%20Tests%20x64%20%281%29/46132
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%207%20Tests%20x64%20%281%29/46134

Can we disable them again?
Project Member

Comment 66 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7aa736385473cedeb924a4bbe8efd57968e47b5b

commit 7aa736385473cedeb924a4bbe8efd57968e47b5b
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed Dec 19 01:16:21 2018

Omnibox: Disable some flaky browser tests.

New reports of flakiness, and I've confirmed on the flakiness dashboard.

I've seen FAIL PASS status on multiple platforms on the dashboard.

Disabling:
OmniboxViewTest.SelectAllStaysAfterUpdate
OmniboxViewTest.DeleteItem
OmniboxViewTest.BrowserAccelerators

Bug: 751031
Change-Id: I1b3971b0f2e44d596b11e93338ceb8ff76a66f35
Reviewed-on: https://chromium-review.googlesource.com/c/1383401
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617702}
[modify] https://crrev.com/7aa736385473cedeb924a4bbe8efd57968e47b5b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Project Member

Comment 67 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6b65acd50cea51998c459316a563cd7ae1b1c1e

commit e6b65acd50cea51998c459316a563cd7ae1b1c1e
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed Dec 19 22:17:49 2018

Omnibox Code Health: Remove a bunch of FRIENDs from OmniboxViewViews.

Most of these FRIENDs were not needed with some minor method moves
or calling the base class (which had the methods as public).

I question whether we should hide any member functions that were public
in base classes:
https://yosefk.com/c++fqa/inheritance-proper.html#fqa-21.1

Change-Id: Iee5b5d128fe3e801546a9ccf43e90c87e34a43b6
Bug: 751031
Reviewed-on: https://chromium-review.googlesource.com/c/1384617
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617975}
[modify] https://crrev.com/e6b65acd50cea51998c459316a563cd7ae1b1c1e/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/e6b65acd50cea51998c459316a563cd7ae1b1c1e/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/e6b65acd50cea51998c459316a563cd7ae1b1c1e/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
[modify] https://crrev.com/e6b65acd50cea51998c459316a563cd7ae1b1c1e/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc

Project Member

Comment 68 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a6dd400e71c6f0e4e2489a49b041b90b37ba31b

commit 4a6dd400e71c6f0e4e2489a49b041b90b37ba31b
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Dec 21 23:22:20 2018

Omnibox Code Health: Port 4 clipboard browser tests to unit tests

Doing this work for a couple reasons:
 - Unit tests are less flaky and faster.
 - These can be written as unit tests without losing any testing power.
 - Query in Omnibox may need to update the clipboard behavior soon,
   this is kind of adjacent work.

Bug: 874592, 751031
Change-Id: Ibf5273f22578be713ab3c48539ab5311e5c7a7cc
Reviewed-on: https://chromium-review.googlesource.com/c/1377174
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618663}
[modify] https://crrev.com/4a6dd400e71c6f0e4e2489a49b041b90b37ba31b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/4a6dd400e71c6f0e4e2489a49b041b90b37ba31b/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc

Project Member

Comment 69 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c57e13d5b888629c2a40ef44a9807e071c629dae

commit c57e13d5b888629c2a40ef44a9807e071c629dae
Author: Tommy C. Li <tommycli@chromium.org>
Date: Thu Jan 10 18:40:23 2019

Omnibox: Code health - Port Escape key browser test to unit test

Ports OmniboxViewTest.Escape to OmniboxViewViewsTest.RevertOnEscape.

The functionality should be equivalent.

Bug: 751031
Change-Id: I400ce3c242d9ff669ea0b6869440a571d1477c1c
Reviewed-on: https://chromium-review.googlesource.com/c/1403682
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621661}
[modify] https://crrev.com/c57e13d5b888629c2a40ef44a9807e071c629dae/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
[modify] https://crrev.com/c57e13d5b888629c2a40ef44a9807e071c629dae/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc

Project Member

Comment 70 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec52747a5abc25a862843edca761104b3c319764

commit ec52747a5abc25a862843edca761104b3c319764
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jan 14 16:16:49 2019

[ui_controls] Unflake Send*NotifyWhenDone() on Windows

ui_controls::Send*NotifyWhenDone() can be flaky when invoked after
ui_controls::Send*() as the former can decide to notify based on
observing a yet-to-be-processed event from the latter (or even a
yet-to-be-processed event emitted by unrelated code) and thus notify too
early, resuming and testing conditions that have yet to be met.

Solution: defer the notification if the system queue has pending events
of the same type awaiting dispatch.

Note: mouse move can be repeated indefinitely during a drag, as such we
consider a mouse move complete when it hits the target regardless of
remaining mouse move messages in the queue.

@ BUG OWNERS : This might unflake many currently disabled tests. I've
CC'ed interactive_ui_tests + Windows bugs, please try to re-enable your
test after this CL if you think it might be related.

Bug:  892228 , 640996, 897801,893078,876224,875443,873110,852786,850343,848049,846695,840369,798492,756338,751031,665296,651906,499858,468660,419468,238347,131612,106489,97777,92467
Change-Id: I548856a3948ff71a145435799b4ba3e689561f14
Reviewed-on: https://chromium-review.googlesource.com/c/1392178
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622470}
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/ui/base/test/ui_controls_internal_win.cc

Sign in to add a comment