Issue metadata
Sign in to add a comment
|
Modal permission prompts on Android appear for background or non-interactable tabs |
||||||||||||||||||||||
Issue descriptionThe PermissionRequestManager takes care of showing and hiding prompts on Desktop, but on Android we have the InfoBar system and our modal dialogs manage this themselves. Modal prompts will be displayed even for tabs which are in the background, but we should queue them until the tab is actually active.
,
Oct 20 2017
A few more cases that we might want to handle, in decreasing order of importance: - Chrome Home is half or fully open - Omnibar is focused - In the tab switcher - Page info is open? - Three dot menu is open?? Ideally these (not sure about the last two) would be covered by something like Tab.IsUserInteractable, although it seems like that only currently covers being in the tab switcher. Probably all of this logic can live on the Java side.
,
Oct 23 2017
Actually, I think the omnibar being focused counts as Chrome Home being fully open.
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6e04d9a38b99858c7247da58edc43867b312447 commit a6e04d9a38b99858c7247da58edc43867b312447 Author: Timothy Loh <timloh@chromium.org> Date: Tue Nov 07 04:54:55 2017 Modal permissions prompts shouldn't appear over Chrome Home This patch makes us not show modal permission prompts while Chrome Home is visible, instead delaying them until Chrome Home has been closed. If it is closed due to a navigation, we instead dismiss the prompt, as it would otherwise be shown only briefly and dismissed once the navigation completes. Bug: 751025 Change-Id: I2a0394b27b68927f628901589c946a9348f60f2d Reviewed-on: https://chromium-review.googlesource.com/737495 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#514396} [modify] https://crrev.com/a6e04d9a38b99858c7247da58edc43867b312447/chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
,
Nov 10 2017
,
Nov 16 2017
The patch from comment #4 deals with the Chrome Home case. The remaining cases mentioned in comment #2 I think we can leave for the tab-modal dialogs to cover (see bug 687010 for context). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 12 2017