New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 751019 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Aug 21
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary context menu get selected & looks weird on chrome://bookmarks page.

Reported by dchau...@etouch.net, Aug 1 2017 
Chrome Version: 61.0.3163.25 (Official Build)c85ed244dde02ff4dd2f4097ff6440183a0b23df-refs/branch-heads/3163@{#200} 32/64-bit.
OS: Windows (7,8,10), Mac(10.12.3, 10.12.5, 10.11.6), Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://bookmarks page.
2. Click on "Bookmark Manager" text at header and press "Ctrl + A" key.
3. Right click under 'Organize' section to open context menu and observe.

Unnecessary context menu get selected.
Context menu should not get selected.

This is a regression issue, broken in M-58 series, below is manual regression range.

Good build: 58.0.3012.0
Bad build: 58.0.3013.0 

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
454 KB View Download
Expected behavior.mp4
296 KB View Download

Comment 1 by rbasuvula@chromium.org, Aug 1 2017

Labels: hasbisect-per-revision
Owner: yosin@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:58.0.3012.0(Revision:450199).
Bad build:58.0.3013.0(Revision:450530).

You are probably looking for a change made after 450369 (known good), but no later than 450370 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/18375370aff250f59f5ef624ecf686d860377ece..d892f9592860691ae9a782c12260c94ed6bd1a63

From the CL above, assigning the issue to the concern owner

@yosin : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2680943004
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.5 and Able to reproduce in latest Canary #62.0.3173.0

Comment 2 by yosin@chromium.org, Aug 4 2017

Owner: ----
Status: Untriaged (was: Assigned)
Mark "Untriaged" to route to bookmark team.

This is expected behavior and compatible with Edge and Firefox and the patch[1] changed to so.
To fix this issue, please add "user-select: none" style to <cr-menu>.

When user hit Ctrl+A, selection covers before BODY and after BODY, thus <cr-menu> elements are
selected.

Before the patch[1], we set selection as "Bookmark Manager" to "Organize" due by visible
selection canonicalization.

After the patch[1], we keep selection to select BODY.

Note: This doesn't reproduce with MD version of bookmark manager.

[1] https://codereview.chromium.org/2680943004 in #c1.

Comment 3 by robliao@chromium.org, Aug 21

Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over a year.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment