New issue
Advanced search Search tips

Issue 751018 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 671916



Sign in to add a comment

[MacViewsBrowser] Browser window behavior using BrowserView should be the same as with BrowserWindowController

Project Member Reported by tapted@chromium.org, Aug 1 2017

Issue description

Chrome Version       : 61.0.3163.13
OS Version: OS X 10.12.5

General bug to ensure the browser build with mac_views_browser = true on Mac behaves the same as the Cocoa browser window.
 
Summary: [MacViewsBrowser] Browser window behavior using BrowserView should be the same as with BrowserWindowController (was: [MacViewsBrowser] Browser window behavior should using BrowserView as with BrowserWindowController)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb1ae2189f5021763cb8d82bf05df1b371582c5b

commit eb1ae2189f5021763cb8d82bf05df1b371582c5b
Author: Boris Yusupov <boriay@yandex-team.ru>
Date: Wed Aug 02 19:01:02 2017

Implement ViewsNSWindowDelegate::windowShouldClose

This to fix application menu Close Window for mac views like
-- save info to restore closed window
-- check onbeforeunload event

Bug:  751018 
Change-Id: I7a99def820f066fc1f47c3c2bae3a2abb49106ff
Reviewed-on: https://chromium-review.googlesource.com/591848
Commit-Queue: Boris Yusupov <boriay@yandex-team.ru>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491457}
[modify] https://crrev.com/eb1ae2189f5021763cb8d82bf05df1b371582c5b/ui/views/cocoa/views_nswindow_delegate.mm
[modify] https://crrev.com/eb1ae2189f5021763cb8d82bf05df1b371582c5b/ui/views/widget/native_widget_mac_unittest.mm

Status: WontFix (was: Available)
MacViews triage: this bug is too general to be useful; this work is tracked directly by  issue 671916 . WontFix.

Sign in to add a comment