Issue 751015 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	█ alexande...@intel.com Email to this user bounced
Closed:	Aug 2017
Cc:	reillyg@chromium.org
Components:	Blink>Sensor
EstimatedDays:	1
NextAction:	----
OS:	All
Pri:	2
Type:	Bug
Arch-x86_64 TE-NeedsTriageHelp Via-Wizard-API Needs-Triage-M62

[sensor] [LayoutTests] comparing two DOMMatrix with assert_array_equal will always get PASS

Project Member Reported by wanming....@intel.com, Aug 1 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
Test: https://chromium.googlesource.com/chromium/src.git/+/master/third_party/WebKit/LayoutTests/sensor/orientation-sensor.html

line: 74 
Code snippet: assert_array_equals(rotationDOMMatrix, kRotationDOMMatrix); 

What is the expected behavior?

What went wrong?
DOMMatrix is type of "object" rather than array, should not use "assert_array_equals".

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 62.0.3172.2  Channel: n/a
OS Version: 10.0
Flash Version:

Comment 1 by ranjitkan@chromium.org, Aug 2 2017

Labels: Needs-Triage-M62

Comment 2 by jmukthavaram@chromium.org, Aug 3 2017

Labels: TE-NeedsTriageHelp

As it is coding related issue,adding 'TE-NeedsTriageHelp' label to get more inputs from dev.

Thanks..!!

Comment 3 by alexande...@intel.com, Aug 4 2017

Cc: reillyg@chromium.org
Components: Blink>Sensor
EstimatedDays: 1
Labels: -OS-Windows OS-All
Owner: alexande...@intel.com
Status: Started (was: Unconfirmed)

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e8c0421c30935864d2417ff6d8a958807060b66

commit 7e8c0421c30935864d2417ff6d8a958807060b66
Author: Alexander Shalamov <alexander.shalamov@intel.com>
Date: Fri Aug 04 12:34:32 2017

[sensors] Fix orientation sensor layout test

Layout test for orientation sensor is using assert_array_equals
for DOMMatrix objects, thus, assert will always pass. This CL
fixes this issue by converting DOMMatrix to Float64Array.

Bug:  751015 
Change-Id: I599f864e631c667ce90b193590bfc4dda534cab6
Reviewed-on: https://chromium-review.googlesource.com/601971
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com>
Cr-Commit-Position: refs/heads/master@{#491999}
[modify] https://crrev.com/7e8c0421c30935864d2417ff6d8a958807060b66/third_party/WebKit/LayoutTests/sensor/orientation-sensor.html