Setting and close buttons do not disappear sometimes when mouse exits the notification region |
||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Set --enabled-new-style-notification (2) Create some notifications (3) Move mouse cursor on them in the message center What is the expected result? Setting and close buttons disappear after mouse cursor exits the notification region. What happens instead? Sometimes they don't. Thanks omrilio@ for reporting this!
,
Aug 10 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e1c98f44b4d732afc782e6ce3e3806e910f7f3b commit 5e1c98f44b4d732afc782e6ce3e3806e910f7f3b Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Aug 10 08:23:37 2017 Fix the hover cursor and buttons behavior on ARC notification We solve the issue by adding the default window targeter for popup notification. Bug: 751004 Change-Id: I0b69ddb1edc6123225296e5b1ce3dc6a2c6c49bf Reviewed-on: https://chromium-review.googlesource.com/606762 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#493333} [modify] https://crrev.com/5e1c98f44b4d732afc782e6ce3e3806e910f7f3b/ui/arc/notification/arc_notification_content_view.cc [modify] https://crrev.com/5e1c98f44b4d732afc782e6ce3e3806e910f7f3b/ui/arc/notification/arc_notification_content_view.h [modify] https://crrev.com/5e1c98f44b4d732afc782e6ce3e3806e910f7f3b/ui/message_center/views/toast_contents_view.cc
,
Aug 10 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ba9f0bd3a1d0b56a7826983094cb821e537c64e commit 4ba9f0bd3a1d0b56a7826983094cb821e537c64e Author: yoshiki iguchi <yoshiki@chromium.org> Date: Thu Aug 10 18:45:11 2017 Use NotificationControlButtonsView for new style notification By using the same implementation as NotificationView and ArcNotificationView, this patch solves minor issues/difference. This patch should affect only on ChromeOS, since NotificationHeaderView and NotificationViewMD are not used on the other platforms. Bug: 751004 Change-Id: I43c0e937da1099a9f6aba01fe25ba1fc025100f1 Reviewed-on: https://chromium-review.googlesource.com/609569 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#493478} [modify] https://crrev.com/4ba9f0bd3a1d0b56a7826983094cb821e537c64e/ui/message_center/views/notification_header_view.cc [modify] https://crrev.com/4ba9f0bd3a1d0b56a7826983094cb821e537c64e/ui/message_center/views/notification_header_view.h [modify] https://crrev.com/4ba9f0bd3a1d0b56a7826983094cb821e537c64e/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/4ba9f0bd3a1d0b56a7826983094cb821e537c64e/ui/message_center/views/notification_view_md.h [modify] https://crrev.com/4ba9f0bd3a1d0b56a7826983094cb821e537c64e/ui/message_center/views/notification_view_md_unittest.cc
,
Aug 10 2017
Requesting merging both CLs.
,
Aug 10 2017
Approving merge to M61 Chrome OS.
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f667e309073cd54ffd8afa0d6493f9be3641eee9 commit f667e309073cd54ffd8afa0d6493f9be3641eee9 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Fri Aug 11 09:00:27 2017 Fix the hover cursor and buttons behavior on ARC notification We solve the issue by adding the default window targeter for popup notification. TBR=yoshiki@chromium.org (cherry picked from commit 5e1c98f44b4d732afc782e6ce3e3806e910f7f3b) Bug: 751004 Change-Id: I0b69ddb1edc6123225296e5b1ce3dc6a2c6c49bf Reviewed-on: https://chromium-review.googlesource.com/606762 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#493333} Reviewed-on: https://chromium-review.googlesource.com/611848 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#485} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/f667e309073cd54ffd8afa0d6493f9be3641eee9/ui/arc/notification/arc_notification_content_view.cc [modify] https://crrev.com/f667e309073cd54ffd8afa0d6493f9be3641eee9/ui/arc/notification/arc_notification_content_view.h [modify] https://crrev.com/f667e309073cd54ffd8afa0d6493f9be3641eee9/ui/message_center/views/toast_contents_view.cc
,
Aug 16 2017
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tetsui@chromium.org
, Aug 4 2017Owner: yoshiki@chromium.org