Tests fail when trying to submit CL:
https://chromium-review.googlesource.com/c/590571/
Different run fails at different places. Paste one of the failure logs here:
[0731/194548.708694:ERROR:kill_posix.cc(84)] Unable to terminate process group 20971: No such process (3)
[ RUN ] BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor
Xlib: extension "RANDR" missing on display ":99".
[20971:20971:0731/194547.982208:WARNING:password_store_factory.cc(255)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[21252:21252:0731/194548.374070:WARNING:zip.cc(127)] Skipped file Cached Theme.pak
../../chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc:43: Failure
Value of: browser_view->IsActive()
Actual: false
Expected: true
../../chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc:45: Failure
Expected: theme_active_color
Which is: 1073741824
To be equal to: frame_active_color
Which is: 1124073472
[20971:20971:0731/194548.498241:ERROR:event_page_request_manager.cc(147)] An error encountered while waking the event page.
[20971:20971:0731/194548.498269:ERROR:event_page_request_manager.cc(89)] Draining request queue. (queue-length=2)
[ FAILED ] BrowserNonClientFrameViewBrowserTest.InactiveSeparatorColor, where TypeParam = and GetParam() = (1026 ms)
Given the CL adds two methods but no one calls, and a unit test which doesn't fail. It's unlikely to be caused by this CL.
Comment 1 by yucliu@chromium.org
, Aug 1 2017