Speed bisect blamed a WATCHLIST change |
||
Issue descriptionIssue 748528 (blink_perf.paint failing on 2 builders) blamed my change to WATCHLIST (af68cffd17ef07ce6756e4aacb7c88a2f877f155) was the culprit for performance regression, which is obviously wrong.
,
Aug 4 2017
Findit currently only supports analyzing the transition from stable (pass rate is <2% or >98%) to flaky (pass rate is between 2% to 98%). So Findit doesn't support analyzing the transition from flaky to hard failing yet, although we also observed such cases with C++ gtests. We could potentially support that with a change to the algorithm to identify the regression range, but since such cases are rare, it is not a priority task at the moment. I think we could revisit this once Findit supports analyzing flaky Telemetry benchmark tests. WDYT?
,
Aug 4 2017
That makes sense to me.
,
Aug 4 2017
We can says hard failing is 100%? :-) Seem like the general logic here could be is FindIt can detect transition of flaky rate from X to Y.
,
Aug 4 2017
how do you define flaky rate? For pass rate, our definition is: if M out of N executions of the test failed, the pass rate is M/N. For hard failing, my understanding is pass-rate = 0%.
,
Aug 4 2017
Err, I mean "pass rate" in #4 (and it's 0% as you said), sorry for confusing terminology. |
||
►
Sign in to add a comment |
||
Comment 1 by sullivan@chromium.org
, Aug 3 2017