New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 750985 link

Starred by 2 users
Status: Fixed
Owner:
█ kenjitoyama@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
█ zkoch@chromium.org
mpear...@chromium.org
█ gcomanici@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

[Omnibox]: Add OAuth2 token to contextual suggestion requests

Project Member Reported by kenjitoyama@chromium.org, Aug 1 2017 
Chrome Version: (copy from chrome://version)
OS: All

What steps will reproduce the problem?
(1) Open an ordinary (non-HTTPS) page like http://www.cnn.com/
(2) Click on the omnibox.
(3) Check chrome://net-internals for requests to contextual services. It should have an Authorization Bearer token.

What is the expected result?

The request should have an authentication bearer token.

What happens instead?

No authentication bearer token is sent in the request.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by kenjitoyama@chromium.org, Aug 1 2017

Cc: zkoch@chromium.org

Comment 2 by jdonnelly@chromium.org, Aug 1 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885

commit f1e4b577c1e9a6b81f2439fa44c5313e79ae1885
Author: Daniel Kenji Toyama <kenjitoyama@google.com>
Date: Thu Aug 03 16:31:11 2017

Add ContextualSuggestionsService to Omnibox.

This CL was cloned from https://codereview.chromium.org/2965173002/.

Create a new class `ContextualSuggestionsService` to fetch experimental
contextual suggestions for the omnibox.

Bug: 692471,609084,  750985 
Change-Id: Ib54be91b1c0e2cb1fcdaf9a7a43b71984e5c358c
Reviewed-on: https://chromium-review.googlesource.com/576284
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491762}
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/chrome/browser/BUILD.gn
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/chrome/browser/autocomplete/chrome_autocomplete_provider_client.h
[add] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/chrome/browser/autocomplete/contextual_suggestions_service_factory.cc
[add] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/chrome/browser/autocomplete/contextual_suggestions_service_factory.h
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/DEPS
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/autocomplete_provider_client.h
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/base_search_provider_unittest.cc
[add] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/contextual_suggestions_service.cc
[add] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/contextual_suggestions_service.h
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/keyword_provider_unittest.cc
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/mock_autocomplete_provider_client.cc
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/mock_autocomplete_provider_client.h
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/omnibox_field_trial.h
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/shortcuts_provider_unittest.cc
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/zero_suggest_provider.cc
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/components/omnibox/browser/zero_suggest_provider.h
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc
[modify] https://crrev.com/f1e4b577c1e9a6b81f2439fa44c5313e79ae1885/ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.h

Comment 4 by zkoch@chromium.org, Aug 3 2017

Labels: Merge-Request-61

Comment 5 by zkoch@chromium.org, Aug 3 2017

Labels: -Pri-3 Pri-1

Comment 6 by gov...@chromium.org, Aug 4 2017 

Before we approve merge to M61, please answer followings:
* Is this M61 regression?
* Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge to M61?
* Any other important details to justify the merge.
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 4 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by zkoch@chromium.org, Aug 7 2017

Labels: -Hotlist-Merge-Review -Merge-Review-61
Removing merge review labels, as after review, this doesn't seem to meet the bar for merge.

Comment 9 by kenjitoyama@chromium.org, Dec 4 2017

Status: Fixed (was: Assigned)
CL 621226 (https://chromium-review.googlesource.com/c/chromium/src/+/621226/14) fixed the remaining bug. ZeroSuggest requests to Cusco all have OAuth2 headers.
►

Sign in to add a comment