Remove gray line under search box |
||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open new launcher and type something in the search box. (2) Hit backspace to clear search. (3) There's a gray line under search box. What is the expected result? No gray line exists under search box.
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b88847f155f52d710e4eff4fe95657b56b944e0b commit b88847f155f52d710e4eff4fe95657b56b944e0b Author: Weidong Guo <weidongg@chromium.org> Date: Thu Aug 03 02:13:19 2017 Remove gray line under search box Changes: Draw the separator between search box and search results only when parent view's height is larger than search box height. BUG= 750951 Change-Id: I5ddd8b607c91b8a2272174157f0d232f18a0ee69 Reviewed-on: https://chromium-review.googlesource.com/595245 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491614} [modify] https://crrev.com/b88847f155f52d710e4eff4fe95657b56b944e0b/ui/app_list/views/search_result_page_view.cc
,
Aug 3 2017
,
Aug 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6044cddc71af9fd842d5ae92400d21e276d1ea7 commit d6044cddc71af9fd842d5ae92400d21e276d1ea7 Author: Maajid <maajid@chromium.org> Date: Mon Aug 07 21:05:36 2017 Remove gray line under search box Changes: Draw the separator between search box and search results only when parent view's height is larger than search box height. BUG= 750951 TBR=weidongg@chromium.org (cherry picked from commit b88847f155f52d710e4eff4fe95657b56b944e0b) Change-Id: I5ddd8b607c91b8a2272174157f0d232f18a0ee69 Reviewed-on: https://chromium-review.googlesource.com/595245 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491614} Reviewed-on: https://chromium-review.googlesource.com/604507 Reviewed-by: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#366} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/d6044cddc71af9fd842d5ae92400d21e276d1ea7/ui/app_list/views/search_result_page_view.cc
,
Aug 10 2017
This issue is still not fixed. There's a white horizontal line still appearing below the search bar of new launcher. Checked on Chrome OS 9827.0.0, 62.0.3176.0 dev build.
,
Aug 11 2017
I think you are talking about crbug.com/752685 , this bug should be fixed. It seems that Cl for crbug.com/752685 is not in 62.0.3176.0.
,
Nov 13 2017
10124.0.0, 64.0.3265.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by weidongg@chromium.org
, Aug 1 2017