New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 750948 link

Starred by 3 users
Status: Verified
Owner:
kmarshall@chromium.org
Closed: Aug 2017
Cc:
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Feature
Hotlist-MemoryInfra



Sign in to add a comment

Fuchsia: disable memory instrumentation, process metrics.

Project Member Reported by kmarshall@chromium.org, Aug 1 2017 
Remove memory_instrumentation, ProcessMetrics, and other instrumentation code and references to it for OS_FUCHSIA builds.

The instrumentation code can be re-enabled once the initial porting proof-of-concept phase has passed.

See https://docs.google.com/document/d/18qh1MRMKs8O5bmHp2nCNg0WJi1YyDs8-cu_Pxq76174/edit# for more information.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf7ca7a186a15260b25a171ba83e49e93a6c905d

commit bf7ca7a186a15260b25a171ba83e49e93a6c905d
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 03 18:28:56 2017

Fuchsia: stub out missing ProcessMetrics methods.

Fuchsia: stub out missing ProcessMetrics methods.
The absence of Fuchsia stubs for these methods produced linker errors
when compiling the headless shell.

R: scottmg@chromium.org
Bug:  750948 
Change-Id: If9e13e80e17852fe7692164b2cd0c728bdded9f3
Reviewed-on: https://chromium-review.googlesource.com/596624
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491799}
[modify] https://crrev.com/bf7ca7a186a15260b25a171ba83e49e93a6c905d/base/message_loop/message_loop.cc
[modify] https://crrev.com/bf7ca7a186a15260b25a171ba83e49e93a6c905d/base/message_loop/message_loop.h
[modify] https://crrev.com/bf7ca7a186a15260b25a171ba83e49e93a6c905d/base/process/process_metrics_fuchsia.cc
[add] https://crrev.com/bf7ca7a186a15260b25a171ba83e49e93a6c905d/build/args/fuchsia.gn

Comment 2 by kmarshall@chromium.org, Aug 3 2017

Owner: kmarshall@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a0dbb3f3efdb1d8916b8089975f2994c7c10e67

commit 4a0dbb3f3efdb1d8916b8089975f2994c7c10e67
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Fri Aug 11 00:35:48 2017

Add Fuchsia stub calls for resource_coordinator.

Add Fuchsia stub calls for resource_coordinator.
The calls will be fleshed out as the Fuchsia porting effort continues.

Bug:  750948 
Change-Id: Id8059773d1c7789ce0eb2d3661fac53043026048
Reviewed-on: https://chromium-review.googlesource.com/600951
Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493617}
[modify] https://crrev.com/4a0dbb3f3efdb1d8916b8089975f2994c7c10e67/services/resource_coordinator/public/cpp/BUILD.gn
[add] https://crrev.com/4a0dbb3f3efdb1d8916b8089975f2994c7c10e67/services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_fuchsia.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/114849986079cb65b8f3f8bd4fb51ab40974c36c

commit 114849986079cb65b8f3f8bd4fb51ab40974c36c
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Fri Aug 11 18:13:52 2017

Add Fuchsia method for EnableTerminationOnOutOfMemory().

Bug:  750948 
Change-Id: I6d6033b459423176b1d2454c95a1848e0464d4e4
Reviewed-on: https://chromium-review.googlesource.com/611440
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493814}
[modify] https://crrev.com/114849986079cb65b8f3f8bd4fb51ab40974c36c/base/process/memory_fuchsia.cc

Comment 5 by kmarshall@chromium.org, Aug 18 2017

Status: Verified (was: Assigned)
►

Sign in to add a comment