New issue
Advanced search Search tips

Issue 750947 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Re-evaluate Linux Chrome package dependencies

Project Member Reported by thestig@chromium.org, Aug 1 2017 
When we first started packaging Chrome on Linux, we hoped LSB can serve as a foundation such that Chrome only needed to depend on LSB, plus a few more specific things aren't part of LSB (yet). This way, Chrome would worry less about differences between distros. As long as a given Linux install meet LSB requirements, then it mostly satisfies Chrome's dependencies.

Some RPM-based distro users were never happy with this. (See  bug 133327 ) Furthermore, Debian eventually dropped LSB support. [1] i.e. Debian 9 no longer has a lsb package and only retains lsb-based and lsb-release.

As we pull back from depending on LSB in r474078 and r490728, we should take a moment and check our packaging dependencies to make sure it is complete. Otherwise, users can potentially succeed in installing a Chrome package, but not be able to actually run it.

[1] https://lwn.net/Articles/658809/
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa36bca9bb3efb87c3325dde5f183664b6995769

commit fa36bca9bb3efb87c3325dde5f183664b6995769
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Oct 02 23:01:54 2017

Clean up deb and rpm additional_deps

The only functional changes are on RPM:
* Removed zlib dependency.  The package only provides libz.so, and
  none of our binaries link against that.
* Added ca-certificates dependency.  It is now available on all
  supported RPM-based distros.

BUG= 750947 
R=thestig@chromium.org
TEST=install on minimum supported distros

Change-Id: I87555ed26e5fb44630b8fbfcaf049a21e093fa9c
Reviewed-on: https://chromium-review.googlesource.com/691300
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505835}
[modify] https://crrev.com/fa36bca9bb3efb87c3325dde5f183664b6995769/chrome/installer/linux/debian/additional_deps
[modify] https://crrev.com/fa36bca9bb3efb87c3325dde5f183664b6995769/chrome/installer/linux/rpm/additional_deps

Comment 2 by thomasanderson@chromium.org, Oct 3 2017

Status: Fixed (was: Available)
Hopefully our list of deps is complete now (besides the liberation-fonts dep on RPM which is left as a TODO0

Comment 3 by tomas.po...@gmail.com, Oct 4 2017 

FYI - I requested the liberation-fonts package to be added to RHEL - https://bugzilla.redhat.com/show_bug.cgi?id=1482760 (I think that RHEL was the only RPM based distro missing that package).

Comment 4 by thestig@chromium.org, Oct 4 2017 

re: comment 3 - Thanks! I'll keep an eye on that.
►

Sign in to add a comment